Re: [PATCH v1 2/4] memblock: allow to specify flags with memblock_add_node()

2021-09-28 Thread Heiko Carstens
ng > and we don't want to add the memory first and apply flags later: it > should happen within one memblock call. > > Signed-off-by: David Hildenbrand > --- ... > arch/s390/kernel/setup.c | 3 ++- For s390 Acked-by: Heiko Carstens

Re: [PATCH] s390/kexec: fix memory leak of ipl report buffer

2021-11-10 Thread Heiko Carstens
On Fri, Oct 29, 2021 at 06:31:32PM +0200, Philipp Rudo wrote: > Hi Baoquan, > > On Fri, 29 Oct 2021 17:26:35 +0800 > Baoquan He wrote: > > > A memory leak is reported by kmemleak scanning: ... > > The ipl report buffer is allocated via vmalloc, while has no chance to free > > if the kexe loading

Re: [PATCH v2 RESEND 2/2] s390/kexec: fix memory leak of ipl report buffer

2021-11-16 Thread Heiko Carstens
On Tue, Nov 16, 2021 at 11:31:01AM +0800, Baoquan He wrote: > unreferenced object 0x38000195000 (size 4096): > comm "kexec", pid 8548, jiffies 4294953647 (age 32443.270s) > hex dump (first 32 bytes): > 00 00 00 c8 20 00 00 00 00 00 00 c0 02 80 00 00 ... > 40 40 40 40 40 40

Re: [PATCH v2 1/2] s390/kexec: check the return value of ipl_report_finish

2021-11-16 Thread Heiko Carstens
ay fail and can return an error pointer instead of a valid pointer. Fix this and simplify by returning NULL in case of an error and let the only caller handle this case. Fixes: 99feaa717e55 ("s390/kexec_file: Create ipl report and pass to next kernel") Signed-off-by: Heiko Carstens ---

Re: [PATCH v2 2/2] s390/kexec: fix kmemleak

2021-11-18 Thread Heiko Carstens
On Thu, Nov 18, 2021 at 03:13:27PM +0800, Baoquan He wrote: > On 11/18/21 at 05:46am, kernel test robot wrote: > >arch/s390/kernel/machine_kexec_file.c: In function > > 'arch_kimage_file_post_load_cleanup': > > >> arch/s390/kernel/machine_kexec_file.c:332:9: error: implicit declaration > > >>

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-11-30 Thread Heiko Carstens
l.h | 2 - > kernel/module.c | 12 +++-- > kernel/module_signature.c| 56 +++- > kernel/module_signing.c | 33 +++--- > security/integrity/ima/ima_modsig.c | 22 ++ > 11 files changed, 113 i

Re: [PATCH 1/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2021-12-15 Thread Heiko Carstens
On Wed, Dec 15, 2021 at 01:43:00PM +0100, Simon Horman wrote: > On Mon, Dec 13, 2021 at 11:44:30AM +0100, Philipp Rudo wrote: > > Hi Alexander, > > > > @Alexander: Thanks for taking care of this. > > > > On Wed, 8 Dec 2021 13:53:55 +0100 > > Alexander Egorenkov wrote: > > > > > Starting with g

[PATCHv2 0/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2021-12-15 Thread Heiko Carstens
Version 2 of Alexander Egorenkov's fix with a changed commit message as pointed out by Philipp Rudo, and requested by Simon Horman. Please apply. Alexander Egorenkov (1): s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel() kexec/arch/s390/kexec-elf-rel-s390.c | 3 ++- 1 file

[PATCHv2 1/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2021-12-15 Thread Heiko Carstens
ponding s390 kernel discussion: * https://lore.kernel.org/linux-s390/20211208105801.188140-1-egore...@linux.ibm.com/T/#u Signed-off-by: Alexander Egorenkov Reported-by: Tao Liu Suggested-by: Philipp Rudo Reviewed-by: Philipp Rudo [h...@linux.ibm.com: changed commit message as requested by Philipp Rudo]

Re: [PATCH 1/3] vmcore: Convert copy_oldmem_page() to take an iov_iter

2021-12-16 Thread Heiko Carstens
On Mon, Dec 13, 2021 at 08:57:25AM +0100, Christoph Hellwig wrote: > On Mon, Dec 13, 2021 at 12:06:34AM +, Matthew Wilcox (Oracle) wrote: > > Instead of passing in a 'buf' and 'userbuf' argument, pass in an iov_iter. > > s390 needs more work to pass the iov_iter down further, or refactor, > > b

Re: [PATCH 1/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2022-01-10 Thread Heiko Carstens
On Mon, Jan 10, 2022 at 04:23:05PM +0100, Alexander Egorenkov wrote: > Heiko Carstens writes: > > Given that Alexander is currently not available, I will resend his > > patch with an updated commit message. > > Many thanks for the review and taking care of the review findin

Re: [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter

2022-04-11 Thread Heiko Carstens
On Fri, Apr 08, 2022 at 05:24:28PM +0800, Baoquan He wrote: > Add Heiko to CC. > > On 04/08/22 at 05:06pm, Baoquan He wrote: > > Copy the description of v3 cover letter from Willy: > > === > > For some reason several people have been sending bad patches to fix > > compiler warnings in vmcore recen

Re: [PATCH 13/30] s390/consoles: Improve panic notifiers reliability

2022-04-30 Thread Heiko Carstens
wn body, and changed the > priority of such notifiers to execute late, since they are "heavyweight" > for the panic environment, so we aim to reduce risks here. > Changed return values to NOTIFY_DONE as well, the standard one. > > Cc: Alexander Gordeev > Cc: Christian B

Re: [PATCH 22/30] panic: Introduce the panic post-reboot notifier list

2022-05-12 Thread Heiko Carstens
r effectively stopping the machine (s390). > > > > This patch introduces yet another notifier list to offer the > > architectures a way to add callbacks in such late moment on > > panic path without the need of ifdefs / hardcoded approaches. > > > > Cc: Alexand

Re: [PATCH v8 4/4] kexec, KEYS, s390: Make use of built-in and secondary keyring for signature verification

2022-05-18 Thread Heiko Carstens
nged, 13 insertions(+), 5 deletions(-) As far as I can tell this doesn't have any dependency to the other patches in this series, so should I pick this up for the s390 tree, or how will this go upstream? In any case: Acked-by: Heiko Carstens ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: kdump: No udev events for memory hotplug?

2011-10-27 Thread Heiko Carstens
On Wed, Oct 26, 2011 at 03:24:49PM -0400, Vivek Goyal wrote: > On Wed, Oct 26, 2011 at 06:08:12PM +0200, Michael Holzheu wrote: > > Hello Vivek and Eric, > > > > I noticed that on my system kernel 3.1 *no* udev events for memory > > hotplug are generated. Same on my RHEL6.1. > > > > # udevadm mon

Re: [PATCH v3 11/11] sysctl: treewide: constify the ctl_table argument of handlers

2024-04-29 Thread Heiko Carstens
ta_base.c| 10 ++--- > arch/s390/kernel/debug.c | 2 +- > arch/s390/kernel/topology.c | 2 +- > arch/s390/mm/cmm.c| 6 +-- Acked-by: Heiko Carstens # s390 ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec