Re: [PATCH v3 2/7] kexec_file: print out debugging message if required

2023-11-29 Thread Joe Perches
On Thu, 2023-11-30 at 10:39 +0800, Baoquan He wrote: > Replace pr_debug() with the newly added kexec_dprintk() in kexec_file > loading related codes. trivia: > diff --git a/kernel/crash_core.c b/kernel/crash_core.c [] > @@ -551,9 +551,12 @@ int crash_prepare_elf64_headers(struct crash_mem *mem,

Re: [PATCH v2 2/7] kexec_file: print out debugging message if required

2023-11-23 Thread Joe Perches
On Fri, 2023-11-24 at 11:36 +0800, Baoquan He wrote: > Replace pr_debug() with the newly added kexec_dprintk() in kexec_file > loading related codes. trivia for pr_debug -> kexec_dprintk conversions for the entire patch set: > diff --git a/kernel/crash_core.c b/kernel/crash_core.c [] > @@ -551,9

Re: [PATCH 1/7] kexec_file: add kexec_file flag to control debug printing

2023-11-14 Thread Joe Perches
On Tue, 2023-11-14 at 23:32 +0800, Baoquan He wrote: > When specifying 'kexec -c -d', kexec_load interface will print loading > information, e.g the regions where kernel/initrd/purgatory/cmdline > are put, the memmap passed to 2nd kernel taken as system RAM ranges, > and printing all contents of

Re: [PATCH RFC 2/2] checkpatch: warn on usage of VM_BUG_ON() and friends

2022-08-24 Thread Joe Perches
On Wed, 2022-08-24 at 18:31 +0200, David Hildenbrand wrote: > checkpatch does not point out that VM_BUG_ON() and friends should be > avoided, however, Linus notes: > > VM_BUG_ON() has the exact same semantics as BUG_ON. It is literally > no different, the only difference is "we can make

Re: [PATCH v2] docs: Fix typo in comment

2022-07-25 Thread Joe Perches
On Mon, 2022-07-25 at 09:57 -0400, William Breathitt Gray wrote: > On Mon, Jul 25, 2022 at 06:52:15AM -0700, Joe Perches wrote: > > On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote: > > > The fix is done with below command: > > > sed -i "s/the the /the /g"

Re: [PATCH v2] docs: Fix typo in comment

2022-07-25 Thread Joe Perches
On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote: > On 07/21/22 at 11:40am, Randy Dunlap wrote: > > On 7/21/22 11:36, Jonathan Corbet wrote: > > > "Slark Xiao" writes: > > > > May I know the maintainer of one subsystem could merge the changes > > > > contains lots of subsystem? I also know

Re: POC: Alternative solution: Re: [PATCH 0/4] printk: reimplement LOG_CONT handling

2020-08-14 Thread Joe Perches
On Fri, 2020-08-14 at 19:33 -0700, Linus Torvalds wrote: > On Fri, Aug 14, 2020 at 4:52 PM Joe Perches wrote: > > On Fri, 2020-08-14 at 15:46 -0700, Linus Torvalds wrote: > > > This is why I think any discussion that says "people should buffer > > > their lines

Re: POC: Alternative solution: Re: [PATCH 0/4] printk: reimplement LOG_CONT handling

2020-08-14 Thread Joe Perches
On Fri, 2020-08-14 at 15:46 -0700, Linus Torvalds wrote: > On Thu, Aug 13, 2020 at 4:54 AM Sergey Senozhatsky > wrote: > > I think what Linus said a long time ago was that the initial purpose of > > pr_cont was > > > > pr_info("Initialize feature foo..."); > > if

Re: [PATCH] kexec: Delete an unnecessary comparison

2020-08-14 Thread Joe Perches
On Thu, 2020-08-13 at 20:45 +0800, Youling Tang wrote: > Regardless of whether the ret value is zero or non-zero, the trajectory > of the program execution is the same, so there is no need to compare. > > Signed-off-by: Youling Tang > --- > kernel/kexec_file.c | 2 -- > 1 file changed, 2

Re: [PATCH 2/4] printk: store instead of processing cont parts

2020-07-20 Thread Joe Perches
On Mon, 2020-07-20 at 11:30 -0700, Linus Torvalds wrote: > On Sun, Jul 19, 2020 at 6:51 PM Sergey Senozhatsky > wrote: > > Do I get it right, what you are saying is - when we process a PR_CONT > > message the cont buffer should already contain previous non-LOG_NEWLINE > > and non-PR_CONT message,

Re: misc nits Re: [PATCH 1/2] printk: add lockless buffer

2020-03-02 Thread Joe Perches
On Mon, 2020-03-02 at 11:38 +0100, John Ogness wrote: > On 2020-02-21, Petr Mladek wrote: > > > diff --git a/kernel/printk/printk_ringbuffer.c > > > b/kernel/printk/printk_ringbuffer.c [] > > > +static struct prb_data_block *to_block(struct prb_data_ring *data_ring, > > > +

Re: [PATCH 0/2] printk: replace ringbuffer

2020-02-05 Thread Joe Perches
On Wed, 2020-02-05 at 16:48 +0100, John Ogness wrote: > On 2020-02-05, Sergey Senozhatsky wrote: > > 3BUG: KASAN: wild-memory-access in copy_data+0x129/0x220> > > 3Write of size 4 at addr 5a5a5a5a5a5a5a5a by task cat/474> > > The problem was due to an uninitialized pointer. > > Very recently

Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.

2018-10-25 Thread Joe Perches
On Mon, 2018-10-22 at 22:53 +0530, Arun KS wrote: > Remove managed_page_count_lock spinlock and instead use atomic > variables. Perhaps better to define and use macros for the accesses instead of specific uses of atomic_long_ Something like: #define totalram_pages()(unsigned

Re: [PATCH v8 1/2] Documentation: kdump: remind user of nr_cpus

2016-08-17 Thread Joe Perches
On Thu, 2016-08-18 at 10:31 +0800, Zhou Wenjian wrote: > nr_cpus can help to save memory. So we should remind user of it. trivia: > diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt [] > @@ -390,9 +390,11 @@ Notes on loading the dump-capture kernel: >  * Boot parameter

Re: [PATCH] MAINTAINERS: Kdump maintainers update

2016-05-25 Thread Joe Perches
On Wed, 2016-05-25 at 09:16 -0400, Vivek Goyal wrote: > I am proposing following updates to kdump maintainership. I have got > busy in other things and not getting time to spend on kdump.  > > Removed Haren Myneni as he has not participated in kdump development for > a long time now. > >

Re: [PATCH 1/3] kexec: Add debug printing of kimage table entries

2013-10-15 Thread Joe Perches
On Tue, 2013-10-15 at 19:48 +0200, Geert Uytterhoeven wrote: Print a list of pages to be copied if debugging is enabled. Consecutive entries are merged to reduce screen clutter. [] diff --git a/kernel/kexec.c b/kernel/kexec.c [] +static void kimage_print_block(const struct kimage_block *block)

Re: [PATCH v2] vmcore-dmesg: Understand = v3.11-rc4 dmesg

2013-09-19 Thread Joe Perches
: Vivek Goyal vgo...@redhat.com Cc: Joe Perches j...@perches.com Cc: Dave Young dyo...@redhat.com --- Acked-by: Dave Young dyo...@redhat.com It might be nice if there was a reference somewhere in the linux kernel source tree to whatever it is that this patch modifies

Re: [PATCH] vmcore-dmesg: Understand = v3.11-rc4 dmesg

2013-09-01 Thread Joe Perches
On Sun, 2013-09-01 at 21:12 +0200, Lubomir Rintel wrote: Symbol name changed with the following commit: 62e32ac printk: rename struct log to struct printk_log Thanks, I figured it would change/break something somewhere but I had no idea where. cheers, Joe

Re: [PATCH v3 2/2] kexec: Use min_t to simplify logic

2013-02-26 Thread Joe Perches
On Tue, 2013-02-26 at 13:30 +0800, Zhang Yanfei wrote: This is just a tweak: using min_t to simplify logic of variable assignments. v3: - cast type of (PAGE_SIZE - (maddr ~PAGE_MASK)) into size_t. Why? Isn't this just a redundant cast? diff --git a/kernel/kexec.c b/kernel/kexec.c [] @@

Re: [PATCH 16/21] kernel/kexec.c: use pr_level and add pr_fmt(fmt)

2009-10-05 Thread Joe Perches
On Mon, 2009-10-05 at 05:01 -0700, Eric W. Biederman wrote: Joe Perches j...@perches.com writes: Added #define pr_fmt(fmt) KBUILD_MODNAME : fmt Converted printk(KERN_level to pr_level( Added KERN_ERR to allocation failure message I'm dense and I haven't seen the discussions. What

[PATCH 00/21] pr_dbg, pr_fmt

2009-10-04 Thread Joe Perches
, kernel, and a few drivers. It also converts printk(KERN_level to pr_level in a few files that already had some pr_level uses. The conversion also generally used long length format strings in the place of multiple short strings to ease any grep/search. Joe Perches (21): include/linux

Re: [PATCH] [275/2many] MAINTAINERS - KDUMP

2007-10-16 Thread Joe Perches
On Wed, 2007-10-17 at 11:19 +0900, Simon Horman wrote: I take it that these changes got shelved or canned, as I still don't seem them in Linus' tree. I have all the changes kept up-to-date. I still hope to get some variant into a future release. But just for the record, the file lists seem

Re: [PATCH] [275/2many] MAINTAINERS - KDUMP

2007-10-16 Thread Joe Perches
On Wed, 2007-10-17 at 12:48 +0900, Simon Horman wrote: Do you have a criteria for including files. A file or file pattern specific to a maintained subsystem. Any time a subsystem file pattern matches a file, maintainers would be cc'd. The matching is non-exclusive. Multiple subsystems can