Re: [PATCH v5 4/4] printk: use the lockless ringbuffer

2020-07-18 Thread Marco Elver
On Thu, Jul 09, 2020 at 03:29PM +0206, John Ogness wrote: > Replace the existing ringbuffer usage and implementation with > lockless ringbuffer usage. Even though the new ringbuffer does not > require locking, all existing locking is left in place. Therefore, > this change is purely replacing the u

Re: [PATCH v5 4/4] printk: use the lockless ringbuffer

2020-07-19 Thread Marco Elver
On Sun, Jul 19, 2020 at 12:43PM +0900, Sergey Senozhatsky wrote: > Hi Marco, > > On (20/07/18 14:10), Marco Elver wrote: > > > > It seems this causes a regression observed at least with newline-only > > printks. I noticed this during -next testing because various

Re: [PATCH v5 4/4] printk: use the lockless ringbuffer

2020-07-20 Thread Marco Elver
On Mon, 20 Jul 2020 at 10:41, Sergey Senozhatsky wrote: > > On (20/07/20 08:43), Marco Elver wrote: > > On Sun, Jul 19, 2020 at 12:43PM +0900, Sergey Senozhatsky wrote: > > > > As I said, a number of debugging tools use them to format reports to be > > more readabl

Re: [PATCH v5 4/4] printk: use the lockless ringbuffer

2020-07-20 Thread Marco Elver
On Mon, 20 Jul 2020 at 12:20, John Ogness wrote: > > On 2020-07-18, Marco Elver wrote: > > It seems this causes a regression observed at least with newline-only > > printks. > > [...] > > -- >8 -- > > > > --- a/init/main.c > > +++

Re: [PATCH][next] printk: ringbuffer: support dataless records

2020-07-20 Thread Marco Elver
58 ++- > kernel/printk/printk_ringbuffer.h | 15 > 2 files changed, 35 insertions(+), 38 deletions(-) Thanks! Ran a couple tests and sanitizer report blank lines are back where they're expected. Tested-by: Marco Elver ___

Re: [PATCH 4/5] sched: unset panic_on_warn before calling panic()

2022-01-28 Thread Marco Elver
On Fri, 28 Jan 2022 at 12:42, Tiezhu Yang wrote: > > As done in the full WARN() handler, panic_on_warn needs to be cleared > before calling panic() to avoid recursive panics. > > Signed-off-by: Tiezhu Yang > --- > kernel/sched/core.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deleti

Re: [PATCH v2 3/5] panic: unset panic_on_warn inside panic()

2022-02-08 Thread Marco Elver
t; mm/kfence/report.c: kfence_report_error() > > In order to avoid copy-pasting "panic_on_warn = 0" all over the > places, it is better to move it inside panic() and then remove > it from the other places. > > Signed-off-by: Tiezhu Yang Reviewed-by: Marco Elver > --- > ker

Re: [PATCH v2 4/5] ubsan: no need to unset panic_on_warn in ubsan_epilogue()

2022-02-08 Thread Marco Elver
On Tue, 8 Feb 2022 at 13:51, Tiezhu Yang wrote: > > panic_on_warn is unset inside panic(), so no need to unset it > before calling panic() in ubsan_epilogue(). > > Signed-off-by: Tiezhu Yang Reviewed-by: Marco Elver > --- > lib/ubsan.c | 10 +- > 1 file ch

Re: [PATCH v2 5/5] kasan: no need to unset panic_on_warn in end_report()

2022-02-08 Thread Marco Elver
On Tue, 8 Feb 2022 at 13:51, Tiezhu Yang wrote: > > panic_on_warn is unset inside panic(), so no need to unset it > before calling panic() in end_report(). > > Signed-off-by: Tiezhu Yang Reviewed-by: Marco Elver > --- > mm/kasan/report.c | 10 +- > 1 file ch