Re: [PATCH v3] x86/purgatory: Remove LTO flags

2023-09-14 Thread Nick Desaulniers
...@vger.kernel.org > Cc: x...@kernel.org > Cc: l...@lists.linux.dev > Signed-off-by: Song Liu Thanks for the patch! Reviewed-by: Nick Desaulniers > > --- > AFAICT, x86 is the only arch that supports LTO and purgatory. > > Changes in v3: > 1. Fix "Fixes&q

Re: [PATCH v2] x86/purgatory: Remove LTO flags

2023-09-14 Thread Nick Desaulniers
could also add the use of an explicit linker script to rejoin .text.* sections back into .text. Simply disable the production of more .text.* sections for now; -flto* implies -ffunction-sections. -- Thanks, ~Nick Desaulniers ___ kexec mail

Re: [PATCH v2] x86/purgatory: Remove LTO flags

2023-09-11 Thread Nick Desaulniers
be more precise. > Cc: Ricardo Ribalda > Cc: Sami Tolvanen > Cc: kexec@lists.infradead.org > Cc: linux-ker...@vger.kernel.org > Cc: x...@kernel.org > Cc: l...@lists.linux.dev > Signed-off-by: Song Liu > > --- > AFAICT, x86 is the only arch that supports LTO and pu

Re: [PATCH] x86/purgatory: Remove LTO flags

2023-09-08 Thread Nick Desaulniers
On Fri, Sep 08, 2023 at 03:53:53PM -0700, Song Liu wrote: > With LTO enabled, ld.lld generates multiple .text sections for > purgatory.ro: > > $ readelf -S purgatory.ro | grep " .text" > [ 1] .text PROGBITS 0040 > [ 7] .text.purgatory PROGBITS

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Nick Desaulniers
filter-out -fprofile-sample-use=% > -fprofile-use=%,$(KBUILD_CFLAGS)) > + > # When linking purgatory.ro with -r unresolved symbols are not checked, > # also link a purgatory.chk binary without -r to check for unresolved > symbols. > PURGATORY_LDFLAGS := -e p

Re: [PATCH v5 2/2] x86/purgatory: Add linker script

2023-04-18 Thread Nick Desaulniers
On Tue, Apr 11, 2023 at 2:46 PM Ricardo Ribalda wrote: > > Hi Nick > > On Sat, 8 Apr 2023 at 01:22, Nick Desaulniers wrote: > > > > Hi Ricardo, > > Thanks for the patch! Please make sure to cc our mailing list > > for llvm specific issues. > > scripts

Re: [PATCH v5 2/2] x86/purgatory: Add linker script

2023-04-07 Thread Nick Desaulniers
line utilities without needing a full blown kexec setup? If you can share more info, I can bisect llvm quickly. If it requires profile data, you'll need to share it, since CrOS engineers still have not posted public documentation on AutoFDO as I have repeatedly asked for. > > + toolch

Re: [PATCH v5 4/4] printk: use the lockless ringbuffer

2020-08-11 Thread Nick Desaulniers
>From what I can tell, I think this patch ("printk: use the lockless ringbuffer") breaks lx-dmesg in CONFIG_GDB_SCRIPTS. (gdb) lx-dmesg Python Exception No symbol "log_first_idx" in specified context.: Error occurred in Python: No symbol "log_first_idx" in specified context. This command is us

Re: [PATCHv2] x86/purgatory: don't generate debug info for purgatory.ro

2020-08-03 Thread Nick Desaulniers
ingfan Liu > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: "H. Peter Anvin" > Cc: Hans de Goede > Cc: Nick Desaulniers > Cc: Arvind Sankar > Cc: Steve Wahl > Cc: linux-ker...@vger.kernel.org > Cc: kexec@lists.infradead.org > To:

Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 5:40 AM Eric W. Biederman wrote: > > Linus Torvalds writes: > > > On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers > > wrote: > >> > >> + akpm, Linus > >> > >> Bumping for review. > > > > Ugh.

Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr

2018-08-20 Thread Nick Desaulniers
+ akpm, Linus Bumping for review. On Mon, Aug 13, 2018 at 2:32 PM Nick Desaulniers wrote: > > + Simon (kexec) > > bumping for review. > On Wed, Aug 8, 2018 at 4:06 PM Nick Desaulniers > wrote: > > > > bumping for review > > On Wed, Aug 1, 2018 at

Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr

2018-08-13 Thread Nick Desaulniers
+ Simon (kexec) bumping for review. On Wed, Aug 8, 2018 at 4:06 PM Nick Desaulniers wrote: > > bumping for review > On Wed, Aug 1, 2018 at 2:08 PM Nick Desaulniers > wrote: > > > > As part of the effort to reduce the code duplication between _THIS_IP_ > >

Re: [PATCH] x86/kexec: prefer _THIS_IP_ to current_text_addr

2018-08-08 Thread Nick Desaulniers
bumping for review On Wed, Aug 1, 2018 at 2:08 PM Nick Desaulniers wrote: > > As part of the effort to reduce the code duplication between _THIS_IP_ > and current_text_addr(), let's consolidate callers of > current_text_addr() to use _THIS_IP_. > > Signed-off-by: Nick Des