Re: [PATCH v3 1/1] kernel/crash_core: Add crashkernel=auto for vmcore creation

2021-02-17 Thread Vivek Goyal
On Wed, Feb 17, 2021 at 02:26:53PM -0500, Steven Rostedt wrote: > On Wed, 17 Feb 2021 12:40:43 -0600 > john.p.donne...@oracle.com wrote: > > > Hello. > > > > Ping. > > > > Can we get this reviewed and staged ? > > > > Thank you. > > Andrew, > > Seems you are the only one pushing patches in fo

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-20 Thread Vivek Goyal
On Wed, Jul 20, 2016 at 09:35:30AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 20, 2016 at 01:45:42PM +1000, Balbir Singh wrote: > > > IOW, if your kernel forced signature verification, you should not be > > > able to do sig_enforce=0. If you kernel did not have > > > CONFIG_MODULE_SIG_FOR

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-20 Thread Vivek Goyal
On Wed, Jul 20, 2016 at 01:45:42PM +1000, Balbir Singh wrote: > > > > Command line options are not signed. I thought idea behind secureboot > > was to execute only trusted code and command line options don't enforce > > you to execute unsigned code. > > > >> > >> You can set

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-19 Thread Vivek Goyal
On Tue, Jul 19, 2016 at 01:47:28PM +0100, Mark Rutland wrote: > On Tue, Jul 19, 2016 at 08:24:06AM -0400, Vivek Goyal wrote: > > On Tue, Jul 19, 2016 at 11:52:00AM +0100, Mark Rutland wrote: > > > Regardless, this extended syscall changes some underlying assumptions > > >

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-19 Thread Vivek Goyal
On Tue, Jul 19, 2016 at 11:52:00AM +0100, Mark Rutland wrote: > On Tue, Jul 19, 2016 at 08:55:56AM +0800, Dave Young wrote: > > On 07/18/16 at 11:07am, Mark Rutland wrote: > > > On Mon, Jul 18, 2016 at 10:30:24AM +0800, Dave Young wrote: > > > > I do not think it is worth to add another syscall for

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-18 Thread Vivek Goyal
On Mon, Jul 18, 2016 at 09:26:29AM -0400, Vivek Goyal wrote: > On Mon, Jul 18, 2016 at 10:46:04PM +1000, Balbir Singh wrote: > > On Wed, 2016-07-13 at 14:22 -0400, Vivek Goyal wrote: > > > On Wed, Jul 13, 2016 at 06:40:10PM +0100, Russell King - ARM Linux wrote: > > >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-18 Thread Vivek Goyal
On Mon, Jul 18, 2016 at 10:46:04PM +1000, Balbir Singh wrote: > On Wed, 2016-07-13 at 14:22 -0400, Vivek Goyal wrote: > > On Wed, Jul 13, 2016 at 06:40:10PM +0100, Russell King - ARM Linux wrote: > > >  > > > On Wed, Jul 13, 2016 at 09:03:38AM -0400, Vivek Goyal wrote: &

Re: [PATCH] kexec: Add option to fallback to old kexec syscall when kexec file based syscall failed

2016-07-15 Thread Vivek Goyal
On Fri, Jul 15, 2016 at 04:42:40PM +0200, Petr Tesarik wrote: > On Fri, 15 Jul 2016 08:51:14 -0400 > Vivek Goyal wrote: > > > On Fri, Jul 15, 2016 at 09:58:22AM +0200, Petr Tesarik wrote: > > > On Fri, 15 Jul 2016 07:57:22 +0800 > > > joeyli wrote: > >

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-15 Thread Vivek Goyal
On Fri, Jul 15, 2016 at 09:31:02AM +0200, Arnd Bergmann wrote: > On Thursday, July 14, 2016 10:44:14 PM CEST Thiago Jung Bauermann wrote: > > Am Donnerstag, 14 Juli 2016, 10:29:11 schrieb Arnd Bergmann: > > > > > > > Right, but the question remains whether this helps while you allow the > > > boo

Re: [RFC 3/3] kexec: extend kexec_file_load system call

2016-07-15 Thread Vivek Goyal
On Tue, Jul 12, 2016 at 10:42:01AM +0900, AKASHI Takahiro wrote: [..] > -SYSCALL_DEFINE5(kexec_file_load, int, kernel_fd, int, initrd_fd, > +SYSCALL_DEFINE6(kexec_file_load, int, kernel_fd, int, initrd_fd, > unsigned long, cmdline_len, const char __user *, cmdline_ptr, > -

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-15 Thread Vivek Goyal
On Fri, Jul 15, 2016 at 09:49:25AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 13, 2016 at 03:13:42PM +0200, Arnd Bergmann wrote: > > On Wednesday, July 13, 2016 10:41:28 AM CEST Mark Rutland wrote: > > > The big question is whether this is a realistic case on a secure boot > > > system. >

Re: [PATCH] kexec: Add option to fallback to old kexec syscall when kexec file based syscall failed

2016-07-15 Thread Vivek Goyal
On Fri, Jul 15, 2016 at 09:58:22AM +0200, Petr Tesarik wrote: > On Fri, 15 Jul 2016 07:57:22 +0800 > joeyli wrote: > > > Hi Vivek > > > > On Thu, Jul 14, 2016 at 10:53:28AM -0400, Vivek Goyal wrote: > > > On Thu, Jul 14, 2016 at 04:45:11PM +0800, Lee, Chun

Re: [PATCH] kexec: Add option to fallback to old kexec syscall when kexec file based syscall failed

2016-07-14 Thread Vivek Goyal
verification policy. > > Cc: Simon Horman > Cc: Petr Tesarik > Cc: Vivek Goyal > Signed-off-by: Lee, Chun-Yi > --- > kexec/kexec.c | 13 + > kexec/kexec.h | 4 +++- > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/kexec/kexec.c

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Vivek Goyal
On Wed, Jul 13, 2016 at 06:40:10PM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 13, 2016 at 09:03:38AM -0400, Vivek Goyal wrote: > > On Wed, Jul 13, 2016 at 09:26:39AM +0100, Russell King - ARM Linux wrote: > > > Indeed - maybe Eric knows better, but I can't

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Vivek Goyal
On Wed, Jul 13, 2016 at 09:45:22AM +1000, Stewart Smith wrote: > Vivek Goyal writes: > > On Tue, Jul 12, 2016 at 10:58:09AM -0300, Thiago Jung Bauermann wrote: > >> Hello Eric, > >> > >> Am Dienstag, 12 Juli 2016, 08:25:48 schrieb Eric W. Biede

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Vivek Goyal
On Wed, Jul 13, 2016 at 09:41:39AM +1000, Stewart Smith wrote: > Petr Tesarik writes: > > On Tue, 12 Jul 2016 13:25:11 -0300 > > Thiago Jung Bauermann wrote: > > > >> Hi Eric, > >> > >> I'm trying to understand your concerns leading to your nack. I hope you > >> don't mind expanding your though

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-13 Thread Vivek Goyal
On Wed, Jul 13, 2016 at 09:26:39AM +0100, Russell King - ARM Linux wrote: > On Wed, Jul 13, 2016 at 05:55:33PM +1000, Stewart Smith wrote: > > Russell King - ARM Linux writes: > > > On Wed, Jul 13, 2016 at 02:59:51PM +1000, Stewart Smith wrote: > > >> Russell King - ARM Linux writes: > > >> > On

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Vivek Goyal
On Tue, Jul 12, 2016 at 04:02:46PM +0200, Arnd Bergmann wrote: > On Tuesday, July 12, 2016 8:25:48 AM CEST Eric W. Biederman wrote: > > AKASHI Takahiro writes: > > > > > Device tree blob must be passed to a second kernel on DTB-capable > > > archs, like powerpc and arm64, but the current kernel i

Re: [RFC 0/3] extend kexec_file_load system call

2016-07-12 Thread Vivek Goyal
On Tue, Jul 12, 2016 at 10:58:09AM -0300, Thiago Jung Bauermann wrote: > Hello Eric, > > Am Dienstag, 12 Juli 2016, 08:25:48 schrieb Eric W. Biederman: > > AKASHI Takahiro writes: > > > Device tree blob must be passed to a second kernel on DTB-capable > > > archs, like powerpc and arm64, but the

Re: [PATCH] MAINTAINERS: Kdump maintainers update

2016-05-25 Thread Vivek Goyal
On Wed, May 25, 2016 at 06:24:10AM -0700, Joe Perches wrote: > On Wed, 2016-05-25 at 09:16 -0400, Vivek Goyal wrote: > > I am proposing following updates to kdump maintainership. I have got > > busy in other things and not getting time to spend on kdump.  > > > > Rem

[PATCH] MAINTAINERS: Kdump maintainers update

2016-05-25 Thread Vivek Goyal
they have been contributing to kdump for a long time now and they are in a much better position to spend time on this than me. Signed-off-by: Vivek Goyal --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9c567a4..c030267 100644

Re: [PATCH] ARM: kexec: fix crashkernel= handling

2016-03-30 Thread Vivek Goyal
On Wed, Mar 30, 2016 at 02:05:30PM +0100, Russell King - ARM Linux wrote: > On Wed, Mar 30, 2016 at 06:09:22PM +0530, Pratyush Anand wrote: > > On 30/03/2016:09:46:38 AM, Dave Young wrote: > > > Hi, Russell > > > > > > A long standing issue, but nobody tried to do it. Thank you for bringing > > >

Re: [PATCH] kexec: Add --lite option

2015-10-22 Thread Vivek Goyal
On Thu, Oct 22, 2015 at 11:57:20AM -0700, Geoff Levand wrote: > Hi Dave, > > On Thu, 2015-10-22 at 11:17 +0800, Dave Young wrote: > > On 10/21/15 at 04:12pm, Geoff Levand wrote: > > > Add a new option --lite to kexec that allows for a fast reboot > > > by avoiding the purgatory integrity checks.

Re: [PATCH] kexec: Add --lite option

2015-10-22 Thread Vivek Goyal
On Thu, Oct 22, 2015 at 11:17:18AM +0800, Dave Young wrote: > On 10/21/15 at 04:12pm, Geoff Levand wrote: > > Add a new option --lite to kexec that allows for a fast reboot > > by avoiding the purgatory integrity checks. This option is > > intended for use by kexec based bootloaders that load a ne

Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-07-27 Thread Vivek Goyal
essary conditional judgement. > > Signed-off-by: Minfei Huang Looks good to me. Acked-by: Vivek Goyal Thanks Vivek > --- > kernel/kexec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 7a36fdc..458

Re: [PATCH V2 2/2] kexec: split kexec_load syscall from kexec core code

2015-07-21 Thread Vivek Goyal
On Mon, Jul 20, 2015 at 04:37:15PM +0800, dyo...@redhat.com wrote: > Now there's two kexec load syscall, one is kexec_load another is > kexec_file_load, kexec_file_load has been splited as kernel/kexec_file.c. > In this patch I split kexec_load syscall code to kernel/kexec.c. Hi Dave, Nice work.

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread Vivek Goyal
On Tue, Jul 14, 2015 at 01:01:12PM -0500, Eric W. Biederman wrote: > Vivek Goyal writes: > > > On Tue, Jul 14, 2015 at 05:29:53PM +, dwal...@fifo99.com wrote: > > > > [..] > >> > >> > If a machine is failing, there are high

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread Vivek Goyal
On Tue, Jul 14, 2015 at 05:29:53PM +, dwal...@fifo99.com wrote: [..] > > >> > If a machine is failing, there are high chance it can't deliver you the > > >> > notification. Detecting that failure suing some kind of polling > > >> > mechanism > > >> > might be more reliable. And it will make e

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread Vivek Goyal
On Tue, Jul 14, 2015 at 03:48:33PM +, dwal...@fifo99.com wrote: > On Tue, Jul 14, 2015 at 11:40:40AM -0400, Vivek Goyal wrote: > > On Tue, Jul 14, 2015 at 03:34:30PM +, dwal...@fifo99.com wrote: > > > On Tue, Jul 14, 2015 at 11:02:08AM -0400, Vivek Goyal wrote: > >

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread Vivek Goyal
On Tue, Jul 14, 2015 at 03:34:30PM +, dwal...@fifo99.com wrote: > On Tue, Jul 14, 2015 at 11:02:08AM -0400, Vivek Goyal wrote: > > On Tue, Jul 14, 2015 at 01:59:19PM +, dwal...@fifo99.com wrote: > > > On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: >

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread Vivek Goyal
On Tue, Jul 14, 2015 at 01:59:19PM +, dwal...@fifo99.com wrote: > On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: > > dwal...@fifo99.com writes: > > > > > On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: > > >> Hidehiro Kawai writes: > > >> > > >> > You c

Re: [PATCH 3/3] kexec: Change the timing of callbacks related to "crash_kexec_post_notifiers" boot option

2015-07-14 Thread Vivek Goyal
On Fri, Jul 10, 2015 at 08:33:31PM +0900, Hidehiro Kawai wrote: > This patch fixes problems reported by Daniel Walker > (https://lkml.org/lkml/2015/6/24/44), and also replaces the bug fix > commits 5375b70 and f45d85f. > > If "crash_kexec_post_notifiers" boot option is specified, > other cpus are

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread Vivek Goyal
On Tue, Jul 14, 2015 at 01:59:19PM +, dwal...@fifo99.com wrote: > On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: > > dwal...@fifo99.com writes: > > > > > On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: > > >> Hidehiro Kawai writes: > > >> > > >> > You c

Re: [PATCH v4] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-14 Thread Vivek Goyal
On Fri, Jul 10, 2015 at 11:14:06AM +0200, Michael Holzheu wrote: [..] > What about the following patch: > --- > diff --git a/kernel/kexec.c b/kernel/kexec.c > index 7a36fdc..7837c4e 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1236,10 +1236,68 @@ int kexec_load_disabled; > > stati

Re: [PATCH v3] kexec: Make a pair of map and unmap reserved pages when kdump fails to start

2015-07-07 Thread Vivek Goyal
On Thu, Jul 02, 2015 at 09:45:52AM +0800, Minfei Huang wrote: > For some arch, kexec shall map the reserved pages, then use them, when > we try to start the kdump service. > > Now kexec will never unmap the reserved pages, once it fails to continue > starting the kdump service. > > Make a pair of

Re: kexec_load(2) bypasses signature verification

2015-06-25 Thread Vivek Goyal
On Thu, Jun 25, 2015 at 04:48:18PM +0800, Dave Young wrote: > On 06/19/15 at 09:09am, Vivek Goyal wrote: > > On Fri, Jun 19, 2015 at 04:18:16PM +0800, Dave Young wrote: > > > > > If we want to disable unsigned kernel loading at compile time, then we > > > >

Re: kexec_load(2) bypasses signature verification

2015-06-19 Thread Vivek Goyal
On Fri, Jun 19, 2015 at 03:04:31PM +0800, Dave Young wrote: > On 06/16/15 at 09:47pm, Vivek Goyal wrote: > > On Tue, Jun 16, 2015 at 08:32:37PM -0500, Eric W. Biederman wrote: > > > Vivek Goyal writes: > > > > > > > On Tue, Jun 16, 2015 at 02

Re: kexec_load(2) bypasses signature verification

2015-06-19 Thread Vivek Goyal
On Fri, Jun 19, 2015 at 04:18:16PM +0800, Dave Young wrote: > > > If we want to disable unsigned kernel loading at compile time, then we > > > really need to work on decoupling CONFIG_KEXEC and CONFIG_FILE_KEXEC. > > > Introducing another config option is not the way forward, IMHO. > > > > Yes, le

Re: kexec_load(2) bypasses signature verification

2015-06-18 Thread Vivek Goyal
On Thu, Jun 18, 2015 at 10:02:09AM +0800, Dave Young wrote: [..] > > Or simply add a new config option KEXEC_VERIFY_SIG_FORCE, so we can return > > error in kexec_load and print some error message. > > Just like below, does this work for you, Ted? > > --- > arch/x86/Kconfig |7 +++ > ke

Re: kexec_load(2) bypasses signature verification

2015-06-16 Thread Vivek Goyal
On Tue, Jun 16, 2015 at 08:32:37PM -0500, Eric W. Biederman wrote: > Vivek Goyal writes: > > > On Tue, Jun 16, 2015 at 02:38:31PM -0500, Eric W. Biederman wrote: > >> > >> Adding Vivek as he is the one who implemented kexec_file_load. > >> I was hoping

Re: kexec_load(2) bypasses signature verification

2015-06-16 Thread Vivek Goyal
On Tue, Jun 16, 2015 at 02:38:31PM -0500, Eric W. Biederman wrote: > > Adding Vivek as he is the one who implemented kexec_file_load. > I was hoping he would respond to this thread, and it looks like he > simply has not ever been Cc'd. > > Theodore Ts'o writes: > > > On Mon, Jun 15, 2015 at 09:

Re: [PATCH] prepend elfcorehdr instead of appending it to the crash-kernel command-line.

2015-05-14 Thread Vivek Goyal
gt; > Signed-off-by: KarimAllah Ahmed Looks good to me. We might require a similar change in kexec-tools for old systemcall? Acked-by: Vivek Goyal Thanks Vivek > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: H. Peter Anvin > Cc: Andrew Morton > Cc: Vivek Goyal >

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Vivek Goyal
On Tue, Mar 24, 2015 at 05:18:14PM +0100, Ingo Molnar wrote: > > * Vivek Goyal wrote: > > > > Yet the actual bug is in that commit, 'crash_kexec_post_notifiers' > > > was clearly not a no-op in the default case, against expectations. > > > > Hi

Re: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Vivek Goyal
On Tue, Mar 24, 2015 at 08:11:29AM +0100, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > (2015/03/23 16:19), Ingo Molnar wrote: > > > > > > * Baoquan He wrote: > > > > > >> CC more people ... > > >> > > >> On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > >>> The commit f06

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-24 Thread Vivek Goyal
On Tue, Mar 24, 2015 at 05:27:10AM -0500, Eric W. Biederman wrote: > Ingo Molnar writes: > > > * Masami Hiramatsu wrote: > > > >> > > >> > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option > >> > for kdump after panic_notifers") > >> > > >> > Was that crash_kexec() was

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Vivek Goyal
uences > ... > > If it crashed due to some hardware failure, there's literally an > infinite amount of failure modes that may or may not be impacted by > kexec crash-time handling ordering. We don't want to put a zillion > such flags into the kernel proper just to

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Vivek Goyal
On Mon, Mar 23, 2015 at 02:50:46PM +0100, Ingo Molnar wrote: > > * Vivek Goyal wrote: > > > On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > > > > > * Baoquan He wrote: > > > > > > > CC more people ... > > > >

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-23 Thread Vivek Goyal
On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote: > > * Baoquan He wrote: > > > CC more people ... > > > > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote: > > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > > "crash_kexec_post_notifiers" kernel boot opti

Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-06 Thread Vivek Goyal
xec_post_notifiers" in the condition of kexec_should_crash(). > > Also, put a comment in kexec_should_crash() to explain not obvious > things on this patch. > > Signed-off-by: HATAYAMA Daisuke > Acked-by: Baoquan He > Tested-by: Hidehiro Kawai > Reviewed-by: Masami Hira

Re: [RESEND PATCH] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-05 Thread Vivek Goyal
On Thu, Mar 05, 2015 at 05:19:30PM -0500, Vivek Goyal wrote: > On Wed, Mar 04, 2015 at 05:56:48PM +0900, HATAYAMA Daisuke wrote: > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > > "crash_kexec_post_notifiers" kernel boot option, which toggles &

Re: [RESEND PATCH] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path

2015-03-05 Thread Vivek Goyal
On Wed, Mar 04, 2015 at 05:56:48PM +0900, HATAYAMA Daisuke wrote: > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced > "crash_kexec_post_notifiers" kernel boot option, which toggles > wheather panic() calls crash_kexec() before or after panic_notifiers > and dump kmsg. > > The proble

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2015-01-28 Thread Vivek Goyal
On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote: > On Wed, 28 Jan 2015, Vivek Goyal wrote: > > On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote: > > > On Wed, 28 Jan 2015, Vivek Goyal wrote: > > > > On Wed, Jan 28, 2015 at 04:49:34PM +01

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2015-01-28 Thread Vivek Goyal
On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote: > On Wed, 28 Jan 2015, Vivek Goyal wrote: > > On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote: > > > Hello Vivek, > > > > > > >> I've made various adjust

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2015-01-28 Thread Vivek Goyal
On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote: > [Dropping Andi into CC, which I should have done to start with, since > he wrote the original page, and might also have some comments] > > Hello Vivek, > > >> I've made various adjustments to the page in the light of y

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2015-01-28 Thread Vivek Goyal
On Wed, Jan 28, 2015 at 09:04:38AM +0100, Michael Kerrisk (man-pages) wrote: Hi Michael, [..] > >> * the number of bytes copied from userspace is min(bufsz, memsz) > > > > Yes. bufsz can not be more than memsz. There is a check to validate > > this in kernel. > > > > result = -EINVAL; > >

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2015-01-27 Thread Vivek Goyal
On Fri, Jan 16, 2015 at 02:30:25PM +0100, Michael Kerrisk (man-pages) wrote: [..] > Hi Michael, Please find my responses below. Sorry, I got stuck in other work and forgot about this thread. > So, returning to the kexeec_segment structure: > >struct kexec_segment { >

Re: [RFD] efi assisted kdump

2015-01-26 Thread Vivek Goyal
On Sat, Jan 24, 2015 at 09:26:37PM +0800, Dave Young wrote: > Hi, > > Kdump has several limitations currently such as kdump kernel reboot will > bypass > device shutdown path so device drivers should reset during initialization. > > * One of such problem we encounter now is the iommu > issue, 1s

Re: [PATCH v8 02/10] iommu/vt-d: Items required for kdump

2015-01-12 Thread Vivek Goyal
On Mon, Jan 12, 2015 at 05:06:46PM +0100, Joerg Roedel wrote: > On Mon, Jan 12, 2015 at 10:29:19AM -0500, Vivek Goyal wrote: > > Kdump has the notion of backup region. Where certain parts of old kernels > > memory can be moved to a different location (first 640K on x86 as of n

Re: [PATCH v8 02/10] iommu/vt-d: Items required for kdump

2015-01-12 Thread Vivek Goyal
On Mon, Jan 12, 2015 at 04:22:08PM +0100, Joerg Roedel wrote: > On Mon, Jan 12, 2015 at 03:06:20PM +0800, Li, Zhen-Hua wrote: > > + > > +#ifdef CONFIG_CRASH_DUMP > > + > > +/* > > + * Fix Crashdump failure caused by leftover DMA through a hardware IOMMU > > + * > > + * Fixes the crashdump kernel to

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2015-01-12 Thread Vivek Goyal
On Wed, Jan 07, 2015 at 10:17:56PM +0100, Michael Kerrisk (man-pages) wrote: [..] > >> .BR KEXEC_ON_CRASH " (since Linux 2.6.13)" > >> Execute the new kernel automatically on a system crash. > >> .\" FIXME Explain in more detail how KEXEC_ON_CRASH is actually used > > I wasn't expecting that you

Re: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

2015-01-06 Thread Vivek Goyal
On Tue, Jan 06, 2015 at 08:46:44PM +0800, Baoquan He wrote: > On 01/06/15 at 04:05pm, Dave Young wrote: > > On 01/05/15 at 08:54pm, Vivek Goyal wrote: > > > On Tue, Jan 06, 2015 at 09:44:05AM +0800, Dave Young wrote: > > > > On 01/02/15 at 08:17am, Vivek Goyal wrote:

Re: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

2015-01-06 Thread Vivek Goyal
On Tue, Jan 06, 2015 at 04:05:00PM +0800, Dave Young wrote: > On 01/05/15 at 08:54pm, Vivek Goyal wrote: > > On Tue, Jan 06, 2015 at 09:44:05AM +0800, Dave Young wrote: > > > On 01/02/15 at 08:17am, Vivek Goyal wrote: > > > > On Fri, Jan 02, 2015 at 08:07:20A

Re: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

2015-01-05 Thread Vivek Goyal
On Tue, Jan 06, 2015 at 09:44:05AM +0800, Dave Young wrote: > On 01/02/15 at 08:17am, Vivek Goyal wrote: > > On Fri, Jan 02, 2015 at 08:07:20AM -0500, Prarit Bhargava wrote: > > > > > > > > > On 01/02/2015 07:54 AM, Vivek Goyal wrote: > > > >

Re: [PATCH] kexec: Fix a typo in comment

2015-01-02 Thread Vivek Goyal
On Fri, Jan 02, 2015 at 12:48:51PM -0600, Eric W. Biederman wrote: > Alexander Kuleshov writes: > > > Signed-off-by: Alexander Kuleshov > Acked-by: "Eric W. Biederman" [ CC akpm ] Simple fix. Acked-by: Vivek Goyal Thanks Vivek > > > --- > > kern

Re: [PATCH v2] kdump, vmcoreinfo: report actual value of phys_base

2015-01-02 Thread Vivek Goyal
On Mon, Dec 15, 2014 at 03:11:20PM -0800, Andrew Morton wrote: > > (cc trimmed a bit) > > On Thu, 13 Nov 2014 11:30:11 +0900 (JST) HATAYAMA Daisuke > wrote: > > > Currently, VMCOREINFO note information reports the virtual address of > > phys_base that is assigned to symbol phys_base. But this

Re: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

2015-01-02 Thread Vivek Goyal
On Fri, Jan 02, 2015 at 08:07:20AM -0500, Prarit Bhargava wrote: > > > On 01/02/2015 07:54 AM, Vivek Goyal wrote: > > On Tue, Dec 30, 2014 at 09:57:51AM -0500, Prarit Bhargava wrote: > >> panic_on_warn kernel parameter will cause the kernel to panic when a > >> W

Re: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

2015-01-02 Thread Vivek Goyal
st that kexec-tools does least amount of manipulation with command line. Thanks Vivek > Signed-off-by: Prarit Bhargava > Cc: Dave Young > Cc: Vivek Goyal > Cc: WANG Chao > --- > kexec/kexec.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --

Re: [PATCH] kdump, x86: report actual value of phys_base in VMCOREINFO

2014-11-17 Thread Vivek Goyal
On Fri, Nov 14, 2014 at 10:31:33AM +0900, HATAYAMA Daisuke wrote: > From: Vivek Goyal > Subject: Re: [PATCH] kdump, x86: report actual value of phys_base in > VMCOREINFO > Date: Thu, 13 Nov 2014 09:25:48 -0500 > > > On Thu, Nov 13, 2014 at 05:30:21PM +0900, HA

Re: [PATCH] kdump, x86: report actual value of phys_base in VMCOREINFO

2014-11-13 Thread Vivek Goyal
On Thu, Nov 13, 2014 at 05:30:21PM +0900, HATAYAMA, Daisuke wrote: > > > (2014/11/13 17:06), Petr Tesarik wrote: > >On Thu, 13 Nov 2014 09:17:09 +0900 (JST) > >HATAYAMA Daisuke wrote: > > > >>From: Vivek Goyal > >>Subject: Re: [PATCH] kd

Re: [PATCH] kdump, x86: report actual value of phys_base in VMCOREINFO

2014-11-12 Thread Vivek Goyal
On Wed, Nov 12, 2014 at 03:40:42PM +0900, HATAYAMA Daisuke wrote: > Currently, VMCOREINFO note information reports the virtual address of > phys_base that is assigned to symbol phys_base. But this doesn't make > sense because to refer to value of the phys_base, it's necessary to > get the value of

Re: Edited kexec_load(2) [kexec_file_load()] man page for review

2014-11-11 Thread Vivek Goyal
On Sun, Nov 09, 2014 at 08:17:49PM +0100, Michael Kerrisk (man-pages) wrote: > Hello Vivek (and all), > > Thanks for the kexec_file_load() patch [for the kexec_load(2) man page] > that you quite some time ago sent. I have merged it and done some > substantial editing as well. Could you please take

Re: [PATCH v8] kernel, add panic_on_warn

2014-11-06 Thread Vivek Goyal
On Thu, Nov 06, 2014 at 01:57:36PM -0800, David Rientjes wrote: [..] > You see that doing > > if (panic_on_warn) { > panic_on_warn = 0; > panic(...); > } > > is racy, I hope. If two threads WARN() at the same time, then there's > nothing preventing a dou

Re: [PATCH v6] kernel, add panic_on_warn

2014-11-03 Thread Vivek Goyal
On Mon, Nov 03, 2014 at 09:32:23AM -0500, Prarit Bhargava wrote: [..] > + > +static int __init panic_on_warn_setup(char *s) > +{ > + /* Enabling this on a kdump kernel could cause a bogus panic. */ > + if (!is_kdump_kernel()) > + panic_on_warn = 1; I think it would be better i

Re: [PATCH] kernel, add panic_on_warn

2014-11-03 Thread Vivek Goyal
On Mon, Nov 03, 2014 at 08:32:42AM -0500, Prarit Bhargava wrote: > > > On 10/30/2014 09:58 PM, Hedi Berriche wrote: > > On Thu, Oct 30, 2014 at 17:06 Prarit Bhargava wrote: > > | There have been several times where I have had to rebuild a kernel to > > | cause a panic when hitting a WARN() in the

Re: [PATCH V4] kernel, add bug_on_warn

2014-10-28 Thread Vivek Goyal
On Tue, Oct 28, 2014 at 05:44:25AM -0700, Andi Kleen wrote: > > > I suppose ... but that would mean I would have to explain to an end user > > > the > > > elaborate process of enabling kdb, inserting a break point, etc. The > > > whole > > > purpose of this is to let an end user panic on WARN()

Re: [PATCH V4] kernel, add bug_on_warn

2014-10-28 Thread Vivek Goyal
On Tue, Oct 28, 2014 at 08:22:16AM -0400, Prarit Bhargava wrote: > > > On 10/28/2014 08:16 AM, Andi Kleen wrote: > > On Fri, Oct 24, 2014 at 08:53:27AM -0400, Prarit Bhargava wrote: > >> There have been several times where I have had to rebuild a kernel to > >> cause a panic when hitting a WARN()

Re: [resend Patch v3 1/2] kaslr: check if kernel location is changed

2014-10-15 Thread Vivek Goyal
On Wed, Oct 15, 2014 at 11:37:01AM +0800, Baoquan He wrote: > On 10/14/14 at 08:49am, Vivek Goyal wrote: > > On Mon, Oct 13, 2014 at 01:22:42PM -0400, Vivek Goyal wrote: > > > On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote: > > > > On 10/13/20

Re: [resend Patch v3 1/2] kaslr: check if kernel location is changed

2014-10-14 Thread Vivek Goyal
On Mon, Oct 13, 2014 at 01:22:42PM -0400, Vivek Goyal wrote: > On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote: > > On 10/13/2014 08:19 AM, Vivek Goyal wrote: > > >>> > > >>> This really shouldn't have happened this way on x86-64. It has

Re: [resend Patch v3 1/2] kaslr: check if kernel location is changed

2014-10-13 Thread Vivek Goyal
On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote: > On 10/13/2014 08:19 AM, Vivek Goyal wrote: > >>> > >>> This really shouldn't have happened this way on x86-64. It has to happen > >>> this way on i386, but I worry that this may be a se

Re: [resend Patch v3 1/2] kaslr: check if kernel location is changed

2014-10-13 Thread Vivek Goyal
On Mon, Oct 13, 2014 at 08:52:57AM -0400, Vivek Goyal wrote: > On Sat, Oct 11, 2014 at 03:34:29AM -0700, H. Peter Anvin wrote: > > On 10/10/2014 08:14 PM, Baoquan He wrote: > > >On 10/08/14 at 03:27pm, Vivek Goyal wrote: > > >>On Wed, Oct 08, 2014 at 08:09:59

Re: [resend Patch v3 1/2] kaslr: check if kernel location is changed

2014-10-13 Thread Vivek Goyal
On Sat, Oct 11, 2014 at 03:34:29AM -0700, H. Peter Anvin wrote: > On 10/10/2014 08:14 PM, Baoquan He wrote: > >On 10/08/14 at 03:27pm, Vivek Goyal wrote: > >>On Wed, Oct 08, 2014 at 08:09:59AM -0700, H. Peter Anvin wrote: > > > >>>Sorry... this makes no sense

Re: [resend Patch v3 1/2] kaslr: check if kernel location is changed

2014-10-08 Thread Vivek Goyal
On Wed, Oct 08, 2014 at 08:09:59AM -0700, H. Peter Anvin wrote: > On 10/01/2014 06:52 AM, Vivek Goyal wrote: > > > > Hi Peter, > > > > I think there is some confusion. I will try to clarify. > > > > If we have 32bit signed overflow, we will not have

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-07 Thread Vivek Goyal
On Tue, Oct 07, 2014 at 01:12:57PM -0700, Geoff Levand wrote: > Hi Vivek, > > On Tue, 2014-10-07 at 14:45 -0400, Vivek Goyal wrote: > > On Tue, Oct 07, 2014 at 11:42:00AM -0700, Geoff Levand wrote: > > > Adding purgatory code to arm64 is low priority, and I currently >

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-07 Thread Vivek Goyal
On Tue, Oct 07, 2014 at 11:42:00AM -0700, Geoff Levand wrote: > Hi Vivek, > > On Tue, 2014-10-07 at 09:44 -0400, Vivek Goyal wrote: > > So as Mark and I discussed need of purgatory code in other mails, are you > > plannign to enable purgatory on arm64. > > Adding pur

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-07 Thread Vivek Goyal
On Tue, Oct 07, 2014 at 11:42:00AM -0700, Geoff Levand wrote: > Hi Vivek, > > On Tue, 2014-10-07 at 09:44 -0400, Vivek Goyal wrote: > > So as Mark and I discussed need of purgatory code in other mails, are you > > plannign to enable purgatory on arm64. > > Adding pur

Re: [PATCH 0/7] arm64 kexec kernel patches V3

2014-10-07 Thread Vivek Goyal
On Thu, Sep 25, 2014 at 12:23:26AM +, Geoff Levand wrote: > Hi All, > > This series adds the core support for kexec re-boots on arm64. I have tested > with the ARM VE fast model using various kernel config options for both the > first and second stage kernels. > > To load a second stage kern

Re: [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro

2014-10-07 Thread Vivek Goyal
On Tue, Oct 07, 2014 at 12:21:30AM +, Geoff Levand wrote: > linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc > definition and use the generic one. > > Signed-off-by: Geoff Levand I think this patch should be merged in previous patch. I guess after applying patch4, seri

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-07 Thread Vivek Goyal
On Fri, Oct 03, 2014 at 11:35:03AM -0700, Geoff Levand wrote: > Hi Vivek, > > On Wed, 2014-10-01 at 10:56 -0400, Vivek Goyal wrote: > > On Tue, Sep 30, 2014 at 12:54:37PM -0700, Geoff Levand wrote: > > > > [..] > > > > > +{ > > > > > +

Re: [PATCH 0/7] arm64 kexec kernel patches V3

2014-10-07 Thread Vivek Goyal
On Thu, Oct 02, 2014 at 03:59:55PM -0700, Geoff Levand wrote: > Hi Vivek, > > On Thu, 2014-10-02 at 15:08 -0400, Vivek Goyal wrote: > > On Tue, Sep 30, 2014 at 02:27:56PM -0700, Geoff Levand wrote: > > > For a running system you can check the device tree: > > > &

Re: [PATCH 0/7] arm64 kexec kernel patches V3

2014-10-07 Thread Vivek Goyal
On Fri, Oct 03, 2014 at 02:16:11PM -0700, Geoff Levand wrote: > Hi, > > On Wed, 2014-10-01 at 11:19 -0400, Vivek Goyal wrote: > > On Thu, Sep 25, 2014 at 12:23:26AM +, Geoff Levand wrote: > > > Hi All, > > > > > > This series adds the core su

Re: [PATCH] kexec: Remove unnecessary KERN_ERR from kexec.c

2014-10-07 Thread Vivek Goyal
On Tue, Oct 07, 2014 at 12:54:58PM +0900, Masanari Iida wrote: > This patch remove unnecessary KERN_ERR from pr_err() within kexec.c. > > Signed-off-by: Masanari Iida [cc akpm] Thanks for the fix. Acked-by: Vivek Goyal Vivek > --- > kernel/kexec.c | 2 +- > 1 file ch

Re: [PATCH 0/7] arm64 kexec kernel patches V3

2014-10-02 Thread Vivek Goyal
On Tue, Sep 30, 2014 at 02:27:56PM -0700, Geoff Levand wrote: > Hi Vivek, > > On Tue, 2014-09-30 at 16:29 -0400, Vivek Goyal wrote: > > On Thu, Sep 25, 2014 at 12:23:26AM +, Geoff Levand wrote: > > > > [..] > > > To load a second stage kernel and

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-02 Thread Vivek Goyal
On Thu, Oct 02, 2014 at 11:26:25AM +0100, Mark Rutland wrote: > On Wed, Oct 01, 2014 at 08:22:45PM +0100, Vivek Goyal wrote: > > On Wed, Oct 01, 2014 at 07:03:04PM +0100, Mark Rutland wrote: > > > > [..] > > > I assume we'd have the first kernel perform th

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-01 Thread Vivek Goyal
On Wed, Oct 01, 2014 at 07:03:04PM +0100, Mark Rutland wrote: [..] > I assume we'd have the first kernel perform the required cache maintenance. > Hi Mark, I am wondering, what kind of cache management is required here? What kind of dcaches are present on arm64. I see that Geoff's patches flush

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-01 Thread Vivek Goyal
On Wed, Oct 01, 2014 at 07:19:59PM +0100, Mark Rutland wrote: > On Wed, Oct 01, 2014 at 07:09:09PM +0100, Vivek Goyal wrote: > > On Wed, Oct 01, 2014 at 07:03:04PM +0100, Mark Rutland wrote: > > > On Wed, Oct 01, 2014 at 06:47:14PM +0100, Vivek Goyal wrote: > > > >

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-01 Thread Vivek Goyal
On Wed, Oct 01, 2014 at 07:03:04PM +0100, Mark Rutland wrote: > On Wed, Oct 01, 2014 at 06:47:14PM +0100, Vivek Goyal wrote: > > On Wed, Oct 01, 2014 at 05:16:21PM +0100, Mark Rutland wrote: > > > > [..] > > > I'm still rather unhappy about the mechanism

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-01 Thread Vivek Goyal
On Wed, Oct 01, 2014 at 05:16:21PM +0100, Mark Rutland wrote: [..] > I'm still rather unhappy about the mechanism by which the DTB is passed > by userspace and detected by the kernel, as I'd prefer that the user > explictly stated which segment they wanted to pass to the (Linux) > kernel, but that

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-01 Thread Vivek Goyal
On Wed, Oct 01, 2014 at 05:16:21PM +0100, Mark Rutland wrote: [..] > > > So this implementation makes passing dtb mandatory. So it will not work > > > with ACPI? > > > > I have not yet considered ACPI. It will most likely need to have > > something done differently. Secure boot will also need s

Re: [PATCH 0/7] arm64 kexec kernel patches V3

2014-10-01 Thread Vivek Goyal
On Thu, Sep 25, 2014 at 12:23:26AM +, Geoff Levand wrote: > Hi All, > > This series adds the core support for kexec re-boots on arm64. I have tested > with the ARM VE fast model using various kernel config options for both the > first and second stage kernels. Hi Geoff, Does this patch seri

Re: [PATCH 6/7] arm64/kexec: Add core kexec support

2014-10-01 Thread Vivek Goyal
On Tue, Sep 30, 2014 at 12:54:37PM -0700, Geoff Levand wrote: [..] > > > +{ > > > + switch (flag) { > > > + case IND_INDIRECTION: > > > + case IND_SOURCE: > > > + __flush_dcache_area(addr, PAGE_SIZE); > > > + break; > > > > So what does __flush_dcache_area() do? Flush data caches.

  1   2   3   4   5   6   7   8   9   10   >