Re: [PATCH v3 5/5] mm/slub: do not create dma-kmalloc if no managed pages in DMA zone

2021-12-15 Thread Vlastimil Babka
On 12/15/21 08:27, Christoph Hellwig wrote: > On Wed, Dec 15, 2021 at 07:03:35AM +, Hyeonggon Yoo wrote: >> I'm not sure that allocating from ZONE_DMA32 instead of ZONE_DMA >> for kdump kernel is nice way to solve this problem. > > What is the problem with zones in kdump kernels? My understan

Re: [PATCH v3 5/5] mm/slub: do not create dma-kmalloc if no managed pages in DMA zone

2021-12-14 Thread Vlastimil Babka
On 12/14/21 06:32, Baoquan He wrote: > On 12/13/21 at 01:43pm, Hyeonggon Yoo wrote: >> Hello Baoquan. I have a question on your code. >> >> On Mon, Dec 13, 2021 at 08:27:12PM +0800, Baoquan He wrote: >> > Dma-kmalloc will be created as long as CONFIG_ZONE_DMA is enabled. >> > However, it will fail

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Vlastimil Babka
On 06/16/2016 11:22 AM, Vitaly Kuznetsov wrote: _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, field of the struct page, to _refcount") broke kdump. makedumpfile(8) does stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While it is definitely possible t