[Patch] kexec: improve the debug printf in get_crash_notes_per_cpu()

2011-11-16 Thread WANG Cong
Signed-off-by: WANG Cong --- diff --git a/kexec/crashdump.c b/kexec/crashdump.c index 945b052..e7ac42c 100644 --- a/kexec/crashdump.c +++ b/kexec/crashdump.c @@ -102,8 +102,8 @@ int get_crash_notes_per_cpu(int cpu, uint64_t *addr, uint64_t *len) die("Cannot parse %s:

[Patch] kexec: fix several issues in get_crash_notes()

2011-11-16 Thread WANG Cong
a) We don't need 'crash_notes' array at all, save some bytes on stack. b) We forgot to fclose 'fp' before return. Signed-off-by: WANG Cong --- diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c index 98cda72..333f6ba 100644 --- a/kexec/arch/i

Re: Crash during vmcore_init

2011-11-14 Thread WANG Cong
On Tue, 11 Oct 2011 16:39:05 -0700, Tim Hartrick wrote: > Kexec, > > I have been experiencing the crash below on Ubuntu 10.04 running > 2.6.32-34-server and 2.6.38-8-server as the crashkernel on X86_64. The > tools are: > > kexec-tools 1:2.0.2-1ubuntu3 > makedumpfile 1.3.7-2 > kdump-tools 1

Re: kexec question

2011-09-14 Thread WANG Cong
On Mon, 12 Sep 2011 10:50:33 -0700, Mark Maule wrote: > Resending - did not include the kexec list in my prior email: > > I'm experimenting with kexec on x86_64. I see ppc64 has the ability to > reuse the initrd, which is something I would be very interested in using > for x86_64. > > Is the re

Re: copy of /proc/vmcore

2011-06-14 Thread WANG Cong
On Thu, 02 Jun 2011 18:34:29 -0300, Yermandu Patapitafious wrote: > Hello, > > The /proc/vmcore is not present before or after the crash > > I load the kernel from grub pass parameter: crashkernel=256M mem=2048M > bootmem_debug > and then kexec -p bzImage --append="root=/dev/sda5 maxcpus=1 irqpo

Re: Kexec & Memory Zones question

2011-05-17 Thread WANG Cong
On Tue, 17 May 2011 19:05:13 -0700, Sujit V wrote: > We found the root cause for this issue in the bootmem allocator. > > The 96GB NUMA system has two memory nodes each with 48GB. node 0 had > zone dma, dma32 & normal > node 1 had only zone normal. > > During the early boot i.e kernel/setup.c Th

Re: kdump with /proc/oldproc

2011-05-17 Thread WANG Cong
On Tue, 17 May 2011 12:30:58 -0500, Nathan D Miller wrote: > Hello- > > Has anyone tried reconstituting a portion of the old kernel's /proc > while in the capture kernel? > > I had the idea while digging through the kexec/kdump code and it seemed > intriguing. > > It might be a means by which u

Re: Kexec & Memory Zones question

2011-05-12 Thread WANG Cong
On Wed, 11 May 2011 11:09:08 -0400, Vivek Goyal wrote: > We have discussed this in the past and due to various reasons the max > amount of RAM you can boot your kernel from seems to be 896MB for x86_64 > and 512MB for 32bit. I shall have to open a previous thread with hpa to > get exact numbers. S

Re: [Bug] Kdump does not work when panic triggered due to MCE

2011-05-10 Thread WANG Cong
On Mon, 09 May 2011 22:33:36 +0530, K.Prasad wrote: > That's interesting! Assuming that these are not software induced MCEs > but panic() calls invoked due to unrecoverable memory errors in a > physical machine, did you experience any situation where the kdump > kernel hung/rebooted due to a secon

Re: Kexec & Memory Zones question

2011-05-10 Thread WANG Cong
On Wed, 04 May 2011 11:35:46 -0700, Sujit V wrote: > On our x86_64 NUMA hardware running linux 2.6.23 with two memory nodes > have the following zone layout > DMA 0 - 16MB > DMA32 16MB to 4GB > NORMAL 4GB to 96GB > > We had the crashkernel boot param as 128M@16M. I am using > kexec-tools-2.0

Re: how to use kexec on android?

2011-05-10 Thread WANG Cong
On Tue, 19 Apr 2011 20:21:52 +0800, zhangchenyu wrote: > hi: > I want to use kexec on android, could somebody tell me how to use > it? > I am wondering why you want to use it? For kdump or fast reboot? And does the android kernel support kexec? __

Re: kdump without the kexec

2011-05-10 Thread WANG Cong
On Mon, 09 May 2011 15:04:42 +0800, Lei Wen wrote: > Hi Cong, > > On Mon, May 9, 2011 at 2:42 PM, WANG Cong > wrote: >> On Sun, 08 May 2011 23:31:30 +0800, Lei Wen wrote: >> >>> Hi Bernhard, >>> >>> On Sat, May 7, 2011 at 3:55 PM, Bernhard Wa

Re: kdump without the kexec

2011-05-08 Thread WANG Cong
On Sun, 08 May 2011 23:31:30 +0800, Lei Wen wrote: > Hi Bernhard, > > On Sat, May 7, 2011 at 3:55 PM, Bernhard Walle > wrote: >> * Lei Wen >> [2011-05-06 16:33]: >>> >>> Is there any existed solution that could make the kdump without the >>> kexec? For some kind of system hang, always hardware

Re: [PATCH V2] kexec, x86: fix kexec when boot_params.hardware_subarch != 0

2011-03-29 Thread WANG Cong
On Mon, 28 Mar 2011 14:50:11 -0700, Chris Leech wrote: > kexec needs to keep the subarch setting the same as the running kernel > in the boot parameters, or the kernel will die in early setup. I ran > into this with X86_SUBARCH_MRST, but it should apply to CE4100 and any > future subarch that use

Re: Kexec on ARM -- Latest Status

2011-03-24 Thread WANG Cong
On Mon, 21 Mar 2011 06:56:21 -0700, ZAKIR AHMED wrote: > Hi, > > I just want to know if there is a doc OR a patch that describes that > changes that has to be done for having kexec and kdump for my kernel. I > am using ARM 11mpcore and linux-2.6.33 > > It would be of help if somebody could let m

Re: [PATCH -next] Documentation: Improve crashkernel= description

2011-02-07 Thread WANG Cong
On Sun, 06 Feb 2011 20:25:20 -0600, Rob Landley wrote: > > Suitable offset as in parses a known image type (ELF, bzImage, etc) to > find the start address? Or just assumes the entry point and load > address are the same? No, that is the start physical address of crashkernel, which should be yo

Re: [PATCH] kexec: include sysctl to disable

2011-01-19 Thread WANG Cong
On Thu, 20 Jan 2011 05:21:50 +, WANG Cong wrote: > On Wed, 19 Jan 2011 17:26:30 -0500, Eric Paris wrote: > >> much like /proc/sys/kernel/modules_disable is used to disable module >> loading, /proc/sys/kernel/kexec_disable is used to disable kexec code >> loading. It

Re: [PATCH] kexec: include sysctl to disable

2011-01-19 Thread WANG Cong
On Wed, 19 Jan 2011 17:26:30 -0500, Eric Paris wrote: > much like /proc/sys/kernel/modules_disable is used to disable module > loading, /proc/sys/kernel/kexec_disable is used to disable kexec code > loading. It would still be possible to use kexec -l to load a kernel, > set the tunable to 1 so th

Re: [Patch] kexec: remove redundant if-else

2008-07-19 Thread WANG Cong
On Fri, Jul 18, 2008 at 01:07:58PM -0700, Eric W. Biederman wrote: >WANG Cong <[EMAIL PROTECTED]> writes: > >> These if-else's can be removed. > >Why? That appears to be pointless code style thrashing. I don't think that is coding style fix. Because when we ar

[Patch] kexec: remove redundant if-else

2008-07-18 Thread WANG Cong
These if-else's can be removed. Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] --- diff --git a/kernel/kexec.c b/kernel/kexec.c index 1c5fcac..ea6fa9b 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -203,13 +203,11 @@ static int do_kimage_alloc(struct kima

[Patch] kexec/crashdump.c: remove useless code

2008-07-10 Thread WANG Cong
I think we don't need to print fopen errors when stat fails. Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Cc: Simon Horman <[EMAIL PROTECTED]> --- diff --git a/kexec/crashdump.c b/kexec/crashdump.c index 92de524..257b3f5 100644 --- a/kexec/crashdump.c +++ b/kexec/crashdump.c

Re: [PATCH] Remove CONFIG_EXPERIMENTAL from kdump

2008-06-25 Thread WANG Cong
On Wed, Jun 25, 2008 at 11:49:52PM +0200, Bernhard Walle wrote: >I would suggest to remove the "experimental" status from Kdump. >Kdump is now in the kernel since a long time and used by Enterprise >distributions. I don't think that "experimental" is true any more. > Agreed. Thanks. -- Hi, I'm

[Patch] kexec/crashdump.c: improve the code a bit

2008-06-24 Thread WANG Cong
Add the missing fclose(). Constify a char pointer. Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- diff --git a/kexec/crashdump.c b/kexec/crashdump.c index e0ba36d..92de524 100644 --- a/kexec/crashdump.c +++ b/kexec/crashdump.c @@ -107,10 +107,11 @@ int get_crash_notes_per_cpu(i

[Patch] kernel/kexec.c: make 'kimage_terminate' void

2008-06-24 Thread WANG Cong
Since kimage_terminate() always returns 0, make it void. Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Cc: Eric Biederman <[EMAIL PROTECTED]> --- diff --git a/kernel/kexec.c b/kernel/kexec.c index 1c5fcac..6db42ff 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -589,14 +589,12 @@

[Patch] 'make dist-clean' should clean more files

2008-06-24 Thread WANG Cong
Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- diff --git a/Makefile.in b/Makefile.in index b51c3a1..341e170 100644 --- a/Makefile.in +++ b/Makefile.in @@ -233,6 +233,8 @@ distclean: dist-clean dist-clean: clean $(RM) -f config.log config.status config.cache Makefile i

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-08 Thread WANG Cong
On Sun, Jun 08, 2008 at 03:46:30PM +0200, Bernhard Walle wrote: >This patch adds a 'flags' parameter to reserve_bootmem_generic() like it >already has been added in reserve_bootmem() with commit >72a7fe3967dbf86cb34e24fbf1d957fe24d2f246. > >It also changes all users to use BOOTMEM_DEFAULT, which do