[PATCH][next] printk: ringbuffer: support dataless records

2020-07-20 Thread John Ogness
With commit ("printk: use the lockless ringbuffer"), printk() started silently dropping messages without text because such records are not supported by the new printk ringbuffer. Add support for such records. Currently dataless records are denoted by INVALID_LPOS in order to recognize failed prb_

Re: [PATCH][next] printk: ringbuffer: support dataless records

2020-07-20 Thread Marco Elver
On Mon, Jul 20, 2020 at 04:07PM +0206, John Ogness wrote: > With commit ("printk: use the lockless ringbuffer"), printk() > started silently dropping messages without text because such > records are not supported by the new printk ringbuffer. > > Add support for such records. > > Currently datale

Re: [PATCH][next] printk: ringbuffer: support dataless records

2020-07-20 Thread Sergey Senozhatsky
On (20/07/20 16:07), John Ogness wrote: > > +/* Determine if a logical position refers to a data-less block. */ > +#define LPOS_DATALESS(lpos) ((lpos) & 1UL) > + [..] > @@ -1402,7 +1396,9 @@ static int prb_read(struct printk_ringbuffer *rb, u64 > seq, > /* Copy text data. If it

Re: [PATCH][next] printk: ringbuffer: support dataless records

2020-07-21 Thread John Ogness
On 2020-07-21, Sergey Senozhatsky wrote: >> @@ -1402,7 +1396,9 @@ static int prb_read(struct printk_ringbuffer *rb, u64 >> seq, >> /* Copy text data. If it fails, this is a data-less record. */ >> if (!copy_data(&rb->text_data_ring, &desc.text_blk_lpos, >> desc.info.text_len, >>