Re: [PATCH] Fix kexec x86_64 load failed bug

2008-11-26 Thread Bernhard Walle
* Simon Horman [2008-11-26 16:48]: > > On Wed, Nov 26, 2008 at 02:47:38PM +0800, Huang Ying wrote: > > On Wed, 2008-11-26 at 14:16 +0800, Simon Horman wrote: > > > On Wed, Nov 26, 2008 at 12:25:51PM +0800, Huang Ying wrote: > > > > On Wed, 2008-11-26 at 11:25 +0800, Randy Dunlap wrote: > > > > > Th

Re: [PATCH] Fix kexec x86_64 load failed bug

2008-11-25 Thread Simon Horman
On Wed, Nov 26, 2008 at 02:47:38PM +0800, Huang Ying wrote: > On Wed, 2008-11-26 at 14:16 +0800, Simon Horman wrote: > > On Wed, Nov 26, 2008 at 12:25:51PM +0800, Huang Ying wrote: > > > On Wed, 2008-11-26 at 11:25 +0800, Randy Dunlap wrote: > > > > This isn't kernel code? Where is /purgatory/ ? >

Re: [PATCH] Fix kexec x86_64 load failed bug

2008-11-25 Thread Huang Ying
On Wed, 2008-11-26 at 14:16 +0800, Simon Horman wrote: > On Wed, Nov 26, 2008 at 12:25:51PM +0800, Huang Ying wrote: > > On Wed, 2008-11-26 at 11:25 +0800, Randy Dunlap wrote: > > > This isn't kernel code? Where is /purgatory/ ? > > > > > > Anyway, for kernel code, that should be: > > > char *cmd

Re: [PATCH] Fix kexec x86_64 load failed bug

2008-11-25 Thread Simon Horman
On Wed, Nov 26, 2008 at 12:25:51PM +0800, Huang Ying wrote: > On Wed, 2008-11-26 at 11:25 +0800, Randy Dunlap wrote: > > This isn't kernel code? Where is /purgatory/ ? > > > > Anyway, for kernel code, that should be: > > char *cmdline_end = NULL; > > This patch is against kexec tools, not kernel

Re: [PATCH] Fix kexec x86_64 load failed bug

2008-11-25 Thread Huang Ying
On Wed, 2008-11-26 at 11:25 +0800, Randy Dunlap wrote: > This isn't kernel code? Where is /purgatory/ ? > > Anyway, for kernel code, that should be: > char *cmdline_end = NULL; This patch is against kexec tools, not kernel. Best Regards, Huang Ying signature.asc Description: This is a digita

Re: [PATCH] Fix kexec x86_64 load failed bug

2008-11-25 Thread Randy Dunlap
Huang Ying wrote: > Fix a bug of kexec load on x86_64. Kexec fails to do load on x86_64, with > error message: > > Symbol: cmdline_end not found cannot set > > Because kexec/arch/i386/kexec-bzImage.c accesses cmdline_end symbol in > i386 purgatory, but there is no cmdline_end in x86_64 purgator

[PATCH] Fix kexec x86_64 load failed bug

2008-11-25 Thread Huang Ying
Fix a bug of kexec load on x86_64. Kexec fails to do load on x86_64, with error message: Symbol: cmdline_end not found cannot set Because kexec/arch/i386/kexec-bzImage.c accesses cmdline_end symbol in i386 purgatory, but there is no cmdline_end in x86_64 purgatory, and kexec-bzImage.c is used b