Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Michal Hocko
On Thu 16-06-16 13:22:27, Vitaly Kuznetsov wrote: > Michal Hocko writes: > > > On Thu 16-06-16 12:30:16, Vitaly Kuznetsov wrote: > >> Christoph Hellwig writes: > >> > >> > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: > >> >> _count ->

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Vitaly Kuznetsov
Michal Hocko writes: > On Thu 16-06-16 12:30:16, Vitaly Kuznetsov wrote: >> Christoph Hellwig writes: >> >> > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: >> >> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count,

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Vitaly Kuznetsov
Christoph Hellwig writes: > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: >> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, >> field of the struct page, to _refcount") broke kdump. makedumpfile(8) does >> stuff like

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Vlastimil Babka
On 06/16/2016 11:22 AM, Vitaly Kuznetsov wrote: _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, field of the struct page, to _refcount") broke kdump. makedumpfile(8) does stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While it is definitely possible

Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Christoph Hellwig
On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: > _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, > field of the struct page, to _refcount") broke kdump. makedumpfile(8) does > stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While > it

[PATCH] Revert "mm: rename _count, field of the struct page, to _refcount"

2016-06-16 Thread Vitaly Kuznetsov
_count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, field of the struct page, to _refcount") broke kdump. makedumpfile(8) does stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While it is definitely possible to fix this particular tool I'm not sure about