Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-12-01 Thread Xunlei Pang
On 12/01/2016 at 06:33 PM, Joerg Roedel wrote: > On Thu, Dec 01, 2016 at 10:15:45AM +0800, Xunlei Pang wrote: >> index 3965e73..624eac9 100644 >> --- a/drivers/iommu/intel-iommu.c >> +++ b/drivers/iommu/intel-iommu.c >> @@ -2024,6 +2024,25 @@ static int domain_context_mapping_one(struct >> dmar_do

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-30 Thread Xunlei Pang
On 11/30/2016 at 10:26 PM, Joerg Roedel wrote: > On Wed, Nov 30, 2016 at 06:23:34PM +0800, Baoquan He wrote: >> OK, talked with Xunlei. The old cache could be entry with present bit >> set. > -EPARSE > > Anyway, what I was trying to say is, that the IOMMU TLB is tagged with > domain-ids, and that t

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-30 Thread Baoquan He
On 11/30/16 at 05:53pm, Baoquan He wrote: > On 11/30/16 at 05:03pm, Baoquan He wrote: > > On 11/30/16 at 04:15pm, Xunlei Pang wrote: > > > On 11/29/2016 at 10:35 PM, Joerg Roedel wrote: > > > > On Thu, Nov 17, 2016 at 10:47:28AM +0800, Xunlei Pang wrote: > > > >> As per the comment, the code here o

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-30 Thread Baoquan He
On 11/30/16 at 05:03pm, Baoquan He wrote: > On 11/30/16 at 04:15pm, Xunlei Pang wrote: > > On 11/29/2016 at 10:35 PM, Joerg Roedel wrote: > > > On Thu, Nov 17, 2016 at 10:47:28AM +0800, Xunlei Pang wrote: > > >> As per the comment, the code here only needs to flush context caches > > >> for the spe

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-30 Thread Baoquan He
On 11/30/16 at 04:15pm, Xunlei Pang wrote: > On 11/29/2016 at 10:35 PM, Joerg Roedel wrote: > > On Thu, Nov 17, 2016 at 10:47:28AM +0800, Xunlei Pang wrote: > >> As per the comment, the code here only needs to flush context caches > >> for the special domain 0 which is used to tag the > >> non-pres

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-30 Thread Xunlei Pang
On 11/29/2016 at 10:35 PM, Joerg Roedel wrote: > On Thu, Nov 17, 2016 at 10:47:28AM +0800, Xunlei Pang wrote: >> As per the comment, the code here only needs to flush context caches >> for the special domain 0 which is used to tag the >> non-present/erroneous caches, seems we should flush the old d

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-16 Thread Xunlei Pang
On 2016/11/16 at 22:58, Myron Stowe wrote: > On Wed, Nov 16, 2016 at 2:13 AM, Xunlei Pang wrote: >> Ccing David >> On 2016/11/16 at 17:02, Xunlei Pang wrote: >>> We met the DMAR fault both on hpsa P420i and P421 SmartArray controllers >>> under kdump, it can be steadily reproduced on several diffe

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-16 Thread Myron Stowe
On Wed, Nov 16, 2016 at 2:13 AM, Xunlei Pang wrote: > Ccing David > On 2016/11/16 at 17:02, Xunlei Pang wrote: >> We met the DMAR fault both on hpsa P420i and P421 SmartArray controllers >> under kdump, it can be steadily reproduced on several different machines, >> the dmesg log is like: >> HP HP

Re: [PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-16 Thread Xunlei Pang
Ccing David On 2016/11/16 at 17:02, Xunlei Pang wrote: > We met the DMAR fault both on hpsa P420i and P421 SmartArray controllers > under kdump, it can be steadily reproduced on several different machines, > the dmesg log is like: > HP HPSA Driver (v 3.4.16-0) > hpsa :02:00.0: using doorbell to

[PATCH] iommu/vt-d: Flush old iotlb for kdump when the device gets context mapped

2016-11-16 Thread Xunlei Pang
We met the DMAR fault both on hpsa P420i and P421 SmartArray controllers under kdump, it can be steadily reproduced on several different machines, the dmesg log is like: HP HPSA Driver (v 3.4.16-0) hpsa :02:00.0: using doorbell to reset controller hpsa :02:00.0: board ready after hard reset