Re: [PATCH] vmcore-dmesg: fix infinite loop if log buffer wraps around

2018-05-25 Thread Simon Horman
On Thu, May 24, 2018 at 10:07:17AM +0800, Baoquan He wrote: > On 05/23/18 at 01:59pm, Omar Sandoval wrote: > > From: Omar Sandoval > > > > We hit a bug where vmcore-dmesg would get stuck in a loop, and since we > > were redirecting the output to a file, it wouldn't stop until it filled > > up the

Re: [PATCH] vmcore-dmesg: fix infinite loop if log buffer wraps around

2018-05-23 Thread Baoquan He
On 05/23/18 at 01:59pm, Omar Sandoval wrote: > From: Omar Sandoval > > We hit a bug where vmcore-dmesg would get stuck in a loop, and since we > were redirecting the output to a file, it wouldn't stop until it filled > up the disk. This only happened when the dmesg buffer had filled up and > wrap

[PATCH] vmcore-dmesg: fix infinite loop if log buffer wraps around

2018-05-23 Thread Omar Sandoval
From: Omar Sandoval We hit a bug where vmcore-dmesg would get stuck in a loop, and since we were redirecting the output to a file, it wouldn't stop until it filled up the disk. This only happened when the dmesg buffer had filled up and wrapped around. It turns out that when we hit the end of the