Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-06 Thread Eduardo Habkost
On Thu, Nov 06, 2008 at 11:49:57AM +0200, Avi Kivity wrote: > Ingo Molnar wrote: >> general ack for the x86 bits, but i'm not sure whether we should be >> pushing this upstream so late in the cycle. If we do it in the next >> cycle then it's best we do it in the x86 tree, the KVM impact seems

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-06 Thread Avi Kivity
Vivek Goyal wrote: > Is there a way we can prevent any other module from using virt disable > callback incase kvm is not loaded? > We can inline the kvm specific code (which will make it useful for other hypervisors, and remove the hook). -- error compiling committee.c: too many arguments t

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-06 Thread Avi Kivity
Ingo Molnar wrote: > general ack for the x86 bits, but i'm not sure whether we should be > pushing this upstream so late in the cycle. If we do it in the next > cycle then it's best we do it in the x86 tree, the KVM impact seems > much smaller than the general x86 impact. > It certainly does

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-05 Thread Ingo Molnar
* Avi Kivity <[EMAIL PROTECTED]> wrote: > Eduardo Habkost wrote: >> Hi, >> >> This is a new version of the series to disabling virtualization on kdump, >> now extended to do the same tricks on emergency_restart() if needed. >> > > Looks good. If you me to push it upstream, I'll need kexec/kdu

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-05 Thread Eduardo Habkost
On Wed, Nov 05, 2008 at 09:44:12AM -0500, Vivek Goyal wrote: > On Tue, Nov 04, 2008 at 06:54:04PM +0200, Avi Kivity wrote: > > Eduardo Habkost wrote: > >> Hi, > >> > >> This is a new version of the series to disabling virtualization on kdump, > >> now extended to do the same tricks on emergency_res

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-05 Thread Vivek Goyal
On Tue, Nov 04, 2008 at 06:54:04PM +0200, Avi Kivity wrote: > Eduardo Habkost wrote: >> Hi, >> >> This is a new version of the series to disabling virtualization on kdump, >> now extended to do the same tricks on emergency_restart() if needed. >> > > Looks good. If you me to push it upstream, I

Re: [PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-04 Thread Avi Kivity
Eduardo Habkost wrote: > Hi, > > This is a new version of the series to disabling virtualization on kdump, > now extended to do the same tricks on emergency_restart() if needed. > Looks good. If you me to push it upstream, I'll need kexec/kdump acks. Otherwise, ack for the kvm bits. -- err

[PATCH 00/14] x86: disable virt on kdump and emergency_restart

2008-11-04 Thread Eduardo Habkost
Hi, This is a new version of the series to disabling virtualization on kdump, now extended to do the same tricks on emergency_restart() if needed. This series is against linux-next-20081103. Patches 01-07 simply move the non-kdump-specific parts of nmi_shootdown_cpus() to reboot.c, so it can be