Re: [PATCH 1/2 v7] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-30 Thread lijiang
在 2019年10月31日 02:25, kbuild test robot 写道: > Hi Lianbo, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on linus/master] > [also build test WARNING on v5.4-rc5 next-20191030] > [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH 1/2 v7] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-30 Thread kbuild test robot
Hi Lianbo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.4-rc5 next-20191030] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base'

Re: [PATCH 1/2 v7] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-29 Thread Baoquan He
On 10/29/19 at 02:06pm, lijiang wrote: > >> struct crash_memmap_data { > >> @@ -68,6 +70,19 @@ static inline void cpu_crash_vmclear_loaded_vmcss(void) > >>rcu_read_unlock(); > >> } > >> > >> +/* > >> + * When the crashkernel option is specified, only use the low > >> + * 1MiB for the real

Re: [PATCH 1/2 v7] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-29 Thread lijiang
在 2019年10月29日 13:28, Baoquan He 写道: > On 10/29/19 at 10:10am, Lianbo Jiang wrote: >> Kdump kernel will reuse the first 640k region because the real mode >> trampoline has to work in this area. When the vmcore is dumped, the >> old memory in this area may be accessed, therefore, kernel has to >>

Re: [PATCH 1/2 v7] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-28 Thread Baoquan He
On 10/29/19 at 10:10am, Lianbo Jiang wrote: > Kdump kernel will reuse the first 640k region because the real mode > trampoline has to work in this area. When the vmcore is dumped, the > old memory in this area may be accessed, therefore, kernel has to > copy the contents of the first 640k area to

[PATCH 1/2 v7] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-28 Thread Lianbo Jiang
Kdump kernel will reuse the first 640k region because the real mode trampoline has to work in this area. When the vmcore is dumped, the old memory in this area may be accessed, therefore, kernel has to copy the contents of the first 640k area to a backup region so that kdump kernel can read the