Re: [PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter

2021-12-13 Thread Matthew Wilcox
On Mon, Dec 13, 2021 at 09:02:57AM +0100, Christoph Hellwig wrote: > > > > ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos) > > { > > - return read_from_oldmem(buf, count, ppos, 0, > > + struct kvec kvec = { .iov_base = buf, .iov_len = count }; > > + struct iov_iter iter; > >

Re: [PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter

2021-12-13 Thread Baoquan He
On 12/13/21 at 09:02am, Christoph Hellwig wrote: > > > > ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos) > > { > > - return read_from_oldmem(buf, count, ppos, 0, > > + struct kvec kvec = { .iov_base = buf, .iov_len = count }; > > + struct iov_iter iter; > > + > > +

Re: [PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter

2021-12-13 Thread Christoph Hellwig
> > ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos) > { > - return read_from_oldmem(buf, count, ppos, 0, > + struct kvec kvec = { .iov_base = buf, .iov_len = count }; > + struct iov_iter iter; > + > + iov_iter_kvec(, READ, , 1, count); > + > + return

Re: [PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter

2021-12-12 Thread kernel test robot
Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/core] [also build test ERROR on arm64/for-next/core powerpc/next s390/features linus/master v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter

2021-12-12 Thread Matthew Wilcox (Oracle)
Remove the read_from_oldmem() wrapper introduced earlier and convert all the remaining callers to pass an iov_iter. Signed-off-by: Matthew Wilcox (Oracle) --- arch/x86/kernel/crash_dump_64.c | 7 +- fs/proc/vmcore.c| 40 +