Re: [PATCH 4/4] kexec/kexec-arm64.c: Add missing error handling paths

2018-12-15 Thread Bhupesh Sharma
On Fri, Dec 14, 2018 at 6:44 PM Vicente Bergas wrote: > > On Sun, Dec 9, 2018 at 10:45 PM Bhupesh Sharma wrote: > > > > Hello Akashi, > > > > Thanks for your review and sorry for my late reply. > > It seems I found the root cause of the issue and it is quite different > > from what I was thinking

Re: [PATCH 4/4] kexec/kexec-arm64.c: Add missing error handling paths

2018-12-14 Thread Vicente Bergas
On Sun, Dec 9, 2018 at 10:45 PM Bhupesh Sharma wrote: > > Hello Akashi, > > Thanks for your review and sorry for my late reply. > It seems I found the root cause of the issue and it is quite different > from what I was thinking before. > > The issue happens because we pass '/chosen' string to > 'f

Re: [PATCH 4/4] kexec/kexec-arm64.c: Add missing error handling paths

2018-12-09 Thread Bhupesh Sharma
Hello Akashi, Thanks for your review and sorry for my late reply. It seems I found the root cause of the issue and it is quite different from what I was thinking before. The issue happens because we pass '/chosen' string to 'fdt_add_subnode()' in 'kexec/dt-ops.c' instead of 'chosen' string. The

Re: [PATCH 4/4] kexec/kexec-arm64.c: Add missing error handling paths

2018-12-03 Thread AKASHI Takahiro
Bhupesh, Thank you for submitting a patch. One comment: On Fri, Nov 30, 2018 at 11:02:45AM +0530, Bhupesh Sharma wrote: > While creating the 2nd dtb to be passed to the secondary kernel > for arm64, we need to handle the return values from helper fdt > functions properly, to make sure that we can

[PATCH 4/4] kexec/kexec-arm64.c: Add missing error handling paths

2018-11-29 Thread Bhupesh Sharma
While creating the 2nd dtb to be passed to the secondary kernel for arm64, we need to handle the return values from helper fdt functions properly, to make sure that we can handle various command-line options being passed to 'kexec' both for kexec load and kdump purposes. This will provide proper e