Re: [PATCH v1] proc/vmcore: fix false positive lockdep warning

2022-01-19 Thread David Hildenbrand
On 19.01.22 16:15, David Hildenbrand wrote: > On 19.01.22 16:08, Boqun Feng wrote: >> Hi, >> >> On Wed, Jan 19, 2022 at 12:37:02PM +0100, David Hildenbrand wrote: >>> Lockdep complains that we do during mmap of the vmcore: >>> down_write(mmap_lock); >>> down_read(vmcore_cb_rwsem); >>> And

Re: [PATCH v1] proc/vmcore: fix false positive lockdep warning

2022-01-19 Thread David Hildenbrand
On 19.01.22 16:08, Boqun Feng wrote: > Hi, > > On Wed, Jan 19, 2022 at 12:37:02PM +0100, David Hildenbrand wrote: >> Lockdep complains that we do during mmap of the vmcore: >> down_write(mmap_lock); >> down_read(vmcore_cb_rwsem); >> And during read of the vmcore: >>

Re: [PATCH v1] proc/vmcore: fix false positive lockdep warning

2022-01-19 Thread Boqun Feng
Hi, On Wed, Jan 19, 2022 at 12:37:02PM +0100, David Hildenbrand wrote: > Lockdep complains that we do during mmap of the vmcore: > down_write(mmap_lock); > down_read(vmcore_cb_rwsem); > And during read of the vmcore: > down_read(vmcore_cb_rwsem); > down_read(mmap_lock); >

[PATCH v1] proc/vmcore: fix false positive lockdep warning

2022-01-19 Thread David Hildenbrand
Lockdep complains that we do during mmap of the vmcore: down_write(mmap_lock); down_read(vmcore_cb_rwsem); And during read of the vmcore: down_read(vmcore_cb_rwsem); down_read(mmap_lock); We cannot possibly deadlock when only taking vmcore_cb_rwsem in read mode,