Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-13 Thread David Woodhouse
On Tue, 2017-04-04 at 10:26 +0100, Will Deacon wrote: >  A > patch making arm64 consistent could be discussed separately, otherwise kdump > becomes the pedantic ISO guy trying to lead by example, but really everybody > ignores him because it's completely inconsequential and they also know he > went

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-04 Thread Will Deacon
Guys, we were supposed to stop discussing this three days ago. On Tue, Apr 04, 2017 at 09:44:04AM +0200, David Woodhouse wrote: > On Tue, 2017-04-04 at 16:35 +0900, AKASHI Takahiro wrote: > > > > Because I think that people sometimes use those two interchangeably. > > So I said I would defer to t

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-04 Thread David Woodhouse
On Tue, 2017-04-04 at 16:35 +0900, AKASHI Takahiro wrote: > > Because I think that people sometimes use those two interchangeably. > So I said I would defer to the maintainers. Sometimes they do, yes. Just as sometimes people use "their", "they're", and "there" interchangeably. Rarely in a profe

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-04 Thread Ard Biesheuvel
On 4 April 2017 at 08:35, AKASHI Takahiro wrote: > On Tue, Apr 04, 2017 at 06:14:55AM -, David Woodhouse wrote: >> >> > On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote: >> >> >> >> You still have typos here. >> > >> > I'd like to defer to the maintainers whether we prefer MiB o

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-04 Thread AKASHI Takahiro
On Tue, Apr 04, 2017 at 06:14:55AM -, David Woodhouse wrote: > > > On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote: > >> > >> You still have typos here. > > > > I'd like to defer to the maintainers whether we prefer MiB over MB. > > It is not really a matter of preference. One

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-03 Thread David Woodhouse
> On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote: >> >> You still have typos here. > > I'd like to defer to the maintainers whether we prefer MiB over MB. It is not really a matter of preference. One is correct; the other is not. While simple errors can of course be forgiven, I

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-03 Thread AKASHI Takahiro
On Mon, Apr 03, 2017 at 09:18:12AM +0100, David Woodhouse wrote: > > You still have typos here. I'd like to defer to the maintainers whether we prefer MiB over MB. Thanks, -Takahiro AKASHI ___ kexec mailing list kexec@lists.infradead.org http://lists.

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-04-03 Thread David Woodhouse
On Tue, 2017-03-28 at 15:51 +0900, AKASHI Takahiro wrote: > > +   if (crash_base == 0) { > +   /* Current arm64 boot protocol requires 2MB alignment */ > +   crash_base = memblock_find_in_range(0, ARCH_LOW_ADDRESS_LIMIT, > +   crash_size, SZ_

Re: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-03-28 Thread Ard Biesheuvel
On 28 March 2017 at 07:51, AKASHI Takahiro wrote: > "crashkernel=" kernel parameter specifies the size (and optionally > the start address) of the system ram to be used by crash dump kernel. > reserve_crashkernel() will allocate and reserve that memory at boot time > of primary kernel. > > The mem

[PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel

2017-03-28 Thread AKASHI Takahiro
"crashkernel=" kernel parameter specifies the size (and optionally the start address) of the system ram to be used by crash dump kernel. reserve_crashkernel() will allocate and reserve that memory at boot time of primary kernel. The memory range will be exposed to userspace as a resource named "Cr