Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-06-06 Thread Borislav Petkov
On Tue, May 28, 2019 at 10:49:54AM +0800, Kairui Song wrote: > Hi, by now, I still didn't see any tip branch pick up this patch yet, > any update? Ok, stuff is queued in tip:x86/boot now. Please test it as much as you can and send all fixes ontop. Thx. -- Regards/Gruss, Boris. Good mailing

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-27 Thread Kairui Song
On Wed, May 22, 2019 at 2:09 AM Borislav Petkov wrote: > > On Tue, May 21, 2019 at 05:02:59PM +0800, Kairui Song wrote: > > Hi Boris, would you prefer to just fold Junichi update patch into the > > previous one or I should send an updated patch? > > Please send a patch ontop after Ingo queues your

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-21 Thread Borislav Petkov
On Tue, May 21, 2019 at 02:53:52PM -0700, Dirk van der Merwe wrote: > Where can I find the next-merge-window tree? > > I can test against that too. It'll appear soon in a tip branch. I'd appreciate if you tested that instead - stay tuned... Thx. -- Regards/Gruss, Boris. ECO tip #101: Trim

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-21 Thread Dirk van der Merwe
On 5/13/19 8:33 PM, Baoquan He wrote: On 05/14/19 at 11:22am, Dave Young wrote: On 05/13/19 at 04:06pm, Baoquan He wrote: Hi Dave, On 05/13/19 at 09:50am, Borislav Petkov wrote: On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: This is a critical bug which breaks memory hotplug,

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-21 Thread Borislav Petkov
On Tue, May 21, 2019 at 05:02:59PM +0800, Kairui Song wrote: > Hi Boris, would you prefer to just fold Junichi update patch into the > previous one or I should send an updated patch? Please send a patch ontop after Ingo queues your old one, which should happen soon. This way it would also document

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-21 Thread Junichi Nomura
On 2019/05/21 18:02, Kairui Song wrote: > On Wed, May 15, 2019 at 3:10 PM Junichi Nomura wrote: >> On 5/15/19 3:58 PM, Borislav Petkov wrote: >>> On Wed, May 15, 2019 at 05:17:19AM +, Junichi Nomura wrote: I found kexec(1) fails to load kernel on a few machines if this patch is appli

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-21 Thread Kairui Song
On Wed, May 15, 2019 at 3:10 PM Junichi Nomura wrote: > > On 5/15/19 3:58 PM, Borislav Petkov wrote: > > On Wed, May 15, 2019 at 05:17:19AM +, Junichi Nomura wrote: > >> Hi Kairui, > >> > >> On 5/13/19 5:02 PM, Baoquan He wrote: > >>> On 05/13/19 at 09:50am, Borislav Petkov wrote: > On Mo

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-17 Thread Borislav Petkov
On Tue, May 14, 2019 at 11:22:08AM +0800, Dave Young wrote: > Another thing is we can move the get rsdp after console_init, but that > can be done later as separate patch. https://lkml.kernel.org/r/20190417090247.gd20...@zn.tnic -- Regards/Gruss, Boris. Good mailing practices for 400: avoid

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-15 Thread Junichi Nomura
On 5/15/19 3:58 PM, Borislav Petkov wrote: > On Wed, May 15, 2019 at 05:17:19AM +, Junichi Nomura wrote: >> Hi Kairui, >> >> On 5/13/19 5:02 PM, Baoquan He wrote: >>> On 05/13/19 at 09:50am, Borislav Petkov wrote: On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: So we're go

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Borislav Petkov
On Wed, May 15, 2019 at 05:17:19AM +, Junichi Nomura wrote: > Hi Kairui, > > On 5/13/19 5:02 PM, Baoquan He wrote: > > On 05/13/19 at 09:50am, Borislav Petkov wrote: > >> On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > >> So we're going to try it again this cycle and if there's n

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Junichi Nomura
On 5/15/19 10:08 AM, Dave Young wrote: > On 05/14/19 at 04:09pm, Ingo Molnar wrote: >>> Hmm, it seems caused by some WIP branch patches, I suspect below: >>> commit 124d6af5a5f559e516ed2c6ea857e889ed293b43 >>> x86/paravirt: Standardize 'insn_buff' variable names >> >> This commit had a bug which I

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Junichi Nomura
Hi Kairui, On 5/13/19 5:02 PM, Baoquan He wrote: > On 05/13/19 at 09:50am, Borislav Petkov wrote: >> On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: >> So we're going to try it again this cycle and if there's no fallout, it >> will go upstream. If not, it will have to be fixed. The usu

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Dave Young
On 05/14/19 at 04:09pm, Ingo Molnar wrote: > > * Dave Young wrote: > > > On 05/14/19 at 01:38pm, Peter Zijlstra wrote: > > > On Tue, May 14, 2019 at 04:48:41PM +0800, Dave Young wrote: > > > > > > > > I did some tests on the laptop, thing is: > > > > > 1. apply the 3 patches (two you posted +

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Ingo Molnar
* Dave Young wrote: > On 05/14/19 at 01:38pm, Peter Zijlstra wrote: > > On Tue, May 14, 2019 at 04:48:41PM +0800, Dave Young wrote: > > > > > > I did some tests on the laptop, thing is: > > > > 1. apply the 3 patches (two you posted + Boris's revert commit > > > > 52b922c3d49c) > > > >on

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Peter Zijlstra
On Tue, May 14, 2019 at 08:58:35PM +0800, Dave Young wrote: > Hmm, it seems caused by some WIP branch patches, I suspect below: Grmbl.. Ingo, can you zap all those WIP branches, please? They mostly just get in the way of things. If you want to run them, merge them in a private branch or something

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Dave Young
On 05/14/19 at 01:38pm, Peter Zijlstra wrote: > On Tue, May 14, 2019 at 04:48:41PM +0800, Dave Young wrote: > > > > I did some tests on the laptop, thing is: > > > 1. apply the 3 patches (two you posted + Boris's revert commit > > > 52b922c3d49c) > > >on latest Linus master branch, everythin

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Peter Zijlstra
On Tue, May 14, 2019 at 04:48:41PM +0800, Dave Young wrote: > > I did some tests on the laptop, thing is: > > 1. apply the 3 patches (two you posted + Boris's revert commit 52b922c3d49c) > >on latest Linus master branch, everything works fine. > > > > 2. build and test the tip/next-merge-win

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Kairui Song
On Tue, May 14, 2019 at 4:48 PM Dave Young wrote: > > On 05/14/19 at 11:22am, Dave Young wrote: > > On 05/13/19 at 04:06pm, Baoquan He wrote: > > > Hi Dave, > > > > > > On 05/13/19 at 09:50am, Borislav Petkov wrote: > > > > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > > > > > This

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-14 Thread Dave Young
On 05/14/19 at 11:22am, Dave Young wrote: > On 05/13/19 at 04:06pm, Baoquan He wrote: > > Hi Dave, > > > > On 05/13/19 at 09:50am, Borislav Petkov wrote: > > > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > > > > This is a critical bug which breaks memory hotplug, > > > > > > Pleas

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Baoquan He
On 05/14/19 at 11:22am, Dave Young wrote: > On 05/13/19 at 04:06pm, Baoquan He wrote: > > Hi Dave, > > > > On 05/13/19 at 09:50am, Borislav Petkov wrote: > > > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > > > > This is a critical bug which breaks memory hotplug, > > > > > > Pleas

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Dave Young
On 05/13/19 at 04:06pm, Baoquan He wrote: > Hi Dave, > > On 05/13/19 at 09:50am, Borislav Petkov wrote: > > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > > > This is a critical bug which breaks memory hotplug, > > > > Please concentrate and stop the blabla: > > > > 36f0c423552d (

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Baoquan He
Hi Dave, On 05/13/19 at 09:50am, Borislav Petkov wrote: > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > > This is a critical bug which breaks memory hotplug, > > Please concentrate and stop the blabla: > > 36f0c423552d ("x86/boot: Disable RSDP parsing temporarily") > > already e

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Baoquan He
On 05/13/19 at 09:50am, Borislav Petkov wrote: > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > > This is a critical bug which breaks memory hotplug, > > Please concentrate and stop the blabla: > > 36f0c423552d ("x86/boot: Disable RSDP parsing temporarily") > > already explains wh

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Borislav Petkov
On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote: > This is a critical bug which breaks memory hotplug, Please concentrate and stop the blabla: 36f0c423552d ("x86/boot: Disable RSDP parsing temporarily") already explains what the deal is. This code was *purposefully* disabled because w

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Baoquan He
On 05/13/19 at 09:07am, Borislav Petkov wrote: > Baoquan, > > On Mon, May 13, 2019 at 09:43:05AM +0800, Baoquan He wrote: > > Can this patchset be merged, or picked into tip? > > what is this thing that happens everytime after a kernel is released and > lasts for approximately 2 weeks? This is a

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-13 Thread Borislav Petkov
Baoquan, On Mon, May 13, 2019 at 09:43:05AM +0800, Baoquan He wrote: > Can this patchset be merged, or picked into tip? what is this thing that happens everytime after a kernel is released and lasts for approximately 2 weeks? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid t

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-05-12 Thread Baoquan He
Hi Boris, On 04/29/19 at 03:55pm, Borislav Petkov wrote: > From: Kairui Song > Date: Mon, 29 Apr 2019 08:23:18 +0800 > Subject: [PATCH] x86/kexec: Add the EFI system tables and ACPI tables to the > ident map > > Currently, only the whole physical memory is identity-mapped for the > kexec kerne

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-04-29 Thread Baoquan He
On 04/29/19 at 03:55pm, Borislav Petkov wrote: > On Mon, Apr 29, 2019 at 08:23:18AM +0800, Baoquan He wrote: > > +static int > > +map_acpi_tables(struct x86_mapping_info *info, pgd_t *level4p) > > +{ > > + unsigned long flags = IORESOURCE_MEM | IORESOURCE_BUSY; > > + struct init_pgtable_data da

Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-04-29 Thread Borislav Petkov
On Mon, Apr 29, 2019 at 08:23:18AM +0800, Baoquan He wrote: > +static int > +map_acpi_tables(struct x86_mapping_info *info, pgd_t *level4p) > +{ > + unsigned long flags = IORESOURCE_MEM | IORESOURCE_BUSY; > + struct init_pgtable_data data; > + > + data.info = info; > + data.level4p

[PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables

2019-04-28 Thread Baoquan He
From: Kairui Song The current code only builds identity mapping for physical memory during kexec-type loading. The regions reserved by firmware are not covered. In the later patch, the boot decompressing code of kexec-ed kernel tries to access EFI systab and ACPI tables, lacking identity mapping