Re: [PATCH v6 4/8] crash: add generic infrastructure for crash hotplug support

2022-04-13 Thread Baoquan He
On 04/13/22 at 07:37am, Eric DeVolder wrote: > > > On 4/12/22 21:41, Baoquan He wrote: > > On 04/11/22 at 08:54am, Eric DeVolder wrote: > > > > > > > > > On 4/11/22 04:20, Baoquan He wrote: > > > > Hi Eric, > > > > > > > > On 04/01/22 at 02:30pm, Eric DeVolder wrote: > > > > ... ... > > > > >

Re: [PATCH v6 4/8] crash: add generic infrastructure for crash hotplug support

2022-04-13 Thread Eric DeVolder
On 4/12/22 21:41, Baoquan He wrote: On 04/11/22 at 08:54am, Eric DeVolder wrote: On 4/11/22 04:20, Baoquan He wrote: Hi Eric, On 04/01/22 at 02:30pm, Eric DeVolder wrote: ... ... +static void crash_hotplug_handler(unsigned int hp_action, + unsigned long a, unsigned long b) I am

Re: [PATCH v6 4/8] crash: add generic infrastructure for crash hotplug support

2022-04-12 Thread Baoquan He
On 04/11/22 at 08:54am, Eric DeVolder wrote: > > > On 4/11/22 04:20, Baoquan He wrote: > > Hi Eric, > > > > On 04/01/22 at 02:30pm, Eric DeVolder wrote: > > ... ... > > > > > +static void crash_hotplug_handler(unsigned int hp_action, > > > + unsigned long a, unsigned long b) > > > > I am still

Re: [PATCH v6 4/8] crash: add generic infrastructure for crash hotplug support

2022-04-11 Thread Eric DeVolder
On 4/11/22 04:20, Baoquan He wrote: Hi Eric, On 04/01/22 at 02:30pm, Eric DeVolder wrote: ... ... +static void crash_hotplug_handler(unsigned int hp_action, + unsigned long a, unsigned long b) I am still struggling to consider if these unused parameters should be kept or removed. Do

Re: [PATCH v6 4/8] crash: add generic infrastructure for crash hotplug support

2022-04-11 Thread Baoquan He
Hi Eric, On 04/01/22 at 02:30pm, Eric DeVolder wrote: ... ... > +static void crash_hotplug_handler(unsigned int hp_action, > + unsigned long a, unsigned long b) I am still struggling to consider if these unused parameters should be kept or removed. Do you foresee or feel on which ARCH they c

[PATCH v6 4/8] crash: add generic infrastructure for crash hotplug support

2022-04-01 Thread Eric DeVolder
Upon CPU and memory changes, a generic crash_hotplug_handler() dispatches the hot plug/unplug event to the architecture specific arch_crash_hotplug_handler(). During the process, the kexec_mutex is held. To support cpu hotplug, a callback is registered to capture the CPUHP_AP_ONLINE_DYN online and