[PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-05 Thread Eric DeVolder
CPU and memory change notifications are received in order to regenerate the elfcorehdr. To support cpu hotplug, a callback is registered to capture the CPUHP_AP_ONLINE_DYN online and offline events via cpuhp_setup_state_nocalls(). To support memory hotplug, a notifier is registered to capture the

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-23 Thread Sourabh Jain
Hello Eric, On 06/05/22 00:15, Eric DeVolder wrote: CPU and memory change notifications are received in order to regenerate the elfcorehdr. To support cpu hotplug, a callback is registered to capture the CPUHP_AP_ONLINE_DYN online and offline events via cpuhp_setup_state_nocalls(). To support

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-23 Thread Eric DeVolder
On 5/23/22 03:36, Sourabh Jain wrote: Hello Eric, On 06/05/22 00:15, Eric DeVolder wrote: CPU and memory change notifications are received in order to regenerate the elfcorehdr. To support cpu hotplug, a callback is registered to capture the CPUHP_AP_ONLINE_DYN online and offline events via

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-31 Thread David Hildenbrand
On 12.05.22 18:10, Eric DeVolder wrote: > David, > Great questions! See inline responses below. > eric Sorry for the late reply, travel and vacation ... >> >>> + >>> +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_MEMORY_HOTPLUG) >>> +void __weak arch_crash_handle_hotplug_event(struct kimage *

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-31 Thread Eric DeVolder
On 5/31/22 08:15, David Hildenbrand wrote: On 12.05.22 18:10, Eric DeVolder wrote: David, Great questions! See inline responses below. eric Sorry for the late reply, travel and vacation ... No problem, greatly appreciate the feedback! eric + +#if defined(CONFIG_HOTPLUG_CPU) || define

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-06-15 Thread David Hildenbrand
On 01.06.22 00:25, Eric DeVolder wrote: > > > On 5/31/22 08:15, David Hildenbrand wrote: >> On 12.05.22 18:10, Eric DeVolder wrote: >>> David, >>> Great questions! See inline responses below. >>> eric >> >> Sorry for the late reply, travel and vacation ... > No problem, greatly appreciate the fee

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-06 Thread Baoquan He
On 05/05/22 at 02:45pm, Eric DeVolder wrote: .. > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 256cf6db573c..f197af50def6 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -9,12 +9,17 @@ > #include > #include > #include > +#include Wondering where hig

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-09 Thread Eric DeVolder
On 5/6/22 02:12, Baoquan He wrote: On 05/05/22 at 02:45pm, Eric DeVolder wrote: .. diff --git a/kernel/crash_core.c b/kernel/crash_core.c index 256cf6db573c..f197af50def6 100644 --- a/kernel/crash_core.c +++ b/kernel/crash_core.c @@ -9,12 +9,17 @@ #include #include #include +#inc

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-11 Thread Baoquan He
On 05/09/22 at 10:43am, Eric DeVolder wrote: > > > On 5/6/22 02:12, Baoquan He wrote: > > On 05/05/22 at 02:45pm, Eric DeVolder wrote: > > .. > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index 256cf6db573c..f197af50def6 100644 > > > --- a/kernel/crash_core.c > > > +++ b/

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-12 Thread David Hildenbrand
On 05.05.22 20:45, Eric DeVolder wrote: > CPU and memory change notifications are received in order to > regenerate the elfcorehdr. > > To support cpu hotplug, a callback is registered to capture the > CPUHP_AP_ONLINE_DYN online and offline events via > cpuhp_setup_state_nocalls(). > > To support

Re: [PATCH v8 3/7] crash: add generic infrastructure for crash hotplug support

2022-05-12 Thread Eric DeVolder
David, Great questions! See inline responses below. eric On 5/12/22 03:52, David Hildenbrand wrote: On 05.05.22 20:45, Eric DeVolder wrote: CPU and memory change notifications are received in order to regenerate the elfcorehdr. To support cpu hotplug, a callback is registered to capture the CP