Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-12 Thread H. Peter Anvin
On June 12, 2024 4:06:07 PM PDT, Andrew Cooper wrote: >On 12/06/2024 10:22 am, Kirill A. Shutemov wrote: >> On Tue, Jun 11, 2024 at 11:26:17AM -0700, H. Peter Anvin wrote: >>> On 6/4/24 08:21, Kirill A. Shutemov wrote: From b45fe48092abad2612c2bafbb199e4de80c99545 Mon Sep 17 00:00:00 2001 >

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-12 Thread Andrew Cooper
On 12/06/2024 10:22 am, Kirill A. Shutemov wrote: > On Tue, Jun 11, 2024 at 11:26:17AM -0700, H. Peter Anvin wrote: >> On 6/4/24 08:21, Kirill A. Shutemov wrote: >>> From b45fe48092abad2612c2bafbb199e4de80c99545 Mon Sep 17 00:00:00 2001 >>> From: "Kirill A. Shutemov" >>> Date: Fri, 10 Feb 2023 12

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-12 Thread Nikolay Borisov
On 3.06.24 г. 17:43 ч., H. Peter Anvin wrote: On 5/29/24 03:47, Nikolay Borisov wrote: diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S index 56cab1bb25f5..085eef5c3904 100644 --- a/arch/x86/kernel/relocate_kernel_64.S +++ b/arch/x86/kernel/relocate_

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-12 Thread Kirill A. Shutemov
On Tue, Jun 11, 2024 at 11:26:17AM -0700, H. Peter Anvin wrote: > On 6/4/24 08:21, Kirill A. Shutemov wrote: > > > > From b45fe48092abad2612c2bafbb199e4de80c99545 Mon Sep 17 00:00:00 2001 > > From: "Kirill A. Shutemov" > > Date: Fri, 10 Feb 2023 12:53:11 +0300 > > Subject: [PATCHv11.1 06/19] x86

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-11 Thread H. Peter Anvin
On 6/4/24 08:21, Kirill A. Shutemov wrote: From b45fe48092abad2612c2bafbb199e4de80c99545 Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" Date: Fri, 10 Feb 2023 12:53:11 +0300 Subject: [PATCHv11.1 06/19] x86/kexec: Keep CR4.MCE set during kexec for TDX guest TDX guests run with MCA enable

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-04 Thread Borislav Petkov
On Tue, Jun 04, 2024 at 06:21:27PM +0300, Kirill A. Shutemov wrote: > What about this? Yeah, LGTM. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-04 Thread Kirill A. Shutemov
On Tue, Jun 04, 2024 at 11:15:03AM +0200, Borislav Petkov wrote: > On Mon, Jun 03, 2024 at 05:24:00PM -0700, H. Peter Anvin wrote: > > Trying one more time; sorry (again) if someone receives this in duplicate. > > > > > > > > > > > > diff --git a/arch/x86/kernel/relocate_kernel_64.S > > > > > b/

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-04 Thread Borislav Petkov
On Mon, Jun 03, 2024 at 05:24:00PM -0700, H. Peter Anvin wrote: > Trying one more time; sorry (again) if someone receives this in duplicate. > > > > > > > > > diff --git a/arch/x86/kernel/relocate_kernel_64.S > > > > b/arch/x86/kernel/relocate_kernel_64.S > > > > index 56cab1bb25f5..085eef5c3904

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-03 Thread H. Peter Anvin
Trying one more time; sorry (again) if someone receives this in duplicate. diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S index 56cab1bb25f5..085eef5c3904 100644 --- a/arch/x86/kernel/relocate_kernel_64.S +++ b/arch/x86/kernel/relocate_kernel_64.S @@ -

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-03 Thread H. Peter Anvin
On 5/29/24 03:47, Nikolay Borisov wrote: diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S index 56cab1bb25f5..085eef5c3904 100644 --- a/arch/x86/kernel/relocate_kernel_64.S +++ b/arch/x86/kernel/relocate_kernel_64.S @@ -148,9 +148,10 @@ SYM_CODE_START_LO

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-06-03 Thread H. Peter Anvin
On 5/29/24 03:47, Nikolay Borisov wrote: diff --git a/arch/x86/kernel/relocate_kernel_64.S b/arch/x86/kernel/relocate_kernel_64.S index 56cab1bb25f5..085eef5c3904 100644 --- a/arch/x86/kernel/relocate_kernel_64.S +++ b/arch/x86/kernel/relocate_kernel_64.S @@ -148,9 +148,10 @@ SYM_CODE_START_LO

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-05-29 Thread Borislav Petkov
On Wed, May 29, 2024 at 01:33:35PM +0100, Andrew Cooper wrote: > Seems I've gained a reputation... Yes you have. You have this weird interest in very deep uarch details that I can't share. Not at that detail. :-P > jmp 1f dates back to ye olde 8086, which started the whole trend of the > instruct

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-05-29 Thread Andrew Cooper
On 29/05/2024 12:28 pm, Borislav Petkov wrote: > On Wed, May 29, 2024 at 02:17:29PM +0300, Kirill A. Shutemov wrote: >>> That jmp 1f becomes redundant now as it simply jumps 1 line below. >>> >> Nothing changed wrt this jump. It dates back to initial kexec >> implementation. >> >> See 5234f5eb04ab

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-05-29 Thread Borislav Petkov
On Wed, May 29, 2024 at 02:17:29PM +0300, Kirill A. Shutemov wrote: > > That jmp 1f becomes redundant now as it simply jumps 1 line below. > > > > Nothing changed wrt this jump. It dates back to initial kexec > implementation. > > See 5234f5eb04ab ("[PATCH] kexec: x86_64 kexec implementation").

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-05-29 Thread Kirill A. Shutemov
On Wed, May 29, 2024 at 01:47:50PM +0300, Nikolay Borisov wrote: > > > On 28.05.24 г. 12:55 ч., Kirill A. Shutemov wrote: > > From: Borislav Petkov > > > > That identity_mapped() functions was loving that "1" label to the point > > of completely confusing its readers. > > > > Use named labels

Re: [PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-05-29 Thread Nikolay Borisov
On 28.05.24 г. 12:55 ч., Kirill A. Shutemov wrote: From: Borislav Petkov That identity_mapped() functions was loving that "1" label to the point of completely confusing its readers. Use named labels in each place for clarity. No functional changes. Signed-off-by: Borislav Petkov (AMD) Si

[PATCHv11 05/19] x86/relocate_kernel: Use named labels for less confusion

2024-05-28 Thread Kirill A. Shutemov
From: Borislav Petkov That identity_mapped() functions was loving that "1" label to the point of completely confusing its readers. Use named labels in each place for clarity. No functional changes. Signed-off-by: Borislav Petkov (AMD) Signed-off-by: Kirill A. Shutemov --- arch/x86/kernel/re