Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-02-13 Thread Pingfan Liu
Gently ping, maintainers, could you share your opinions? Thanks On Thu, Jan 27, 2022 at 5:02 PM Pingfan Liu wrote: > > The following identical code piece appears in both > migrate_to_reboot_cpu() and smp_shutdown_nonboot_cpus(): > > if (!cpu_online(primary_cpu)) >

Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-02-09 Thread Baoquan He
On 02/09/22 at 03:31pm, Pingfan Liu wrote: > On Tue, Feb 08, 2022 at 05:33:52PM +0800, Baoquan He wrote: > > On 01/28/22 at 03:41pm, Pingfan Liu wrote: > > > On Thu, Jan 27, 2022 at 05:41:44PM +0800, Baoquan He wrote: > > > Hi Baoquan, > > > > > > Thanks for reviewing, please see comment inlined

Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-02-08 Thread Pingfan Liu
On Tue, Feb 08, 2022 at 05:33:52PM +0800, Baoquan He wrote: > On 01/28/22 at 03:41pm, Pingfan Liu wrote: > > On Thu, Jan 27, 2022 at 05:41:44PM +0800, Baoquan He wrote: > > Hi Baoquan, > > > > Thanks for reviewing, please see comment inlined > > > Hi Pingfan, > > > > > > On 01/27/22 at 05:02pm,

Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-02-08 Thread Baoquan He
On 01/28/22 at 03:41pm, Pingfan Liu wrote: > On Thu, Jan 27, 2022 at 05:41:44PM +0800, Baoquan He wrote: > Hi Baoquan, > > Thanks for reviewing, please see comment inlined > > Hi Pingfan, > > > > On 01/27/22 at 05:02pm, Pingfan Liu wrote: > > > The following identical code piece appears in both

Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Pingfan Liu
On Thu, Jan 27, 2022 at 05:41:44PM +0800, Baoquan He wrote: Hi Baoquan, Thanks for reviewing, please see comment inlined > Hi Pingfan, > > On 01/27/22 at 05:02pm, Pingfan Liu wrote: > > The following identical code piece appears in both > > migrate_to_reboot_cpu() and

Re: [PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Baoquan He
Hi Pingfan, On 01/27/22 at 05:02pm, Pingfan Liu wrote: > The following identical code piece appears in both > migrate_to_reboot_cpu() and smp_shutdown_nonboot_cpus(): > > if (!cpu_online(primary_cpu)) > primary_cpu = cpumask_first(cpu_online_mask); > > This is due to a

[PATCHv2] kexec: disable cpu hotplug until the rebooting cpu is stable

2022-01-27 Thread Pingfan Liu
The following identical code piece appears in both migrate_to_reboot_cpu() and smp_shutdown_nonboot_cpus(): if (!cpu_online(primary_cpu)) primary_cpu = cpumask_first(cpu_online_mask); This is due to a breakage like the following: migrate_to_reboot_cpu();