Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-21 Thread Luis R. Rodriguez
On Thu, Jan 21, 2016 at 4:05 AM, Mimi Zohar wrote: > On Wed, 2016-01-20 at 15:56 -0800, Luis R. Rodriguez wrote: >> On Wed, Jan 20, 2016 at 3:39 PM, Luis R. Rodriguez wrote: > >> >> @@ -350,13 +321,18 @@ static int fw_get_filesystem_firmware(struct device >> >> *device, >> >> file

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-21 Thread Mimi Zohar
On Wed, 2016-01-20 at 15:56 -0800, Luis R. Rodriguez wrote: > On Wed, Jan 20, 2016 at 3:39 PM, Luis R. Rodriguez wrote: > >> @@ -350,13 +321,18 @@ static int fw_get_filesystem_firmware(struct device > >> *device, > >> file = filp_open(path, O_RDONLY, 0); > >> if (IS_E

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-21 Thread Mimi Zohar
On Tue, 2016-01-19 at 16:10 -0800, Kees Cook wrote: > On Mon, Jan 18, 2016 at 7:11 AM, Mimi Zohar wrote: > > Replace fw_read_file_contents() for reading a file with the common VFS > > kernel_read_file() function. A benefit of calling kernel_read_file() > > to read the firmware is the firmware is

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-20 Thread Luis R. Rodriguez
On Wed, Jan 20, 2016 at 3:39 PM, Luis R. Rodriguez wrote: > On Mon, Jan 18, 2016 at 10:11:22AM -0500, Mimi Zohar wrote: >> Replace fw_read_file_contents() for reading a file with the common VFS >> kernel_read_file() function. A benefit of calling kernel_read_file() >> to read the firmware is the

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-20 Thread Luis R. Rodriguez
On Mon, Jan 18, 2016 at 10:11:22AM -0500, Mimi Zohar wrote: > Replace fw_read_file_contents() for reading a file with the common VFS > kernel_read_file() function. A benefit of calling kernel_read_file() > to read the firmware is the firmware is read only once, instead of once > for measuring/appr

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-19 Thread Kees Cook
On Mon, Jan 18, 2016 at 7:11 AM, Mimi Zohar wrote: > Replace fw_read_file_contents() for reading a file with the common VFS > kernel_read_file() function. A benefit of calling kernel_read_file() > to read the firmware is the firmware is read only once, instead of once > for measuring/appraising t

[RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-18 Thread Mimi Zohar
Replace fw_read_file_contents() for reading a file with the common VFS kernel_read_file() function. A benefit of calling kernel_read_file() to read the firmware is the firmware is read only once, instead of once for measuring/appraising the firmware and again for reading the file contents into mem