Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-03-08 Thread Eric W. Biederman
HATAYAMA Daisuke writes: > From: Fernando Luis Vázquez Cao > Subject: Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in > crash path > Date: Wed, 07 Mar 2012 19:53:16 +0900 > >> On 03/01/2012 08:19 AM, Eric W. Biederman wrote: >> >>> Don

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-03-08 Thread HATAYAMA Daisuke
From: Fernando Luis Vázquez Cao Subject: Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path Date: Wed, 07 Mar 2012 19:53:16 +0900 > On 03/01/2012 08:19 AM, Eric W. Biederman wrote: > >> Don Zickus writes: >>> It probably is, except I never hack

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-03-07 Thread Fernando Luis Vázquez Cao
On 03/08/2012 03:27 AM, Yinghai Lu wrote: 2012/3/7 Vivek Goyal: On Wed, Mar 07, 2012 at 07:53:16PM +0900, Fernando Luis Vázquez Cao wrote: We run into the same NMI problems and wrote some patches that tackle the kernel boot side of things. They have been extensively tested using qemu-kvm and t

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-03-07 Thread Yinghai Lu
2012/3/7 Vivek Goyal : > On Wed, Mar 07, 2012 at 07:53:16PM +0900, Fernando Luis Vázquez Cao wrote: >> On 03/01/2012 08:19 AM, Eric W. Biederman wrote: >> >> >Don Zickus  writes: >> >>It probably is, except I never hacked on idt code before and my assembly >> >>isn't that good.  I have been trying

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-03-07 Thread Vivek Goyal
On Wed, Mar 07, 2012 at 07:53:16PM +0900, Fernando Luis Vázquez Cao wrote: > On 03/01/2012 08:19 AM, Eric W. Biederman wrote: > > >Don Zickus writes: > >>It probably is, except I never hacked on idt code before and my assembly > >>isn't that good. I have been trying to find examples to copy from

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-03-07 Thread Fernando Luis Vázquez Cao
On 03/01/2012 08:19 AM, Eric W. Biederman wrote: Don Zickus writes: It probably is, except I never hacked on idt code before and my assembly isn't that good. I have been trying to find examples to copy from to give it a try. So far I was using early_idt_handlers with early_printk to see if I

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-29 Thread Eric W. Biederman
Don Zickus writes: > On Tue, Feb 21, 2012 at 12:01:07AM -0800, Eric W. Biederman wrote: >> Don Zickus writes: >> >> 2> On Fri, Feb 17, 2012 at 07:21:52PM -0800, Eric W. Biederman wrote: >> >> Don Zickus writes: >> >> >> >> > On Fri, Feb 17, 2012 at 04:41:01AM -0800, Eric W. Biederman wrote: >

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-21 Thread Don Zickus
On Tue, Feb 21, 2012 at 12:01:07AM -0800, Eric W. Biederman wrote: > Don Zickus writes: > > 2> On Fri, Feb 17, 2012 at 07:21:52PM -0800, Eric W. Biederman wrote: > >> Don Zickus writes: > >> > >> > On Fri, Feb 17, 2012 at 04:41:01AM -0800, Eric W. Biederman wrote: > >> >> > >> >> The fix with

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-21 Thread Eric W. Biederman
Don Zickus writes: 2> On Fri, Feb 17, 2012 at 07:21:52PM -0800, Eric W. Biederman wrote: >> Don Zickus writes: >> >> > On Fri, Feb 17, 2012 at 04:41:01AM -0800, Eric W. Biederman wrote: >> >> >> >> The fix with a guarantee of no more scope creep is to just disable the >> >> nmi watchdog on the

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-20 Thread Don Zickus
On Mon, Feb 20, 2012 at 02:17:33PM +0900, HATAYAMA Daisuke wrote: > From: Don Zickus > Subject: Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in > crash path > Date: Fri, 17 Feb 2012 15:18:42 -0500 > > > On Sat, Feb 18, 2012 at 12:49:16AM +0900, HATAYAMA

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-20 Thread Don Zickus
On Fri, Feb 17, 2012 at 07:21:52PM -0800, Eric W. Biederman wrote: > Don Zickus writes: > > > On Fri, Feb 17, 2012 at 04:41:01AM -0800, Eric W. Biederman wrote: > >> > >> The fix with a guarantee of no more scope creep is to just disable the > >> nmi watchdog on the kexec on panic path. > >> >

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-19 Thread HATAYAMA Daisuke
From: Don Zickus Subject: Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path Date: Fri, 17 Feb 2012 15:18:42 -0500 > On Sat, Feb 18, 2012 at 12:49:16AM +0900, HATAYAMA Daisuke wrote: >> A few days ago I investigted the case where system is reseted due to

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-17 Thread Eric W. Biederman
Don Zickus writes: > On Fri, Feb 17, 2012 at 04:41:01AM -0800, Eric W. Biederman wrote: >> >> The fix with a guarantee of no more scope creep is to just disable the >> nmi watchdog on the kexec on panic path. >> >> Don if you have time please figure out is needed to ignore nmi's and >> possible

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-17 Thread Don Zickus
On Sat, Feb 18, 2012 at 12:49:16AM +0900, HATAYAMA Daisuke wrote: > A few days ago I investigted the case where system is reseted due to > triple fault caused by the NMI after idt is disabled in > machine_kexec. I didn't see the reset when trigering the kdump with > NMI since the NMI is masked unti

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-17 Thread Don Zickus
On Fri, Feb 17, 2012 at 04:41:01AM -0800, Eric W. Biederman wrote: > > The fix with a guarantee of no more scope creep is to just disable the > nmi watchdog on the kexec on panic path. > > Don if you have time please figure out is needed to ignore nmi's and > possible record and/or report them wh

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-17 Thread HATAYAMA Daisuke
2012/2/17 Eric W. Biederman : > ebied...@xmission.com (Eric W. Biederman) writes: > >> Don Zickus writes: >> >>> On Thu, Feb 16, 2012 at 01:53:29PM -0800, Yinghai Lu wrote: On Thu, Feb 16, 2012 at 9:27 AM, Don Zickus wrote: > So I think I figured it out.  I went through and comment

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-17 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Don Zickus writes: > >> On Thu, Feb 16, 2012 at 01:53:29PM -0800, Yinghai Lu wrote: >>> On Thu, Feb 16, 2012 at 9:27 AM, Don Zickus wrote: >>> >>> > So I think I figured it out.  I went through and commented out code in >>> > disable_local_API

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-16 Thread Eric W. Biederman
Don Zickus writes: > On Thu, Feb 16, 2012 at 01:53:29PM -0800, Yinghai Lu wrote: >> On Thu, Feb 16, 2012 at 9:27 AM, Don Zickus wrote: >> >> > So I think I figured it out.  I went through and commented out code in >> > disable_local_APIC until I narrowed it down to the piece of code that >> > n

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-16 Thread Don Zickus
On Thu, Feb 16, 2012 at 01:53:29PM -0800, Yinghai Lu wrote: > On Thu, Feb 16, 2012 at 9:27 AM, Don Zickus wrote: > > > So I think I figured it out.  I went through and commented out code in > > disable_local_APIC until I narrowed it down to the piece of code that > > needs to be disabled for it t

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-16 Thread Yinghai Lu
On Thu, Feb 16, 2012 at 9:27 AM, Don Zickus wrote: > So I think I figured it out.  I went through and commented out code in > disable_local_APIC until I narrowed it down to the piece of code that > needs to be disabled for it to work. > > Surprise, surprise... its LVTPC or perf! :-)  Actually it

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-16 Thread Don Zickus
On Thu, Feb 16, 2012 at 10:43:06AM -0800, Yinghai Lu wrote: > On Wed, Feb 15, 2012 at 6:53 PM, Don Zickus wrote: > > > > For some reason using gzip instead of xz makes things work for me with > > your config. > > > > CONFIG_KERNEL_GZIP=y > > CONFIG_KERNEL_XZ=n > > > > Do you see the same thing? >

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-16 Thread Don Zickus
On Mon, Feb 13, 2012 at 10:16:00AM -0800, Yinghai Lu wrote: > On Mon, Feb 13, 2012 at 8:51 AM, Yinghai Lu wrote: > >> So I suspect we have a bug in our apic initialization somewhere, but > >> apic initialization should happen after printk are enabled.  Or at least > >> after early printks so the r

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-16 Thread Yinghai Lu
On Wed, Feb 15, 2012 at 6:53 PM, Don Zickus wrote: > > For some reason using gzip instead of xz makes things work for me with > your config. > > CONFIG_KERNEL_GZIP=y > CONFIG_KERNEL_XZ=n > > Do you see the same thing? no. with GZIP still get instant reset. Yinghai _

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-15 Thread Don Zickus
On Mon, Feb 13, 2012 at 08:52:19AM -0800, Yinghai Lu wrote: > On Mon, Feb 13, 2012 at 7:28 AM, Don Zickus wrote: > > On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > >> > > >> > v2: removed the disable lapic code too > >> > >> with this commit, kdump is not working anymore on my setup

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Don Zickus
On Mon, Feb 13, 2012 at 05:12:58PM -0500, Don Zickus wrote: > On Mon, Feb 13, 2012 at 08:52:19AM -0800, Yinghai Lu wrote: > > On Mon, Feb 13, 2012 at 7:28 AM, Don Zickus wrote: > > > On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > > >> > > > >> > v2: removed the disable lapic code to

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Don Zickus
On Mon, Feb 13, 2012 at 08:52:19AM -0800, Yinghai Lu wrote: > On Mon, Feb 13, 2012 at 7:28 AM, Don Zickus wrote: > > On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > >> > > >> > v2: removed the disable lapic code too > >> > >> with this commit, kdump is not working anymore on my setup

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Yinghai Lu
On Mon, Feb 13, 2012 at 8:51 AM, Yinghai Lu wrote: >> So I suspect we have a bug in our apic initialization somewhere, but >> apic initialization should happen after printk are enabled.  Or at least >> after early printks so the reset YH is reporting doesn't make much sense. > > will try Don's fir

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Yinghai Lu
On Mon, Feb 13, 2012 at 4:52 AM, Eric W. Biederman wrote: > Yinghai Lu writes: > >> On Sat, Feb 11, 2012 at 7:13 PM, Eric W. Biederman >> wrote: >>> Yinghai Lu writes: After reverting this commit, kdump is working again. So assume you need to drop this patch. >>> >>> It sounds li

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Don Zickus
On Sat, Feb 11, 2012 at 05:04:15PM -0800, Yinghai Lu wrote: > > > > v2: removed the disable lapic code too > > with this commit, kdump is not working anymore on my setups with > Nehalem, Westmere, sandbridge. > these setup all have VT-d enabled. Hi Yinghai, Thanks for the report. Can you attach

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-13 Thread Eric W. Biederman
Yinghai Lu writes: > On Sat, Feb 11, 2012 at 7:13 PM, Eric W. Biederman > wrote: >> Yinghai Lu writes: >>> After reverting this commit, kdump is working again. >>> >>> So assume you need to drop this patch. >> >> It sounds like there is a bug in ioapic initialization in the context of >> VT-d.

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-12 Thread Ingo Molnar
* Yinghai Lu wrote: > On Sat, Feb 11, 2012 at 3:09 PM, tip-bot for Don Zickus > wrote: > > Commit-ID:  d9bc9be89629445758670220787683e37c93f6c1 > > Gitweb:     > > http://git.kernel.org/tip/d9bc9be89629445758670220787683e37c93f6c1 > > Author:     Don Zickus > > AuthorDate: Thu, 9 Feb 2012 16:

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-11 Thread Yinghai Lu
On Sat, Feb 11, 2012 at 7:13 PM, Eric W. Biederman wrote: > Yinghai Lu writes: >> After reverting this commit, kdump is working again. >> >> So assume you need to drop this patch. > > It sounds like there is a bug in ioapic initialization in the context of > VT-d.  Where do you fail? > before get

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-11 Thread Eric W. Biederman
Yinghai Lu writes: > On Sat, Feb 11, 2012 at 3:09 PM, tip-bot for Don Zickus > wrote: >> Commit-ID:  d9bc9be89629445758670220787683e37c93f6c1 >> Gitweb:     >> http://git.kernel.org/tip/d9bc9be89629445758670220787683e37c93f6c1 >> Author:     Don Zickus >> AuthorDate: Thu, 9 Feb 2012 16:53:41 -

Re: [tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-11 Thread Yinghai Lu
On Sat, Feb 11, 2012 at 3:09 PM, tip-bot for Don Zickus wrote: > Commit-ID:  d9bc9be89629445758670220787683e37c93f6c1 > Gitweb:     http://git.kernel.org/tip/d9bc9be89629445758670220787683e37c93f6c1 > Author:     Don Zickus > AuthorDate: Thu, 9 Feb 2012 16:53:41 -0500 > Committer:  Ingo Molnar >

[tip:x86/debug] x86/kdump: No need to disable ioapic/ lapic in crash path

2012-02-11 Thread tip-bot for Don Zickus
Commit-ID: d9bc9be89629445758670220787683e37c93f6c1 Gitweb: http://git.kernel.org/tip/d9bc9be89629445758670220787683e37c93f6c1 Author: Don Zickus AuthorDate: Thu, 9 Feb 2012 16:53:41 -0500 Committer: Ingo Molnar CommitDate: Sat, 11 Feb 2012 15:38:53 +0100 x86/kdump: No need to disable