Re: Implementing .shutdown method for efa module

2024-04-24 Thread Tao Liu
Hi Jason & Michael, Kindly ping... Any progress for the efa .shutdown implementing? Thanks in advance! Thanks, Tao Liu On Wed, Apr 3, 2024 at 11:44 PM Jason Gunthorpe wrote: > > On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote: > > Jason > > > > Thanks for your response, efa_r

Re: Implementing .shutdown method for efa module

2024-04-03 Thread Margolin, Michael
Thanks, I'll send a patch. Michael On 4/3/2024 6:44 PM, Jason Gunthorpe wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Apr 01, 2024 at 04:23:32PM +0300,

Re: Implementing .shutdown method for efa module

2024-04-03 Thread Jason Gunthorpe
On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote: > Jason > > Thanks for your response, efa_remove() is performing reset to the device > which should stop all DMA from the device. > > Except skipping cleanups that are unnecessary for shutdown flow are there > any other reasons to

Re: Implementing .shutdown method for efa module

2024-04-01 Thread Margolin, Michael
Jason Thanks for your response, efa_remove() is performing reset to the device which should stop all DMA from the device. Except skipping cleanups that are unnecessary for shutdown flow are there any other reasons to prefer a separate function for shutdown? Michael On 3/26/2024 5:32 PM, J

Re: Implementing .shutdown method for efa module

2024-03-29 Thread Tao Liu
Hi Michael, Sorry for the late reply. We spent some time to reproduce the issue on the upstream kernel 6.9.0-rc1. I added our QE(libhe and xiliang) in the CC list, who helped perform the test using their testing program. On Tue, Mar 26, 2024 at 8:35 PM Margolin, Michael wrote: > > Hi Tao, > > Th

Re: Implementing .shutdown method for efa module

2024-03-26 Thread Jason Gunthorpe
On Tue, Mar 26, 2024 at 02:34:45PM +0200, Margolin, Michael wrote: > Hi Tao, > > Thanks for bringing this up. > > I've unsuccessfully tried to reproduce this kernel panic using production > Red Hat 9.3 AMI (5.14.0-362.18.1.el9_3.aarch64). > > Are there any related changes in the kernel you are t

Re: Implementing .shutdown method for efa module

2024-03-26 Thread Margolin, Michael
Hi Tao, Thanks for bringing this up. I've unsuccessfully tried to reproduce this kernel panic using production Red Hat 9.3 AMI (5.14.0-362.18.1.el9_3.aarch64). Are there any related changes in the kernel you are testing? Anyways we do need to handle shutdown properly, please let know if cal

Re: Implementing .shutdown method for efa module

2024-03-25 Thread Tao Liu
Hi Gal, On Mon, Mar 25, 2024 at 4:06 PM Gal Pressman wrote: > > On 25/03/2024 4:10, Tao Liu wrote: > > Hi, > > > > Recently I experienced a kernel panic which is related to efa module > > when testing kexec -l && kexec -e to switch to a new kernel on AWS > > i4g.16xlarge instance. > > > > Here is

Re: Implementing .shutdown method for efa module

2024-03-25 Thread Gal Pressman
On 25/03/2024 4:10, Tao Liu wrote: > Hi, > > Recently I experienced a kernel panic which is related to efa module > when testing kexec -l && kexec -e to switch to a new kernel on AWS > i4g.16xlarge instance. > > Here is the dmesg log: > > [6.379918] systemd[1]: Mounting FUSE Control File Sys

Implementing .shutdown method for efa module

2024-03-24 Thread Tao Liu
Hi, Recently I experienced a kernel panic which is related to efa module when testing kexec -l && kexec -e to switch to a new kernel on AWS i4g.16xlarge instance. Here is the dmesg log: [6.379918] systemd[1]: Mounting FUSE Control File System... [6.381984] systemd[1]: Mounting Kernel Con