Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Mark Roszko
As a FYI, Coverity has generated defects related to the new features that seem like they can generate unexpected behavior from what I see: #106428 (variable not initialized, considered high impact) #106367 (null dereference) #106366 (logically dead code) there's a bunch of other defects but

[Kicad-developers] [PATCH] Get rid of unused variable warning.

2015-03-05 Thread Simon Richter
--- pcbnew/router/pns_diff_pair.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pcbnew/router/pns_diff_pair.cpp b/pcbnew/router/pns_diff_pair.cpp index 2af6f3e..c08af7c 100644 --- a/pcbnew/router/pns_diff_pair.cpp +++ b/pcbnew/router/pns_diff_pair.cpp @@ -623,9 +623,8

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Mark Roszko
FYI, while compiling 5481 for a coverity scan In file included from /home/mroszko/kicad/include/geometry/shape.h:28:0, from /home/mroszko/kicad/pcbnew/router/pns_diff_pair.cpp:27: /home/mroszko/kicad/include/math/vector2d.h: In member function ‘void

Re: [Kicad-developers] Assembly Variant Management Feature

2015-03-05 Thread Nick Østergaard
2015-03-05 10:07 GMT+01:00 LordBlick lordbl...@gmail.com: In response to a message written on 02.03.2015, 23:10, from Murat Ursavaş: Hi, I'm new to KiCad development and have some ideas to include into the package. The most important one is Assembly Variant Management, which is missing,

Re: [Kicad-developers] Assembly Variant Management Feature

2015-03-05 Thread LordBlick
In response to a message written on 02.03.2015, 23:10, from Murat Ursavaş: Hi, I'm new to KiCad development and have some ideas to include into the package. The most important one is Assembly Variant Management, which is missing, AFAIK. Am I right? Is there anybody working on this subject?

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread LordBlick
In response to a message written on 03.03.2015, 20:22, from Tomasz Wlostowski: The pads of the top/bottom connector on your PCB don't have the same X coordinates (for the top connector X = 148,5011 mm, for the bottom connector X = 148,5 mm). In my opinion (if I understand idea) in some

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Brian Sidebotham
On 3 March 2015 at 13:44, Tomasz Wlostowski tomasz.wlostow...@cern.ch wrote: Dear all, We've just merged the new features of the Interactive Router to the product branch: - Routing differential pairs (in pushshove mode too). - Tuning trace length. - Tuning differential pair length and skew.

Re: [Kicad-developers] Default location for Python plug-in scripts on OS X?

2015-03-05 Thread LordBlick
In response to a message written on 03.03.2015, 21:58, from Bernhard Stegmaier: * I didn’t have any idea on how to use scripting… Some example: https://github.com/LordBlick/kicadPanelizer (I'm still working on it - margins spitted to X and Y, fiducials on margins…) ;-) -- Best Regards,

Re: [Kicad-developers] Mac nightlies with Python

2015-03-05 Thread LordBlick
In response to a message written on 04.03.2015, 23:00, from Jean-Paul Louis: Hi Adam, I tried your build, and I can confirm that the scripting console is unusable as is. I tried to type “help”. the h was ok with proper echo, the e started the edit mode. the E seems ok, as it might not be a

Re: [Kicad-developers] Default location for Python plug-in scripts on OS X?

2015-03-05 Thread LordBlick
In response to a message written on 03.03.2015, 20:52, from Nick Østergaard: On linux it is in $HOME/.kicad_plugins/ Some Wish: It should be configurable with cmake prompt (-DUSER_PLUGINS_SUBPATH) as default and additionally, the user should be allowed to manually set a different path - KiCAD

Re: [Kicad-developers] Default location for Python plug-in scripts on OS X?

2015-03-05 Thread Bernhard Stegmaier
I saved that link some while back and that is exactly why for sure I will try/use scripting somewhen... :) Regards, Bernhard On 2015-03-05 10:30, LordBlick wrote: In response to a message written on 03.03.2015, 21:58, from Bernhard Stegmaier: * I didn’t have any idea on how to use

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Tomasz Wlostowski
On 05.03.2015 10:20, LordBlick wrote: In response to a message written on 03.03.2015, 20:22, from Tomasz Wlostowski: The pads of the top/bottom connector on your PCB don't have the same X coordinates (for the top connector X = 148,5011 mm, for the bottom connector X = 148,5 mm). In my

Re: [Kicad-developers] [PATCH 5/5] Add virtual keyword to implicitly virtual functions

2015-03-05 Thread Mark Roszko
I really don't agree with this patch with marking all the subclasses as virtual just because if the base class parameters ever change for a method the subclasses end up making entirely new functions. And you won't get any errors because it'll just call the base method no problem. If we did C++11

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Simon Richter
Hi, On 06.03.2015 02:53, Mark Roszko wrote: /home/mroszko/kicad/include/math/vector2d.h:412:54: warning: ‘*((void*)( m)+4).VECTOR2int::y’ may be used uninitialized in this function [-Wmaybe-uninitialized] return VECTOR2T ( x - aVector.x, y - aVector.y ); That is an interesting warning

Re: [Kicad-developers] Coverity scan.

2015-03-05 Thread Mark Roszko
Well submitting builds is slightly broken while I wait on coverity to respond to my emails. But as a warning, Coverity has let some of their SSL certificates expire and you may have to whitelist their certificates to View Defects depending on which server it decides to send the request to. It

Re: [Kicad-developers] Assembly Variant Management Feature

2015-03-05 Thread Murat Ursavaş
Actually, developing it as a plug-in looks like a better idea, since the KiCad codebase is really huge and not easy to get in the first sight. I'm not sure about the plugin manager, though. I guess my experience with KiCad won't be enough for that :) On 05-03-2015 11:13, Nick Østergaard

[Kicad-developers] [PATCH 1/5] Indentation cleanup

2015-03-05 Thread Simon Richter
This replaces a few tabs with four spaces. No code changes. --- common/dialogs/dialog_page_settings.h | 2 +- cvpcb/dialogs/dialog_config_equfiles.h | 2 +- cvpcb/dialogs/fp_conflict_assignment_selector.h | 8

[Kicad-developers] [PATCH 3/5] Make Show() dependent on DEBUG preprocessor symbol

2015-03-05 Thread Simon Richter
This function is only used for builds with -DDEBUG, so hide it in derived classes as well. --- include/worksheet_viewitem.h| 2 ++ pcbnew/ratsnest_viewitem.h | 2 ++ pcbnew/router/router_preview_item.h | 2 ++ pcbnew/tools/bright_box.h | 2 ++ pcbnew/tools/edit_points.h

[Kicad-developers] [PATCH 0/5] Cleanup patches

2015-03-05 Thread Simon Richter
Hi, this is a bunch of low priority patches, because these do not change anything really. - #1-3 are straightforward and probably make sense to apply - #4 could make sense, but is not required on currently supported platforms because these happen to do the right thing anyway. - #5 is

[Kicad-developers] [PATCH 2/5] Implement GetClass() throughout the project

2015-03-05 Thread Simon Richter
This function is really only used for diagnostics. --- 3d-viewer/3d_material.h | 8 3d-viewer/3d_struct.h | 8 include/base_struct.h | 5 + include/worksheet_viewitem.h | 8

[Kicad-developers] [PATCH 4/5] Use platform safe storage for pin numbers

2015-03-05 Thread Simon Richter
The uint32_t type has exactly 32 bits, while the definition of long is up to the compiler (although it happens to be 32 bits almost everywhere). --- eeschema/lib_pin.cpp | 4 ++-- eeschema/lib_pin.h | 7 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/eeschema/lib_pin.cpp