Re: [Kicad-developers] [PATCH] Set dash lines parameters in one place for plot

2015-03-09 Thread jp charras
Le 09/03/2015 15:36, Eldar Khayrullin a écrit : I deleted Magic numbers that set parameters of dash lines. Use constants in mils. Then apply radius correction and scale to plot units when start to plotting. Make for PDF, PS, SVG plotters. And some minor fixes. * Английский - определен *

Re: [Kicad-developers] [PATCH] Set dash lines parameters in one place for plot

2015-03-09 Thread Eldar Khayrullin
Add check to negative values of mark length. Use GetCurrentLineWidth() instead of currentPenWidth. 09.03.2015 19:06, jp charras пишет: Le 09/03/2015 16:29, Eldar Khayrullin a écrit : It is possible? May be you mean that need check this condition? 09.03.2015 18:19, jp charras пишет: Le

Re: [Kicad-developers] [PATCH] Set dash lines parameters in one place for plot

2015-03-09 Thread Eldar Khayrullin
It is possible? May be you mean that need check this condition? 09.03.2015 18:19, jp charras пишет: Le 09/03/2015 15:36, Eldar Khayrullin a écrit : I deleted Magic numbers that set parameters of dash lines. Use constants in mils. Then apply radius correction and scale to plot units when start

[Kicad-developers] [PATCH] Set dash lines parameters in one place for plot

2015-03-09 Thread Eldar Khayrullin
I deleted Magic numbers that set parameters of dash lines. Use constants in mils. Then apply radius correction and scale to plot units when start to plotting. Make for PDF, PS, SVG plotters. And some minor fixes. * Английский - определен * Русский * Русский javascript:void(0); ===

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Maciej Sumiński
On 03/09/2015 06:50 PM, Mark Roszko wrote: A+++ Always hated the environment variables because your typical electrical engineer/non power user would not know wtf they are. Anyone developing kicad is already above average. File extension idea is good too. I suggest keeping the separate file

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Carl Poirier
On Mon, Mar 9, 2015 at 2:06 PM, Maciej Sumiński maciej.sumin...@cern.ch wrote: Hi Carl, The dialog would be common for both ways. If the user chooses local files option, then a file browser appears and then as the last step - the summary dialog. Regards, Orson That's not what I want to

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Maciej Sumiński
Hi Carl, The dialog would be common for both ways. If the user chooses local files option, then a file browser appears and then as the last step - the summary dialog. Regards, Orson On 03/09/2015 06:50 PM, Carl Poirier wrote: Hi Orson, It looks great, but I have one comment. I think there

[Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Maciej Sumiński
As we are inevitably approaching the feature freeze, I would like to know your opinion about one last change to the footprint library wizard. We would like to make the library management as simple as possible. Therefore Tom has prepared an alternative set of dialog windows for the footprint

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Carl Poirier
Hi Orson, It looks great, but I have one comment. I think there should be one template for both the table in Review and confirm the changes to the libraries and the fp-lib-table presented in the parent dialog. My 2¢. Carl On Mon, Mar 9, 2015 at 1:23 PM, Maciej Sumiński maciej.sumin...@cern.ch

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Mark Roszko
A+++ Always hated the environment variables because your typical electrical engineer/non power user would not know wtf they are. Anyone developing kicad is already above average. File extension idea is good too. I suggest keeping the separate file filters in addition to an all filter if you go

[Kicad-developers] fix proposal for the 3D shading issues.

2015-03-09 Thread Mário Luzeiro
Hello kicad developers! I submitted a patch to fix the current shading issues with some models. https://bugs.launchpad.net/kicad/+bug/1351618 https://bugs.launchpad.net/kicad/+bug/1351618/+attachment/4339230/+files/3d-viewer-shadding-improovements_issue1351618.patch This patch added an options

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Mark Roszko
The concern is that if you select from KiCad github and its say the official Kicad group, then that's alot of libraries to download and install. Nothing wrong with doing that but perhaps instead just the Next should be disabled until at least one library is selected.

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread tiger12506
Just one minor detail, I would probably choose to have all selected as the default. Users don't like to read, and the less action they have to take, the happier they will be. Otherwise, you might have a lot of users with an empty table.

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Nick Østergaard
2015-03-09 19:34 GMT+01:00 Wayne Stambaugh stambau...@gmail.com: On 3/9/2015 1:23 PM, Maciej Sumiński wrote: As we are inevitably approaching the feature freeze, I would like to know your opinion about one last change to the footprint library wizard. Your proposal looks reasonable to me. I

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Wayne Stambaugh
On 3/9/2015 2:59 PM, Nick Østergaard wrote: 2015-03-09 19:34 GMT+01:00 Wayne Stambaugh stambau...@gmail.com: On 3/9/2015 1:23 PM, Maciej Sumiński wrote: As we are inevitably approaching the feature freeze, I would like to know your opinion about one last change to the footprint library

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Wayne Stambaugh
On 3/9/2015 1:23 PM, Maciej Sumiński wrote: As we are inevitably approaching the feature freeze, I would like to know your opinion about one last change to the footprint library wizard. Your proposal looks reasonable to me. I have one comment nn the first image. The string at the bottom

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Mark Roszko
Be very careful with relative paths on windows and in general. There should be a test to make sure the relative paths don't cross drive boundaries on windows. I would argue on Windows that relative paths that cross drive boundaries should be made absolute to that drive automatically. i.e. I may

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Adam Wolf
Mark, github repos can be used without installing. Adam Wolf Cofounder and Engineer WL On Mon, Mar 9, 2015 at 3:07 PM, Mark Roszko mark.ros...@gmail.com wrote: The concern is that if you select from KiCad github and its say the official Kicad group, then that's alot of libraries to download

[Kicad-developers] [PATCH] fix 2x memory leak and misc field warnings in PNS stuff

2015-03-09 Thread Mark Roszko
Fixes 1 leak in pns_line_placer and 1 leak in pns_node. Assorted field intialization. Based on coverity. From 987e65fdcf962f925fc1678b425d13173ae4b3a8 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Mon, 9 Mar 2015 23:21:07 -0400 Subject: [PATCH] Fix memory leak in pns_node

Re: [Kicad-developers] [PATCH] SHAPE_CONVEX for the PNS router

2015-03-09 Thread Tomasz Wlostowski
On 08.03.2015 17:21, Mathias Grimmberger wrote: Hi everybody, below is a patch to add a SHAPE_CONVEX for the PNS router. The patch was generated against revision 5484. Hi Mathias, Many thanks for your patch, I'll get it merged asap. What still needs to be done: - the hull around