Re: [Kicad-developers] [PATCH] Eeschema options step 2: template fields

2015-12-27 Thread Chris Pavlina
On Dec 28, 2015 12:39 AM, "Jon Neal" wrote: > > Just tested this and A++ would apply patches again. You're welcome to try, they should be idempotent :D > > This is so much cleaner than the old options dialog. > > Two small things: > 1. Maybe title the tab "Default Symbol Fields"? It is a little

Re: [Kicad-developers] [PATCH] Eeschema options step 2: template fields

2015-12-27 Thread Jon Neal
Just tested this and A++ would apply patches again. This is so much cleaner than the old options dialog. Two small things: 1. Maybe title the tab "Default Symbol Fields"? It is a little wordy, but other than that there isn't any info on /what/ it is default fields for. 2. Auto-save time interval

Re: [Kicad-developers] [PATCH] Eeschema options step 2: template fields

2015-12-27 Thread Chris Pavlina
Urgh, today seems to be a great day for making mistakes. Take #3, I found a bug. Sorry for the noise. On Sun, Dec 27, 2015 at 03:02:05PM -0500, Chris Pavlina wrote: > Sorry, quick update - fix a couple (non-critical) signed/unsigned > mismatches and remove an unused member. This is a new version

[Kicad-developers] [PATCH] Eeschema options step 2: template fields

2015-12-27 Thread Chris Pavlina
Hi, This patch reimplements the Template/Default Fields page in the Eeschema options using wxGrid, making the table directly user-editable and removing the somewhat dodgy code for the separate edit panel. This fixes as well as, IMO, making this d

[Kicad-developers] [PATCH 2/5] Move comparison helper class to generic header

2015-12-27 Thread Simon Richter
This class wraps the comparison function in a way that is compatible with std::map and std::set. This, too is generally useful, so it should be moved to the generic header. At the same time, the criterium for less-than is changed from "equal to -1" to "smaller than 0", because technically the com

[Kicad-developers] [PATCH 4/5] Add pin number summary

2015-12-27 Thread Simon Richter
Below the pin table, display which pins are currently defined, in order to find gaps. --- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 27 +++ eeschema/dialogs/dialog_lib_edit_pin_table.h | 2 + .../dialogs/dialog_lib_edit_pin_table_base.cpp | 3 + .../dialogs/dialog_lib_e

[Kicad-developers] [PATCH 3/5] Move container functionality

2015-12-27 Thread Simon Richter
The "set of pin numbers" functionality is also useful outside the pin table dialog, so create a wrapper class that exposes the relevant interfaces. --- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 2 +- eeschema/pin_number.h | 21 + 2 files change

[Kicad-developers] [PATCH 1/5] Split off pin number comparison

2015-12-27 Thread Simon Richter
Pin numbers need to be ordered in more places in the future, so fold this out of the pin table dialog into a utility class. --- eeschema/CMakeLists.txt| 1 + eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 112 + eeschema/pin_number.cpp

[Kicad-developers] [PATCH 5/5] Compress consecutive numbers in pin summary.

2015-12-27 Thread Simon Richter
For pin numbers ending in digits, consecutive numbers are collapsed to ranges for a better overview. --- eeschema/pin_number.cpp | 49 +++-- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/eeschema/pin_number.cpp b/eeschema/pin_number.cp

[Kicad-developers] [PATCH 0/5] Pin summary for pin table

2015-12-27 Thread Simon Richter
Hi, this patch set implements a summary line for the pin table, listing the currently defined pins, to quickly check whether any pins have been forgotten. If pins 1,2,3,4,5,6,8,9,10,11,12 are defined, the status bar then reads "1-6,8-12". Simon Simon Richter (5): Split off pin number compa

Re: [Kicad-developers] Developer documentation link down.

2015-12-27 Thread Nick Østergaard
No, completely unrelated. Den 27/12/2015 06.58 skrev "Andy Peters" : > > > On Dec 26, 2015, at 3:37 PM, Wayne Stambaugh > wrote: > > > > I just went to look at the KiCad developer documentation an I'm seeing a > > "Please wait while Jenkins is restarting" message. It's been like that > > all day