Re: [Kicad-developers] [PATCH] Pull eeschema colors into preferences dialog

Merged, since nobody objected - I'd like to get on with the more important preferences work. On Sat, Jan 16, 2016 at 12:54:38AM -0500, Chris Pavlina wrote: > Hi, > > The next installment of my preferences work is simple, I pulled the > color configuration dialog into the eeschema preferences

Re: [Kicad-developers] Grid in GAL canvas

Committed in 6486. Thank you. Apparently the "growing buttons" is an existing bug anyway, not caused by this patch, so I have no problem with this. On Thu, Jan 14, 2016 at 09:03:22PM +0100, Bernhard Stegmaier wrote: > Yes, very nice… :) > > Given that probably after this change guys like me

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

Please do not commit this patch. The current policy is no MSVC specific code in KiCad and I'm not interested in changing that policy any time soon. Thanks, Wayne On 1/15/2016 11:41 PM, Simon Richter wrote: > > Windows-style dllimport/dllexport should be used whenever targetting > Windows

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

You're looking at a totally different patch than this thread is about. You seem to do that a lot, maybe check that your email client is threading correctly? ;) On Sat, Jan 16, 2016 at 03:40:11PM -0500, Wayne Stambaugh wrote: > Huh? > > +// MSVC doesn't have __func__ > +#ifdef _MSC_VER >

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

Hi Wayne, On 16.01.2016 21:40, Wayne Stambaugh wrote: > Huh? > > +// MSVC doesn't have __func__ > +#ifdef _MSC_VER > +#define __func__ __FUNCTION__ > +#endif > + Yes, I wrote yesterday that this patch was included by accident and should be ignored. Simon signature.asc Description:

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

Hmm. From my perspective, I didn't really think it was a policy violation as such, as that is definitely not MSVC-specific. It's just "portable", which is generally a good thing - if we were ever to change the current policy in the future, the more portable the code is, the easier that will

Re: [Kicad-developers] Request/Question

Please search the mailing list. This has been discussed several times and it is currently under consideration. As project leader I will tell that I find it highly dubious that there will be a huge influx of new developers if/when we move to GitHub. This same argument was made when we moved from

Re: [Kicad-developers] Request/Question

Hi, On 16.01.2016 21:32, Wayne Stambaugh wrote: > I believe that if you truly wanted to contribute > to KiCad, you would take a few minutes of time to learn bzr and > launchpad. git-remote-bzr works fine for me. Still haven't learned bzr. Simon signature.asc Description: OpenPGP digital

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

Sorry. I must have replied to the wrong email. I see now that it was the 11/11 patch. On 1/16/2016 3:41 PM, Chris Pavlina wrote: > You're looking at a totally different patch than this thread is about. > You seem to do that a lot, maybe check that your email client is > threading correctly?

[Kicad-developers] Request/Question

Hello, I like the recent progress that’s been made with Kicad! To see so many advanced features in an open-source project is remarkable. I look forward to being able to contribute to the project myself soon! I’ve noticed that Kicad isn’t using Github to host the project, but is instead

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

Huh? +// MSVC doesn't have __func__ +#ifdef _MSC_VER +#define __func__ __FUNCTION__ +#endif + It's been a long time since I've used MSVC but I'm pretty sure that the _MSC_VER is MSVC specific. https://msdn.microsoft.com/en-us/library/b0084kay.aspx On 1/16/2016 3:31 PM, Nick Østergaard wrote: >

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

That patch doesn't seem to add msvc specific code, in fact it seems to just _remove_ MINGW specific code. -#if defined(__MINGW32__) +#if defined(_WIN32) On Sat, Jan 16, 2016 at 1:34 PM, Wayne Stambaugh wrote: > Please do not commit this patch. The current policy is no

Re: [Kicad-developers] Request/Question

At the risk of sounding curt - search the mailing list archive, we've been discussing this for a *long* time, including a thread that was active in just the last couple days. We're looking into moving to git (not necessaily github, but possibly), it's just a large task (and there maay be a

Re: [Kicad-developers] Request/Question

On 1/16/2016 3:54 PM, Simon Richter wrote: > Hi, > > On 16.01.2016 21:32, Wayne Stambaugh wrote: > >> I believe that if you truly wanted to contribute >> to KiCad, you would take a few minutes of time to learn bzr and >> launchpad. > > git-remote-bzr works fine for me. Still haven't learned

Re: [Kicad-developers] Request/Question

Hi Wayne, On 16.01.2016 22:05, Wayne Stambaugh wrote: >> git-remote-bzr works fine for me. Still haven't learned bzr. > How long did it take you to learn how to use this? I'll bet it was not > very long at all was it? Not really -- LP just appears as another remote server to me, and I can

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

I'm pretty sure I've discussed this with Simon before but maybe it was someone else. We removed all of the MSVC foo from KiCad years ago because it just made the code horrid and it was all over the place. Whenever I see a check for MSVC, this says to me that this code is specific to MSVC. Devs

Re: [Kicad-developers] Request/Question

I've set my default pull behaviour to rebase, so I can just leave submitted patches in my master branch -- if any one of them gets merged, the rebase will remove my local commit, and I have an excellent overview of which patches are merged. Simon Oh wow! I didn't know one could do that.

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

Hi Clemens, Clemens Koller writes: > Hi, Mathias! > > On 2016-01-14 20:06, Mathias Grimmberger wrote: > > In the current drawing code in some places we build polygons > > approximating the corner quarter circles, e.g. using 8 segments. For a > > very small radius there will be segments of zero