Re: [Kicad-developers] [PATCH] Enable C++11

2016-04-05 Thread Simon Richter
Hi, On 06.04.2016 05:19, Simon Richter wrote: > This enables C++11 support, if either CMake is sufficiently new to have > this feature built in, or the compiler is supported by the workaround code > (gcc or clang). Meh, that patch was still in the temp dir where I stage mails before sending. As

[Kicad-developers] [PATCH] Drop dependency on

2016-04-05 Thread Simon Richter
This appears to be unused. --- include/plugins/3dapi/xv3d_types.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/plugins/3dapi/xv3d_types.h b/include/plugins/3dapi/xv3d_types.h index 630d057..43222d6 100644 --- a/include/plugins/3dapi/xv3d_types.h +++

[Kicad-developers] [PATCH] Enable C++11

2016-04-05 Thread Simon Richter
This enables C++11 support, if either CMake is sufficiently new to have this feature built in, or the compiler is supported by the workaround code (gcc or clang). --- CMakeLists.txt | 23 +++ 1 file changed, 23 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index

[Kicad-developers] [PATCH] Drop dependency on mm_malloc.h

2016-04-05 Thread Simon Richter
Hi, apparently, the only mention of the string "mm_malloc" in the entire codebase is this include, so there should be no ill effects from dropping it. Simon Simon Richter (1): Drop dependency on include/plugins/3dapi/xv3d_types.h | 1 - 1 file changed, 1 deletion(-) -- 2.1.4

[Kicad-developers] RFC: out-of-tree plugin builds

2016-04-05 Thread Cirilo Bernardo
With the recent merge of the 3D plugin work we must now address some new issues which have come about due to the introduction of plugins and a shared library (kicad_3dsg). In particular, users who wish to create out-of-tree plugins will now need to find the vital kicad headers and necessary shared

[Kicad-developers] swig/scripting breakage?

2016-04-05 Thread Mark Roszko
So I believe the C++11 enabling broke this but I really haven't had the time to look into it. This is from the server I use purely for coverity builds. Its basically "clean' (no development junk). mroszko@ip-XXX:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu

Re: [Kicad-developers] RES: [PATCH] new feature, value and reference with angle in PCB

2016-04-05 Thread Chris Pavlina
Okay, I like this a lot more now. I'm going to run my own build with this patch for a little while to make sure nothing else comes up. If not, and nobody else minds, I'll accept it. The dialog looks a little bit off to me - there's some extra padding on the right that shouldn't be there by

[Kicad-developers] Jenkins build is back to normal : KiCad (Linux, all options, Debug) #1230

2016-04-05 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] PATCH: fix segfault in python scripting caused by new 3D code

2016-04-05 Thread Chris Pavlina
Committed in rev 6665. Thank you. On Wed, Apr 06, 2016 at 09:10:23AM +1000, Cirilo Bernardo wrote: > The attached patch ensures the S3D_MASTER class does not cause > a segfault in pcbnew when used from Python scripting. > > The issue is due to an "extern KIWAY* TheKiway" which was exposed > to

[Kicad-developers] PATCH: fix segfault in python scripting caused by new 3D code

2016-04-05 Thread Cirilo Bernardo
The attached patch ensures the S3D_MASTER class does not cause a segfault in pcbnew when used from Python scripting. The issue is due to an "extern KIWAY* TheKiway" which was exposed to allow S3D_MASTER to use the new resolver to handle 3D filenames. Unfortunately TheKiway cannot be assigned a

[Kicad-developers] RES: [PATCH] new feature, value and reference with angle in PCB

2016-04-05 Thread Pereira, Patrick
Hello, Some corrections to this path. Best regards. De: Chris Pavlina [pavlina.ch...@gmail.com] Enviado: quinta-feira, 31 de março de 2016 19:03 Para: Pereira, Patrick Cc: kicad-developers@lists.launchpad.net Assunto: Re: [Kicad-developers] [PATCH] new

Re: [Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread jp charras
Hi, Cirilo. I merged your branch in rev 6664. Thanks for all this work. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

[Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1229

2016-04-05 Thread Miguel Angel Ajo
See Changes: [jean-pierre charras] Merge 3d_initial_merge branch -- [...truncated 620 lines...] :73: Warning 509: as it is shadowed

Re: [Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread Eldar Khayrullin
Hello. Look at gcc option "-fsanitize=" too. ![](https://link.nylas.com/open/ac7n0u7eu8cj6vjow9ajimqdr/58d3f403faeb4e22ac36 f827cb89bd7d) > On апр 5 2016, at 2:45 дня, jp charras jp.char...@wanadoo.fr wrote: > > Le 05/04/2016 13:23, Mário Luzeiro a écrit : Hi all, Thanks for the

Re: [Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread jp charras
Le 05/04/2016 13:23, Mário Luzeiro a écrit : > Hi all, > > Thanks for the ccpcheck suggestion JP, that was something I was looking for > some time... > (I found already a bug with that!) > > "There are still quite a few "variable not used" warnings but those > are in code contributed by Mario

Re: [Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread Mário Luzeiro
Hi all, Thanks for the ccpcheck suggestion JP, that was something I was looking for some time... (I found already a bug with that!) "There are still quite a few "variable not used" warnings but those are in code contributed by Mario so I have left them alone for now." I am running this also in

Re: [Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread Cirilo Bernardo
Hi Jean-Pierre, Wayne, I've run cppcheck and fixed a number of issues: 1. ensured "delete [] X" where "delete X" was accidentally used 2. ensured variable initialization 3. fixed a number of errors and warnings reported by cppcheck (most of those warnings were in fact errors) There are still

Re: [Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread Cirilo Bernardo
Thanks Jean-Pierre, Wayne. I'll work on this and report when I've done as requested and cleaned up. - Cirilo On Tue, Apr 5, 2016 at 6:02 PM, jp charras wrote: > Hi, Cirilo. > > We (Wayne and me) are willing to merge your 3d_initial_merge branch. > > It looks good for

[Kicad-developers] Merging 3d_initial_merge branch.

2016-04-05 Thread jp charras
Hi, Cirilo. We (Wayne and me) are willing to merge your 3d_initial_merge branch. It looks good for now, and adds very good features. Could you run cppcheck on you code (the 3d-viewer and others new folders)? (see http://cppcheck.sourceforge.net) cppcheck is fast, very easy to install and use

Re: [Kicad-developers] a few minor issues in code

2016-04-05 Thread jp charras
Le 04/04/2016 22:56, Cirilo Bernardo a écrit : > Hi folks, > > While working on adding a dummy board with footprint to the 3D file > selector preview, > I ran across a few issues: > > 1. in 3d-viewer/3d_aux.cpp L59 - L84 there seems to be a cut/paste problem. > In the "if( m_MatRotation.y )"