Re: [Kicad-developers] [PATCH] Enable C++11

2016-04-06 Thread Chris Pavlina
Patch committed in rev 6635. Thank you. ;) On Wed, Apr 06, 2016 at 05:31:37AM +0200, Simon Richter wrote: > Hi, > > On 06.04.2016 05:19, Simon Richter wrote: > > > This enables C++11 support, if either CMake is sufficiently new to have > > this feature built in, or the compiler is supported

Re: [Kicad-developers] [PATCH] Drop dependency on

2016-04-06 Thread Chris Pavlina
Patch committed in rev 6670. Thank you. On Wed, Apr 06, 2016 at 05:19:44AM +0200, Simon Richter wrote: > > This appears to be unused. > --- > include/plugins/3dapi/xv3d_types.h | 1 - > 1 file changed, 1 deletion(-) > ___ Mailing list:

[Kicad-developers] Jenkins build is back to normal : KiCad (Linux, all options, Debug) #1233

2016-04-06 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] [PATCH 0/2] Two small portability patches

2016-04-06 Thread Chris Pavlina
Patches 1 and 2 pushed in revisions 6668 and 6669. Thank you. On Wed, Apr 06, 2016 at 08:08:09AM +0200, Simon Richter wrote: > Hi, > > these should be fairly obvious: > > - all Windows platforms use declspec(dllexport) > - MSVC does not set a symbol called "MSVC" > - use wxFileName to access

[Kicad-developers] Build failed in Jenkins: KiCad (Linux, all options, Debug) #1232

2016-04-06 Thread Miguel Angel Ajo
See -- Started by an SCM change Building on master in workspace $ bzr revision-info -d info result: bzr revision-info -d

Re: [Kicad-developers] problems in old 3DViewer with new bbox code

2016-04-06 Thread Chris Pavlina
Patch committed in rev 6667. Thank you. On Wed, Apr 06, 2016 at 10:35:22PM +, Mário Luzeiro wrote: > Hi all, > > Attached is a patch that fixes an assert while displaying the 3D shapes > bounding boxes (because of the new merged code) > It also fixes a compile error in my machine because of

Re: [Kicad-developers] PATCH: fix to various 3D issues reported by coverity

2016-04-06 Thread Chris Pavlina
Patch committed in rev . Thank you. On Thu, Apr 07, 2016 at 11:39:07AM +1000, Cirilo Bernardo wrote: > This patch fixes a number of issues reported by the latest coverity scan; > however it does not include a fix for one issue (I have asked Mario to help > fix this remaining one): > > ** CID

[Kicad-developers] PATCH: fix to various 3D issues reported by coverity

2016-04-06 Thread Cirilo Bernardo
This patch fixes a number of issues reported by the latest coverity scan; however it does not include a fix for one issue (I have asked Mario to help fix this remaining one): ** CID 143741: Memory - corruptions (OVERRUN) /3d-viewer/common_ogl/cogl_att_list.cpp: 64 in COGL_ATT_LIST::

[Kicad-developers] problems in old 3DViewer with new bbox code

2016-04-06 Thread Mário Luzeiro
Hi all, Attached is a patch that fixes an assert while displaying the 3D shapes bounding boxes (because of the new merged code) It also fixes a compile error in my machine because of the order of the include wx/glcanvas.h Mario Luzeiro# Bazaar merge directive format 2 (Bazaar 0.90) #

Re: [Kicad-developers] swig/scripting breakage?

2016-04-06 Thread Nick Østergaard
I guess I should also have linked [3]. [3] https://github.com/swig/swig/issues/73 2016-04-06 20:13 GMT+02:00 Nick Østergaard : > It looks like this is an issue with swig 2.0.11. It seems to be fixed > in swig 2.0.12 in [1]. This is further confirmed by a freebsd packager > in

Re: [Kicad-developers] swig/scripting breakage?

2016-04-06 Thread Nick Østergaard
It looks like this is an issue with swig 2.0.11. It seems to be fixed in swig 2.0.12 in [1]. This is further confirmed by a freebsd packager in [2] removing the pathces against 2.0.11 to fix a similar issue. I guess we can ignore this fine as we discussed earlier because 14.04 is very soon EOL or

[Kicad-developers] 3D merge: new warnings

2016-04-06 Thread Simon Richter
Hi, first Jenkins builds after the merge went through, we have a few new warnings. The msys build is rather silent[1]: ogl_legacy_utils.cpp:209 variable 'end' set but not used [-Wunused-but-set-variable] The MSVC build has a few more new warnings[2], sorted by category here: vrml.cpp:185

Re: [Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-04-06 Thread jp charras
Le 06/04/2016 11:59, Tomasz Wlostowski a écrit : > On 04.04.2016 14:15, Maciej Sumiński wrote: >> On 04/04/2016 01:39 PM, jp charras wrote: >>> Sorry if you already sent me a response to this "old" message (first posted >>> on feb 05) >>> but I did not remember this response. > > Hi Jean-Pierre,

Re: [Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-04-06 Thread Tomasz Wlostowski
On 04.04.2016 14:15, Maciej Sumiński wrote: > On 04/04/2016 01:39 PM, jp charras wrote: >> Sorry if you already sent me a response to this "old" message (first posted >> on feb 05) >> but I did not remember this response. Hi Jean-Pierre, If you mean this code in your patch:

Re: [Kicad-developers] [PATCH] Drop dependency on mm_malloc.h

2016-04-06 Thread Mário Luzeiro
Hi Simon, That comes from the (new) 3d-viewer render. Cirilo adopted that file with defines for the plugins structures. I agree that you clean as much that file (you can also remove the last define) I will manage in some other way in my branch in future.. to that file is tiny. Mario

[Kicad-developers] [PATCH 0/2] Two small portability patches

2016-04-06 Thread Simon Richter
Hi, these should be fairly obvious: - all Windows platforms use declspec(dllexport) - MSVC does not set a symbol called "MSVC" - use wxFileName to access the FS rather than POSIX Simon Simon Richter (2): Fix condition for Windows-style DLL export Make file test more portable

[Kicad-developers] [PATCH 1/2] Fix condition for Windows-style DLL export

2016-04-06 Thread Simon Richter
--- include/plugins/3dapi/ifsg_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/plugins/3dapi/ifsg_defs.h b/include/plugins/3dapi/ifsg_defs.h index 0523bf1..d0fd56d 100644 --- a/include/plugins/3dapi/ifsg_defs.h +++ b/include/plugins/3dapi/ifsg_defs.h @@ -31,7