Re: [Kicad-developers] [PATCH 3/5] Clean up the applications/*.destop files.

2016-05-30 Thread Simon Wells
do the fad engineering distros even define those types? On Tue, May 31, 2016 at 7:35 AM, Chris Pavlina wrote: > Perhaps. In general this should be the job of the distribution, but I'm not > sure we can count on the distributions to define such application-specific > types. Anyone else have commen

Re: [Kicad-developers] [PATCH 3/5] Clean up the applications/*.destop files.

2016-05-30 Thread Chris Pavlina
Perhaps. In general this should be the job of the distribution, but I'm not sure we can count on the distributions to define such application-specific types. Anyone else have comments on this? On Mon, May 30, 2016 at 01:36:17PM -0500, José Ignacio wrote: > On May 30, 2016 7:53 AM, "Chris Pavlina"

Re: [Kicad-developers] Italian mime update patch

2016-05-30 Thread Chris Pavlina
Committed, thank you. On Mon, May 30, 2016 at 08:26:50PM +0200, Marco Ciampa wrote: > Please apply this patch. > I updated the Italian descriptions of the mime files. > > TIA > > -- > > > Marco Ciampa > > I know a joke about UDP, but you might not get it. > > > >

Re: [Kicad-developers] [PATCH 3/5] Clean up the applications/*.destop files.

2016-05-30 Thread José Ignacio
On May 30, 2016 7:53 AM, "Chris Pavlina" wrote: > > Committed with cleanups. > > I used application/x-gerber and application/x-excellon for Gerber and Excellon > formats. There is a bit of disagreement over the proper MIME types for those, > but those are what gerbv uses, so we might as well not b

[Kicad-developers] Italian mime update patch

2016-05-30 Thread Marco Ciampa
Please apply this patch. I updated the Italian descriptions of the mime files. TIA -- Marco Ciampa I know a joke about UDP, but you might not get it. GNU/Linux User #78271 FSFE fellow #364 diff --git a/resources/linux/mime/applications/b

Re: [Kicad-developers] [PATCH 3/5] Clean up the applications/*.destop files.

2016-05-30 Thread Chris Pavlina
Committed with cleanups. I used application/x-gerber and application/x-excellon for Gerber and Excellon formats. There is a bit of disagreement over the proper MIME types for those, but those are what gerbv uses, so we might as well not be different just for the sake of it. We should probably add

Re: [Kicad-developers] [PATCH 0/5] Cleanup and fixes in the Linux desktop integration files (version 2)

2016-05-30 Thread Chris Pavlina
Pushed all but number 3, I'm working on cleaning that up a bit. Thank you. :) On Sun, May 29, 2016 at 06:30:37PM -0500, José Ignacio Romero wrote: > This series fixes bug #1583569[1] where it was reported that pcbnew > files have the wrong extension in the mime package. When I looked > deeper into

Re: [Kicad-developers] [PATCH 08/12] windows: provide performance measurement primitives

2016-05-30 Thread Wayne Stambaugh
Thanks for pointing this out @Mark. My preference is to use wxWidgets for features like this whenever possible rather than reinvent the wheel. As much as we beat wxWidgets over the head, we often don't take advantage of the features they do provide the handle the platform differences. On 5/29/20

Re: [Kicad-developers] 3D filename resolution

2016-05-30 Thread Cirilo Bernardo
Attached is an updated patch made against r6854. A patch to fix Bug #1585714 prevented the previous patch from applying cleanly. - Cirilo On Thu, Apr 21, 2016 at 5:01 AM, Wayne Stambaugh wrote: > The environment variables defined externally to kicad should take > precedence. > > On 4/19/2016

Re: [Kicad-developers] PATCH: bug #1585714

2016-05-30 Thread jp charras
Le 30/05/2016 à 10:11, Cirilo Bernardo a écrit : > Yes, it should be OK to commit the patch. > I apologize for the bug - the function is so short and I still missed > checking that. > > - Cirilo I committed it. The 3d_resolver_20160501.patch must be rebuilt, now. Thanks. -- Jean-Pierre CHARRA

Re: [Kicad-developers] PATCH: bug #1585714

2016-05-30 Thread Cirilo Bernardo
Yes, it should be OK to commit the patch. I apologize for the bug - the function is so short and I still missed checking that. - Cirilo On Mon, May 30, 2016 at 5:49 PM, jp charras wrote: > Le 30/05/2016 à 06:23, Cirilo Bernardo a écrit : > > The attached patch *should* fix bug #1585714. > > Alt

Re: [Kicad-developers] PATCH: bug #1585714

2016-05-30 Thread jp charras
Le 30/05/2016 à 06:23, Cirilo Bernardo a écrit : > The attached patch *should* fix bug #1585714. > Although I haven't tested on MSWin, I have checked the > function which was returning the false negative and > confirmed that the implementation of the > wxFileName::GetForbiddenChars() would return t