Re: [Kicad-developers] DEBUG vs NDEBUG

2016-06-01 Thread Wayne Stambaugh
Ahh, the old double negative. Using !NDEBUG would be ugly but I suppose it would be effective. I'm not sure why cmake isn't defining DEBUG for debug builds. I thought at one time it did but I could be wrong. On 6/1/2016 5:38 PM, Simon Richter wrote: > Hi, > > there was a small hiccup with a

[Kicad-developers] DEBUG vs NDEBUG

2016-06-01 Thread Simon Richter
Hi, there was a small hiccup with a missing symbol in Release builds, which I also saw in the MSVC builds, and expected to be affecting those only because I don't have explicit logic to set DEBUG and NDEBUG in CMakeLists.txt, assuming that CMake does that for me. CMake does not set DEBUG in

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-01 Thread jp charras
Le 01/06/2016 à 15:01, Maciej Sumiński a écrit : > On 05/31/2016 08:11 PM, jp charras wrote: >> Thanks, Orson. >> >> This version fixes the crash on my W7, 32 bits. >> >> I am now trying to compile in debug mode, but I have an undefined symbol: >>

Re: [Kicad-developers] mode openGL issues after latest updates

2016-06-01 Thread Maciej Sumiński
On 05/31/2016 08:11 PM, jp charras wrote: > Thanks, Orson. > > This version fixes the crash on my W7, 32 bits. > > I am now trying to compile in debug mode, but I have an undefined symbol: > E:/kicad-launchpad/essais/opengl_ctx_fix/include/xnode.h:53: undefined > reference to `vtable for XNODE'

Re: [Kicad-developers] Stable release bug fixes.

2016-06-01 Thread Nick Østergaard
Sounds like sane recommendations to me. :) 2016-06-01 14:19 GMT+02:00 Wayne Stambaugh : > I've been running into issues with merging bug fixes into the 4 stable > branch. This is to be expected as the code bases diverge. However, > some of the merge issues are due to new

[Kicad-developers] Stable release bug fixes.

2016-06-01 Thread Wayne Stambaugh
I've been running into issues with merging bug fixes into the 4 stable branch. This is to be expected as the code bases diverge. However, some of the merge issues are due to new code being committed along with the bug fix which causes merge conflicts. Please try to commit only the code required

Re: [Kicad-developers] bugs Fix Commited

2016-06-01 Thread Wayne Stambaugh
We have discussed this before. The current policy is to mark bugs as fix committed when the bug fix has been committed to either the product or the current stable release repo. Once the next stable release is rolled out, the fix committed bug reports should be changed to fixed released. If for