Re: [Kicad-developers] PATCH: OS X copy/close bug fix

in my opinion, you can connect event for alt c manually to keep it working as before On 13/07/16 02:32, Simon Richter wrote: Hi, On 13.07.2016 01:32, Brano Panak wrote: - m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ); + m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ,

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

Hi, On 13.07.2016 01:32, Brano Panak wrote: > - m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ); > + m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL , _T("Cancel")); This will break Alt-C as Cancel on the other architectures. Not a big loss in my opinion (does the Escape key work?),

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

as far as i can see in my version yes, this can be specified in wxFormBuilder as separate fields ID and LABEL On 13/07/16 02:05, Simon Wells wrote: is this settable in wxformbuilder as _base.cpp/h is autogenerated and can't be changed manually On Wed, Jul 13, 2016 at 11:32 AM, Brano Panak

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

is this settable in wxformbuilder as _base.cpp/h is autogenerated and can't be changed manually On Wed, Jul 13, 2016 at 11:32 AM, Brano Panak wrote: > i tried solution from wx forum, modified just for test > pcbnew/dimensions/grid file: > > dialog_set_grid_base.cpp > >

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

i tried solution from wx forum, modified just for test pcbnew/dimensions/grid file: dialog_set_grid_base.cpp m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ); with m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL , _T("Cancel")); and look this works as supposed in my setup. could you

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

Hi Wayne, On 12.07.2016 16:07, Wayne Stambaugh wrote: > I was looking over this patch set and before I apply it I want to be > sure that all base class functions declared as virtual are explicitly > declared as override in the derived classes. It's a very large patch > set and I don't have time

Re: [Kicad-developers] PATCH: pcbnew Design Rules actual position value correct save

thanks for info Simon, sorry this is my first patch. Brano On 12/07/16 20:37, Simon Wells wrote: Might be easier if you attach patches rather than inline them thanks On Wed, Jul 13, 2016 at 6:30 AM, Brano Panak wrote: Hi, this is patch for pcbnew design rules dialog.

[Kicad-developers] PATCH: pcbnew Design Rules actual position value correct save

Hi, this is patch for pcbnew design rules dialog. Solving problem with saving value at actual position in dialogue when hitting OK. Reported as bug #1592767. I tested this on OSX, could somebody please test this on other platforms? regards Brano === modified file

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

Simon, I was looking over this patch set and before I apply it I want to be sure that all base class functions declared as virtual are explicitly declared as override in the derived classes. It's a very large patch set and I don't have time to confirm that this is the intent of these patches.

Re: [Kicad-developers] 4.0.3 stable release last call.

Hi Wayne, Sure, no worries. Could you please give me an idea about when these icons will make it to the KiCad stable release? Cheers Fabrizio On Mon, Jul 11, 2016 at 2:22 PM, Wayne Stambaugh wrote: > Fabrizio, > > For the stable release, I want to keep the current icons.