[Kicad-developers] CMake better variable handling

Hello, I would like to hear some comments about a patch I wrote today. Earlier today I discovered that if you run CMake without setting a CMAKE_INSTALL_PREFIX during first run the variabls DEFAULT_INSTALL_PATH and for example KICAD_BIN are set only during this run. If you later change

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

Le 13/07/2016 à 08:22, jp charras a écrit : > Le 13/07/2016 à 02:26, Brano Panak a écrit : >> as far as i can see in my version yes, this can be specified in >> wxFormBuilder as separate fields ID >> and LABEL >> > > You cannot specify the label when using a wxStdDialogButtonSizer in >

Re: [Kicad-developers] PATCH: pcbnew Design Rules actual position value correct save

this saves grid only when user hits ok, when hits cancel there is no save. My opinion is that if the user hit ok he wants to save actual value. As i tested some other dialogs, they behave the same. On 13/07/16 16:18, Wayne Stambaugh wrote: While this patch may solve the problem, I'm not sure

Re: [Kicad-developers] [PATCH] Fixes wrong directory removed within generation of documentation

Please attach patches rather than inline On Thu, Jul 14, 2016 at 3:02 AM, Tobias Kohlbau wrote: > Within building the documentation with doxygen for enabled KICAD_SCRIPTING > the wrong directory is deleted. > CMake tries to remove doxygen-python-xml but within

[Kicad-developers] [PATCH] Fixes wrong directory removed within generation of documentation

Within building the documentation with doxygen for enabled KICAD_SCRIPTING the wrong directory is deleted. CMake tries to remove doxygen-python-xml but within Doxyfile_xml the output folder doxygen-xml is specified. This patch changes this behaviour to remove correct folder. Signed-off-by:

Re: [Kicad-developers] PATCH: pcbnew Design Rules actual position value correct save

While this patch may solve the problem, I'm not sure it is ideal. You are effectively deciding for the user that they are done editing the current grid cell irregardless of whether or not that is true. The behavior you are attempting to "correct" is inherent in all grid controls. As long as a

Re: [Kicad-developers] CvPcb window

Hello, just to be more clear with respect to the previous email: this is a simple sketch of how it should look like in the near future. It has been implemented just to receive a first feedback in order to understand if there is something to improve in terms of usability. Thanks, Michele. On

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

Why both "virtual" and "override" in "struct C"? It is redundant (you cannot override a non-virtual function). See http://en.cppreference.com/w/cpp/language/override. Regards, Cheng On Wed, Jul 13, 2016 at 1:27 AM, Simon Richter wrote: > Hi Wayne, > > On 12.07.2016

[Kicad-developers] CvPcb window

Hello, I have pushed a branch to change the existing 3-columns CvPcb window with a new tree-based one [1]. When you get a chance, please, test/review it and let me know if you find anything wrong. Thanks, Michele. [1] https://code.launchpad.net/~michele-castellana/kicad/new_tree_view

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

Le 13/07/2016 à 02:26, Brano Panak a écrit : > as far as i can see in my version yes, this can be specified in wxFormBuilder > as separate fields ID > and LABEL > You cannot specify the label when using a wxStdDialogButtonSizer in wxFormBuilder. Using a wxStdDialogButtonSizer is a good

Re: [Kicad-developers] PATCH: OS X copy/close bug fix

Le 13/07/2016 à 01:32, Brano Panak a écrit : > i tried solution from wx forum, modified just for test pcbnew/dimensions/grid > file: > > dialog_set_grid_base.cpp > > m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ); > with > > m_sdbSizer1Cancel = new wxButton( this, wxID_CANCEL ,