Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation

2016-07-15 Thread Wayne Stambaugh
One last call for known issues and/or objections before I merge this code into the product branch. On 7/3/2016 8:15 AM, Mário Luzeiro wrote: > Hi Chris, > > Thanks to some kind of divine help, somehow it looks to be solved and in > addition looks to be safe/free from crashes. > > Would you

[Kicad-developers] Geometry ongoing work

2016-07-15 Thread Alejandro Garcia Montoro
Hi! I've been working on some geometry code on this branch: https://code.launchpad.net/~alejandro-garciamontoro/kicad/kicad-polygon-refactor This is still an ongoing work. You can consider this as a new developer getting used to the code, waiting for Wayne and Javier to review the code and

Re: [Kicad-developers] [PATCH 0/4] Use of "virtual" and "override" keywords

2016-07-15 Thread Simon Richter
Hi, On 14.07.2016 16:17, Mark Roszko wrote: > If you put virtual blah() in struct C without override, you can be > creating a new virtual function if the signature does not match and > its completely valid. Right, but that is something we can catch with "override". The reason I like to have