Re: [Kicad-developers] [PATCH] A few small changes to CMake and the compiling instructions

2016-09-05 Thread Wayne Stambaugh
I committed your patch. Thanks. On 9/5/2016 2:03 AM, Nick Østergaard wrote: > I have attached a new patch that should apply cleanly. > > 2016-09-05 1:17 GMT+02:00 Wayne Stambaugh : >> Nick, >> >> Your patch 1 did not apply against Jon's changes to compiling.md. >> Please rebase and send me the n

[Kicad-developers] Undo buffer refactor

2016-09-05 Thread Maciej Sumiński
Recently I was refactoring the undo buffer code [1], as I have mentioned sometime ago. The main goal was to make the code simpler and more generic, remove some redundant parts. Short changelog: - BOARD_COMMIT class. Wrapper around undo buffer to simplify storing changes. Also performs all the nec

[Kicad-developers] [RFC] Nix sheet pin disambiguation menu

2016-09-05 Thread Chris Pavlina
The disambiguation menu makes it absolutely tedious to move a large number of hierarchical sheet pins. Would a patch be accepted to make hierarchical sheet pins automatically preferred when the items under the cursor are only a sheet pin or a sheet? -- Chris _

[Kicad-developers] [PATCH] Use Unicode macro for constant text

2016-09-05 Thread Simon Richter
This constant should be given as wchar_t const * in UNICODE builds on Windows, so use the _T() macro. --- common/dialog_about/aboutinfo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/dialog_about/aboutinfo.h b/common/dialog_about/aboutinfo.h index df38e7c..8e19c59

Re: [Kicad-developers] [PATCH] Use Unicode macro for constant text

2016-09-05 Thread jp charras
Le 05/09/2016 à 18:13, Simon Richter a écrit : > This constant should be given as wchar_t const * in UNICODE builds on > Windows, so use the _T() macro. AFAIK, the current code is good (since wxWidgets 3.0) and works fine on Windows. Moreover, _T() was just removed because it is discouraged ans co

Re: [Kicad-developers] [RFC] Nix sheet pin disambiguation menu

2016-09-05 Thread José Ignacio
Please! On Mon, Sep 5, 2016 at 10:13 AM, Chris Pavlina wrote: > The disambiguation menu makes it absolutely tedious to move a large > number of hierarchical sheet pins. Would a patch be accepted to make > hierarchical sheet pins automatically preferred when the items under the > cursor are only

Re: [Kicad-developers] Undo buffer refactor

2016-09-05 Thread Sergey Borshch
On 05.09.2016 17:06, Maciej Sumiński wrote: As you may have noticed, there are a lot of changes to the KiCad internals. It would be great if there were some brave folks to take the branch for a test ride. I'm unable to compile it: sources/pcb_calculator/attenuators/attenuator_classes.cpp:100:2

Re: [Kicad-developers] Undo buffer refactor

2016-09-05 Thread Maciej Sumiński
On 09/05/2016 11:34 PM, Sergey Borshch wrote: > On 05.09.2016 17:06, Maciej Sumiński wrote: >> As you may have noticed, there are a lot of changes to the KiCad >> internals. It would be great if there were some brave folks to take the >> branch for a test ride. > > I'm unable to compile it: > [sni

Re: [Kicad-developers] [RFC] Nix sheet pin disambiguation menu

2016-09-05 Thread Wayne Stambaugh
I'm OK with this. By chance did you test it with a really small sheet size just to make sure that you can still select the sheet? That's the only potential issue I can see. On 9/5/2016 11:13 AM, Chris Pavlina wrote: > The disambiguation menu makes it absolutely tedious to move a large > number o

Re: [Kicad-developers] Undo buffer refactor

2016-09-05 Thread Wayne Stambaugh
On 9/5/2016 10:06 AM, Maciej Sumiński wrote: > Recently I was refactoring the undo buffer code [1], as I have mentioned > sometime ago. The main goal was to make the code simpler and more > generic, remove some redundant parts. > > Short changelog: > > - BOARD_COMMIT class. > Wrapper around undo

Re: [Kicad-developers] [RFC] Nix sheet pin disambiguation menu

2016-09-05 Thread Chris Pavlina
I haven't tested it yet as I haven't written the patch yet. However, it is possible to select the sheet by grabbing its label, and eeschema does not allow sheet pins to be placed over labels, so the label should always be accessible. I suppose you could force it, if you really tried, into a state

[Kicad-developers] announcing eeshow (schematics renderer and viewer)

2016-09-05 Thread Werner Almesberger
I mentioned it on this list before, but here is a more formal announcement: In the Neo900 project we're faced with having to maintain complex schematics that are edited by several people and that are kept in a git repo. To keep track of each other's work (and sometimes one's own) and to resolve co

Re: [Kicad-developers] [RFC] Nix sheet pin disambiguation menu

2016-09-05 Thread Chris Pavlina
Here's a patch, have a look at it, and if you're okay with the limitation I mentioned feel free to commit :) On Mon, Sep 05, 2016 at 06:35:54PM -0400, Chris Pavlina wrote: > I haven't tested it yet as I haven't written the patch yet. However, it > is possible to select the sheet by grabbing its la