Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Nox
What about a general warning in the python console that the python interface is experimental and highly volatile + a "version" check? So that a script has to provide a version string and if this version string does not match to kicad version the script execution will be stopped - just to avoid

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Wayne Stambaugh
Here's my two cents. I share JP and Chris' concerns about developing python scripts. As project leader, I can see where a lot of things can go seriously wrong. Maybe we should make it clear that there should be no expectation from python developers that the api will remain stable during

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Chris Pavlina
On Tue, Jan 10, 2017 at 05:50:02PM +0100, Jean-Samuel Reynaud wrote: > > I'm sure you find this feature useful; > > that doesn't mean it's for full inclusion in KiCad proper. > Yes, many users of KiCad here on my side are waiting for a simpler use > of script we use internally. Anyway I understand

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Jean-Samuel Reynaud
> I'm sure you find this feature useful; > that doesn't mean it's for full inclusion in KiCad proper. Yes, many users of KiCad here on my side are waiting for a simpler use of script we use internally. Anyway I understand your position. > >> >> An other point is that master branch is a *dev*

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Tomasz Wlostowski
On 10.01.2017 16:00, Chris Pavlina wrote: > Frankly I don't think we should be encouraging users to use the Python > API until it is significantly improved. The issues JP raises make the > API completely unsuitable for plugin use. It's opaque and no users have > any idea how to write robust Python

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Chris Pavlina
On Tue, Jan 10, 2017 at 05:12:56PM +0100, Jean-Samuel Reynaud wrote: > > > Ok I understand, but Is it mean that we have to disable python scripting > in all build by default ? I can't make that call and I don't think it will be made. I do think we shouldn't be encouraging *more* use of it at

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Kristoffer Ödmark
I agree that it is not good to encourage using of it yet. The bare minimum of functionality is the undo/redo. Or at least backing up the project somehow before. On 2017-01-10 16:54, Chris Pavlina wrote: What do you do when the internal APIs change and the plugins stop working? I think

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Jean-Samuel Reynaud
Ok I understand, but Is it mean that we have to disable python scripting in all build by default ? On daily build I manage, its activated by default... On my side I will modify all plugin I use if the API change. They are based on a dev branch so I accept that. An other point is that master

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Chris Pavlina
What do you do when the internal APIs change and the plugins stop working? I think encouraging people to use this is very dangerous. It is tied so much into our internal APIs at the moment. The more people who use it, the more everybody is going to scream every single time we change anything. We

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Jean-Samuel Reynaud
Hi, Just from my point of view: We use some python plugin currently and it's not really easy to open each time python console (and remember plugins name, call mode...). I'm agree with you: During devs of scripts it's crashing and my devs have to find the rigth way to process. But this kind

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Jean-Samuel Reynaud
Hi Maciej, > > I think your patch will facilitate use of 3rd party python plugins, as > the current way of executing commands from the Python shell is not quite > user friendly. I vote for merging the patch, but we need to fix some > code formatting issues first. Ok. > > Also, I wonder if it

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Chris Pavlina
Frankly I don't think we should be encouraging users to use the Python API until it is significantly improved. The issues JP raises make the API completely unsuitable for plugin use. It's opaque and no users have any idea how to write robust Python plugins given the current state of the API. On

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread jp charras
Le 10/01/2017 à 15:18, Maciej Sumiński a écrit : > Hi Jean-Samuel, > > I think your patch will facilitate use of 3rd party python plugins, as > the current way of executing commands from the Python shell is not quite > user friendly. I vote for merging the patch, but we need to fix some > code

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Maciej Sumiński
Hi Jean-Samuel, I think your patch will facilitate use of 3rd party python plugins, as the current way of executing commands from the Python shell is not quite user friendly. I vote for merging the patch, but we need to fix some code formatting issues first. Also, I wonder if it would be the

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-10 Thread Jean-Samuel Reynaud
Hi, Yes it is based against HEAD on master. But between the hour I produce it and the hour you test it there was some modifications on scripting/kicadplugins.i ... Please find attached the updated patch. Tell me if you get an other error but on my side this patch look to work on a fresh "git