[Kicad-developers] Assertion Failure in GAL

2017-01-17 Thread Simon Richter
Hi, I can trigger an Assertion Failure fairly reliably: 1. Open KiCad 2. Open a PCB in pcbnew 3. Close the KiCad project manager This leads to kicad: /home/geier/kicad/common/gal/opengl/opengl_compositor.cpp:133: virtual void KIGFX::OPENGL_COMPOSITOR::Resize(unsigned int, unsigned int):

[Kicad-developers] Shiny New Warnings

2017-01-17 Thread Simon Richter
Hi, I just fixed the MSVC build by using a better FindPixman.cmake that doesn't make as many assumptions about the system. There are a few new warnings that popped up: > fp_lib_table.cpp:182, MSBuild, Priority: Normal > 'FP_LIB_TABLE::Parse': function assumed not to throw an exception but does

[Kicad-developers] [PATCH 2/2] Copy and adapt FindCairo.cmake for Pixman

2017-01-17 Thread Simon Richter
--- CMakeModules/FindPixman.cmake | 162 +++--- 1 file changed, 135 insertions(+), 27 deletions(-) diff --git a/CMakeModules/FindPixman.cmake b/CMakeModules/FindPixman.cmake index 18e0c399e..128ca8237 100644 --- a/CMakeModules/FindPixman.cmake +++

[Kicad-developers] [PATCH 1/2] Reduce minimum required Pixman version

2017-01-17 Thread Simon Richter
The newest version is 0.34. 1.0 doesn't exist, this only worked because there is no actual version test. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8d71af2c6..349d69df8 100644 --- a/CMakeLists.txt +++

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-17 Thread Wayne Stambaugh
Hi Konstantin, I committed your patch. Thank you for making the changes Orson suggested and the patch. In the future, please update the copyright date when you make changes to source files. Cheers, Wayne On 1/17/2017 12:17 PM, Константин Барановский wrote: > In attachment placed new patch,

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-17 Thread Simon Wells
slightly off-topic (again?) but it just came to mind. currently if option X requires Y then Y is forced on if not already on. is there a way to differentiate between an explicit OFF and an implicit OFF that we could use to force on if implicit but error if explicitly off. This might be

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-17 Thread Jean-Samuel Reynaud
> yes i was trying to subtly imply that :) ok, find attached the patch with the about box updated ;) Regards, diff --git a/CMakeLists.txt b/CMakeLists.txt index 8d71af2..52de977 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -63,6 +63,10 @@ option( KICAD_SCRIPTING_WXPYTHON "Build

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-17 Thread Константин Барановский
In attachment placed new patch, that contains both previous patches and in mousewheelpan mode, with pressed Shift key, does horizontal scrolling. So, in common, we will get: * mousewheelpan disabled: - mousewheel = zooming; - mousewheel + ctrl = horizontal scrolling; - mousewheel + shift =

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-17 Thread Simon Wells
yes i was trying to subtly imply that :) On Wed, Jan 18, 2017 at 1:39 AM, Jean-Samuel Reynaud wrote: > Did you want I add it to the patch? > > Regards. > > > > Le 16 janv. 2017 20:35, "Wayne Stambaugh" a écrit : >> >> Yes. This is a useful piece of

Re: [Kicad-developers] Via Stitching

2017-01-17 Thread Wayne Stambaugh
On 1/17/2017 7:50 AM, Kristoffer Ödmark wrote: > I looked at the video and the concept is very nice, nice work! > > I agree with wayne that automatic netcode is a bit dangerous, I would > recommend that you use a wxSingleChoice dialog in the beginning of > adding a via, so that the user can

Re: [Kicad-developers] Via Stitching

2017-01-17 Thread Kristoffer Ödmark
I looked at the video and the concept is very nice, nice work! I agree with wayne that automatic netcode is a bit dangerous, I would recommend that you use a wxSingleChoice dialog in the beginning of adding a via, so that the user can choose netcode from a list. Or something better :) > I

Re: [Kicad-developers] Current state of ActionPlugin

2017-01-17 Thread Jean-Samuel Reynaud
Did you want I add it to the patch? Regards. Le 16 janv. 2017 20:35, "Wayne Stambaugh" a écrit : > Yes. This is a useful piece of information in case we suddenly get a > rash of python scripting bug reports. > > On 1/16/2017 2:15 PM, Simon Wells wrote: > > Should this

Re: [Kicad-developers] [RFC] On net ties, microwave tools & custom pad shapes, altogether.

2017-01-17 Thread Tomasz Wlostowski
On 16.01.2017 13:41, jp charras wrote: > I am waiting for comments, especially for custom pads. Hi Jean Pierre, Many thanks for your comments. I need a bit of time to answer and rethink the proposal. I'll reply as soon as possible. Cheers, Tom ___

Re: [Kicad-developers] [PATCH] mousewheelpan + ctrl = zooming

2017-01-17 Thread Maciej Sumiński
Hi Konstantin, Your patches were not ignored, the problem was neither me nor Wayne could fully apply the patches in their original version. Thank you for correcting this. I still hold my previous remark about wheel scroll and shift+wheel scroll doing the same thing when touchpad panning is