[Kicad-developers] [PATCH] Undo/redo points for zone fill actions (GAL)

2017-02-24 Thread John Beard
Hi, Thiis is a patch to allow the zone fill/unfill actions to get undo and redo points in GAL. These functions could do with a refactor, perhaps, but this commit doesn't attempt that, in order to keep the change clear. Legacy doesn't have this function either, but once GAL makes the points,

[Kicad-developers] [PATCH]: Calculator: Simplify color code tolerance chooser + typo

2017-02-24 Thread Diego Herranz
Hi, Commit message: " Since for this tool the only difference for different tolerances is the 4th band, which is present for tolerance <= 2% and not present for 10%/5%, reduce radio choices to those two groups for clarity. Fix a typo (4rd -> 4th) and rename one variable to make it more

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Oliver Walters
Simon, Are you saying we should host the models and provide them on demand? I would agree. This way we can provide models independent of the source (scripts, etc). It also makes it way easier for users. I like the idea of a KiCad-integrated model wizard but I'll leave that for Cirilo to code

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Simon Wells
i don't see why on-install and if it can be done at install time why not just do it on-demand of the model... if its slow cache but still ondemand, providing models that we gen will likely require a full stack of development as git/github isn't really ideal for stuff like this On 25 February

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Oliver Walters
I personally find the idea of on-demand model creation appealing. I think that if we are to "promote" this as the preferred method, it should be improved through simplification and consolidation. Scripted models have only been added in the last week. Most of the models are legacy (poor quality

Re: [Kicad-developers] Stable release 4.0.6

2017-02-24 Thread Adam Wolf
I can try this weekend. Adam Wolf On Feb 24, 2017 5:50 PM, "Simon Wells" wrote: > can we get an "official" python disabled build for osx of stable(all 3 > python options disabled)? you can hide it in some nightmare of subdirs > or in testing it might just help diagnosing

Re: [Kicad-developers] Stable release 4.0.6

2017-02-24 Thread Simon Wells
can we get an "official" python disabled build for osx of stable(all 3 python options disabled)? you can hide it in some nightmare of subdirs or in testing it might just help diagnosing python/wxpython issues On 25 February 2017 at 11:39, Chris Pavlina wrote: > Yeah - my

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Cirilo Bernardo
Hi Oliver, The scripts will easily generate many GB of data in time and for me it's not reasonable to download that amount of data. I think new users should simply learn to read documentation and generate the models rather than downloading them. Package maintainers can automatically run the

[Kicad-developers] File format documentation (was Re: Stable release 4.0.6)

2017-02-24 Thread Kevin Cozens
On 2017-02-24 05:39 PM, Chris Pavlina wrote: Yeah - my general impression from a number of inconsistencies in the file format vs. the spec is that KiCad's file format really should be considered implementation-defined. In order to have a _proper_ file format spec, it seems to be that two things

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Oliver Walters
Cirilo, Unless we made script generation of models completely idiot proof, I think that requiring another niche toolset would only serve to increase the already high barrier to entry for new users. The 3D scripts require, currently: - Freecad - cadquery plugin Plus the scripts themselves are a

Re: [Kicad-developers] Stable release 4.0.6

2017-02-24 Thread Chris Pavlina
Yeah - my general impression from a number of inconsistencies in the file format vs. the spec is that KiCad's file format really should be considered implementation-defined. In order to have a _proper_ file format spec, it seems to be that two things need to be done: 1. Put the format spec _in

Re: [Kicad-developers] Stable release 4.0.6

2017-02-24 Thread Kevin Cozens
On 2017-02-23 01:29 AM, Nick Østergaard wrote: The docs are not quite ready yet, Documentation is (almost) always the last thing to get written or updated. I was making use of the file formats document while working on a project of mine to convert schematics from another program in to one

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Cirilo Bernardo
On Sat, Feb 25, 2017 at 1:12 AM, Simon Wells wrote: > why should packages be a subfolder of modules, it seems that they > don't really belong in there and should be directly in the share/kicad > folder > That would certainly be my preference. Since the root of the 3D models is

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Oliver Walters
I would tend to agree. I know that the disk location doesn't really matter, and it would be a pain to change, but having it as a direct subdirectory of KiCad/share/ seems to make more intuitive sense to me. On 25 Feb 2017 01:12, "Simon Wells" wrote: > why should packages be a

Re: [Kicad-developers] Teardrops

2017-02-24 Thread Nick Østergaard
It looks nice, but why did you chose to implement it in the legacy canvas first? 2017-02-23 12:39 GMT+01:00 Heikki Pulkkinen : > Hi all, > > Few days ago I pushed to YouTube some videos about my teardrops Legacy > canvas implementation is full working, maybe too much things.

[Kicad-developers] Jenkins build is back to normal : kicad-noscript-fedora20 #1622

2017-02-24 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH] Add cancel interactive tool to GAL

2017-02-24 Thread Maciej Sumiński
Hi John, I am really happy to see that your patching spree has not stopped. I have just committed your patch. Thank you for adding missing GAL features. Cheers, Orson On 02/24/2017 06:18 AM, John Beard wrote: > Hi, > > This adds a new action to the common ACTIONS tools: cancelInteractive. > >

[Kicad-developers] Jenkins build is back to normal : kicad-qa #2348

2017-02-24 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

Re: [Kicad-developers] Attn Wayne: Optimizing SCH_PLUGIN for component selection

2017-02-24 Thread Wayne Stambaugh
On 2/24/2017 11:29 AM, Chris Pavlina wrote: > Hi all and Wayne, > > Since the addition of SCH_PLUGIN, enumerating all symbols (done by the > component selector) has become dog slow on Windows and macOS. I've > tracked this down to the excursion from an alias list to a list of > strings and back

[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #1621

2017-02-24 Thread Miguel Angel Ajo
See Changes: [Maciej Suminski] Add cancel interactive tool action to GAL [Maciej Suminski] Disable context menu trigger if the assigned menu is set to null [Maciej Suminski] Disable router menu when the

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Kevin Cozens
On 2017-02-24 03:45 AM, Oliver Walters wrote: https://lists.launchpad.net/kicad-developers/msg27922.html [snip] First task is going to be moving the 3D models, as this will be significantly easier. e.g. something like GitHub.com/KiCad/packages3D [snip] To this end, I'd like some further

[Kicad-developers] Attn Wayne: Optimizing SCH_PLUGIN for component selection

2017-02-24 Thread Chris Pavlina
Hi all and Wayne, Since the addition of SCH_PLUGIN, enumerating all symbols (done by the component selector) has become dog slow on Windows and macOS. I've tracked this down to the excursion from an alias list to a list of strings and back to an alias list, because the only functions SCH_PLUGIN

[Kicad-developers] Build failed in Jenkins: kicad-qa #2347

2017-02-24 Thread Miguel Angel Ajo
See Changes: [Maciej Suminski] Add cancel interactive tool action to GAL [Maciej Suminski] Disable context menu trigger if the assigned menu is set to null [Maciej Suminski] Disable router menu when the tool is stopped

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Wayne Stambaugh
On 2/24/2017 10:30 AM, Maciej Sumiński wrote: > Most of the operations one can do on a BOARD_ITEM potentially affects > the board bounding box. It means there might be many places where the > notifications should be added. > > Some time ago, Michael Steinberg has put in place OBSERVABLE class >

Re: [Kicad-developers] Torrents for KiCad distribution

2017-02-24 Thread Wayne Stambaugh
That sounds like a reasonable plan to me. Anyone have any objections? Thank you Adam for offering to pay for this. Cheers, Wayne On 2/24/2017 10:38 AM, Adam Wolf wrote: > Let's log what it looks like when the next stable comes out, and > analyze it then. If we want to push our binaries to

Re: [Kicad-developers] Torrents for KiCad distribution

2017-02-24 Thread Adam Wolf
Let's log what it looks like when the next stable comes out, and analyze it then. If we want to push our binaries to Amazon or Google or some other CDN, I can almost certainly have W pay for it, especially if someone else sets it up :). I know Amazon can seed torrents and provide https downloads

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Maciej Sumiński
Most of the operations one can do on a BOARD_ITEM potentially affects the board bounding box. It means there might be many places where the notifications should be added. Some time ago, Michael Steinberg has put in place OBSERVABLE class (include/observable.h) that could facilitate the task.

Re: [Kicad-developers] Torrents for KiCad distribution

2017-02-24 Thread Mark Roszko
https helps but isn't full proof. I have to deal with a stupid Cisco system called "ScanSafe" that companies use to MITM SSL connections, causing some of my users to generate tons of client error logs from the garbage that stuff injects into my web application pages. It goes as far to rewrite the

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Wayne Stambaugh
Every BOARD_ITEM has a parent/child relationship or at least it did if someone did not break it. You can always find the parent BOARD object by walking up the BOARD_ITEM parent list. There is already a BOARD_ITEM::GetBoard() call that should return the parent board. You could use that to notify

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Jon Evans
We need a solution that allows GetBoundingBox to be called blindly, without knowing if (or how) an EDA_ITEM subclass needs to have the bounding box updated. Does anyone have ideas about how complicated it would be to give the BOARD class knowledge of whether or not anything inside it has changed?

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Wayne Stambaugh
On 2/24/2017 4:16 AM, Maciej Sumiński wrote: > Hi Jon, > > The current version looks much better to me. From what I see there is no > actual bounding box caching, as GetBoundingBox() always calls > ComputeBoundingBox(). I am fine with that, but before I push the patch I > need to ask: does anyone

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Simon Wells
why should packages be a subfolder of modules, it seems that they don't really belong in there and should be directly in the share/kicad folder On 25 February 2017 at 02:00, Adam Wolf wrote: > Yeah, let me clarify--by "wouldn't be a problem" for OS X, I meant "if >

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Adam Wolf
Yeah, let me clarify--by "wouldn't be a problem" for OS X, I meant "if you did it without saying where it's going and when it's changing", it would break the OS X package, but the change would only take a minute or two, and would be quickly testable. On Fri, Feb 24, 2017 at 6:57 AM, Wayne

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Wayne Stambaugh
On 2/24/2017 3:45 AM, Oliver Walters wrote: > Hi everyone, > > Recently I raised this issue: > > https://lists.launchpad.net/kicad-developers/msg27922.html > > There were some good responses, thanks for the input. > > First task is going to be moving the 3D models, as this will be >

Re: [Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Adam Wolf
For OS X packages, it would change a script, but shouldn't be a problem. Adam Wolf On Fri, Feb 24, 2017 at 2:45 AM, Oliver Walters wrote: > Hi everyone, > > Recently I raised this issue: > > https://lists.launchpad.net/kicad-developers/msg27922.html > > There

Re: [Kicad-developers] libcurl dependency

2017-02-24 Thread Nick Østergaard
I vaugely remember this being because of some microoptimization where we might be linking openssl statically. I am not sure of the exact details. Related discussions are: [Kicad-developers] Fwd: [PATCH] github_plugin -> curl -> openssl thread safety [Kicad-developers] libcurl github race

Re: [Kicad-developers] libcurl dependency

2017-02-24 Thread jp charras
Le 24/02/2017 à 12:12, Simon Richter a écrit : > Hi, > > On 24.02.2017 11:29, Simon Wells wrote: > >>> The proper fix is to make sure that only a single thread uses CURL. Then >>> we can drop the OpenSSL dependency ourselves, as we only initialize some >>> locking functions. > >> i believe the

Re: [Kicad-developers] libcurl dependency

2017-02-24 Thread Simon Richter
Hi, On 24.02.2017 11:29, Simon Wells wrote: >> The proper fix is to make sure that only a single thread uses CURL. Then >> we can drop the OpenSSL dependency ourselves, as we only initialize some >> locking functions. > i believe the curl-multi interface will also remove this inane requirement

Re: [Kicad-developers] libcurl dependency

2017-02-24 Thread Simon Wells
i believe the curl-multi interface will also remove this inane requirement On 24 February 2017 at 23:19, Simon Richter wrote: > Hi Cirilo, > > On 24.02.2017 01:52, Cirilo Bernardo wrote: > >> Since I know nothing of the github plugin code and the usage of curl >> within

Re: [Kicad-developers] libcurl dependency

2017-02-24 Thread Simon Richter
Hi Cirilo, On 24.02.2017 01:52, Cirilo Bernardo wrote: > Since I know nothing of the github plugin code and the usage of curl > within kicad, I thought I'd ask if that block should be qualified by the > BUILD_GITHUB_PLUGIN option or of there's some mysterious > reason why it must be there even

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Maciej Sumiński
The previous mail had incorrect patch, please check this one. On 02/24/2017 10:16 AM, Maciej Sumiński wrote: > Hi Jon, > > The current version looks much better to me. From what I see there is no > actual bounding box caching, as GetBoundingBox() always calls > ComputeBoundingBox(). I am fine

Re: [Kicad-developers] [PATCH] Move ZoomFitScreen and ZoomPreset to common

2017-02-24 Thread Maciej Sumiński
Hi Jon, The current version looks much better to me. From what I see there is no actual bounding box caching, as GetBoundingBox() always calls ComputeBoundingBox(). I am fine with that, but before I push the patch I need to ask: does anyone know why the board bounding box is cached? I believe it

[Kicad-developers] [RFC] 3D models repository

2017-02-24 Thread Oliver Walters
Hi everyone, Recently I raised this issue: https://lists.launchpad.net/kicad-developers/msg27922.html There were some good responses, thanks for the input. First task is going to be moving the 3D models, as this will be significantly easier. e.g. something like GitHub.com/KiCad/packages3D To