Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-27 Thread Sergey A. Borshch
On 28.02.2017 01:54, Julius Schmidt wrote: This patch fixes a format string assertion. ... -txt.Printf( wxT( "%u" ), net->m_PadInNetList.size() ); +txt.Printf( wxT( "%u" ), (unsigned) net->m_PadInNetList.size() ); std::vector::size() returns size_t type. Why should

[Kicad-developers] license text on new files

2017-02-27 Thread Cirilo Bernardo
As part of my work in progress on fixing UTF8 filename issues under MinGW, I need to add 2 new files to the source tree: streamwrapper.cpp streamwrapper.h I noticed that the copyright.h file has a GPL3+ template but the coding-style-policy.md has a GPL2+ template. I'm sure this has been

Re: [Kicad-developers] [PATCH] Add drawing priority support to VIEW

2017-02-27 Thread Jon Evans
One more fixup patch -- this should teach me to not try to work on two things at once On Mon, Feb 27, 2017 at 9:32 PM, Jon Evans wrote: > Hi, > > The attached patch needs to be applied after the one in my first message, > turns out that I didn't properly rebuild pcbnew and

Re: [Kicad-developers] [PATCH] Add drawing priority support to VIEW

2017-02-27 Thread Jon Evans
Hi, The attached patch needs to be applied after the one in my first message, turns out that I didn't properly rebuild pcbnew and needed to change board_commit to match the new VIEW::Add() signature. Best, Jon On Mon, Feb 27, 2017 at 6:44 PM, Jon Evans wrote: > Hi all, > >

Re: [Kicad-developers] filename fun

2017-02-27 Thread Cirilo Bernardo
On Tue, Feb 28, 2017 at 1:07 AM, Wayne Stambaugh wrote: > On 2/26/2017 4:04 PM, Cirilo Bernardo wrote: >> There is one other way which I found after much digging >> and it involves a GCC extension. Since we use GCC on >> Windows this might be acceptable: >> >> a. create a

Re: [Kicad-developers] [PATCH] Fix crash when switching from dragging to routine (PNS router)

2017-02-27 Thread John Beard
Hi Julius, The TOOL_EVENT_UTILS functions are for generic event decision logic. That PCB_ACTIONS::routerInlineDrag acts as to cancel an in progress routing is specific to the ROUTER_TOOL event loop, so it should probably be OR'ed in in ROUTER_TOOL::performRouting(), like this: else if(

[Kicad-developers] [PATCH] Fix crash when switching from dragging to routine (PNS router)

2017-02-27 Thread Julius Schmidt
The attached patch fixes a bug where triggering InlineDrag while routing is in progress will crash pcbnew. The problem is that the InlineDrag event does not terminate performRouting. Once InlineDrag is finished it will call StopRouting which deletes the m_placer. The Wait() in performRouting

Re: [Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-27 Thread Kevin Cozens
On 2017-02-27 06:54 PM, Julius Schmidt wrote: This patch fixes a format string assertion. Thank you for the patch. I ran across this problem. With your patch applied I no longer get the assertions when I select List Nets. It also saved me from having to file a bug report about the issue.

[Kicad-developers] Eeschema crash on library component name mismatch

2017-02-27 Thread Julius Schmidt
Currently eeschema crashes when a library has a component where the name under "DEF" does not agree with the name under "F1". I believe rev f35cb6cd6af3900b1967f8ef73396b9d9b8bc24c caused this issue -- previously we would add the "DEF" name to m_aliases and the component's alias list and then

[Kicad-developers] [PATCH] Assertion in pcbnew/dialogs/dialog_select_net_from_list.cpp

2017-02-27 Thread Julius Schmidt
This patch fixes a format string assertion. diff --git a/pcbnew/dialogs/dialog_select_net_from_list.cpp b/pcbnew/dialogs/dialog_select_net_from_list.cpp index f4539aa..fb70b90 100644 --- a/pcbnew/dialogs/dialog_select_net_from_list.cpp +++ b/pcbnew/dialogs/dialog_select_net_from_list.cpp @@

[Kicad-developers] [PATCH] Add drawing priority support to VIEW

2017-02-27 Thread Jon Evans
Hi all, Thanks to Tom's suggestion on how to approach this, I've got it working and now GerbView can properly render negative objects in GAL. This patch should have no impact on pcbnew. By the way, I'm getting close to feeling like I can share the work I'm doing on GerbView in a private branch,

Re: [Kicad-developers] Standalone mode.

2017-02-27 Thread Cirilo Bernardo
That sounds good to me. On Linux (where people are more likely to be using the command line) we can even appear to support the old behavior by having symlinks to a single kicad executable and making the executable launch the appropriate kiface based on its effective program name (like busybox).

Re: [Kicad-developers] New addition to the lead developer team.

2017-02-27 Thread Cirilo Bernardo
Congratulations Tom! - Cirilo On Tue, Feb 28, 2017 at 8:52 AM, Wayne Stambaugh wrote: > I have just given product and stable branch commit privileges to Tomasz > Wlostowski. Please join me in congratulating him for his promotion to > the lead development team. For those

Re: [Kicad-developers] New addition to the lead developer team.

2017-02-27 Thread Chris Pavlina
Congrats, Tomasz! Here, you earned it: https://qph.ec.quoracdn.net/main-qimg-513ddac3314cb35edf042fc728e850d1-c On Mon, Feb 27, 2017 at 04:52:06PM -0500, Wayne Stambaugh wrote: > I have just given product and stable branch commit privileges to Tomasz > Wlostowski. Please join me in

[Kicad-developers] New addition to the lead developer team.

2017-02-27 Thread Wayne Stambaugh
I have just given product and stable branch commit privileges to Tomasz Wlostowski. Please join me in congratulating him for his promotion to the lead development team. For those who don't know, Tom is responsible for the P router, tool framework, and other significant pieces of KiCad. Thank

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Simon Wells
Failed in this context means it was just unable to enable openmp, not that it failed during the cmake step. If there is another error feel free to paste the whole cmake output and we can have a look at it. If you are trying to build the latest nightlies they are currently broken on OSX On 28

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Miron Iancu
Thank you for your help. Will look into these. Regards, Miron > Pe 27 feb. 2017, la 21:31, Diogo Condeço a scris: > > Hi Miron, > > There are some scripts... > I use these: > https://github.com/xzcvczx/kicad-app > For incremental

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Diogo Condeço
Hi Miron, There are some scripts... I use these: https://github.com/xzcvczx/kicad-app For incremental builds: ./kicad-app.sh kicad_build >From scratch: ./kicad-app.sh kicad_rebuild BR On Mon, Feb 27, 2017 at 7:22 PM, Miron Iancu wrote: > Thank you all. > > How do you

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Miron Iancu
Thank you all. How do you build OS X distributions ? Boxed, i.e. for example in a XCode IDE or command-line based ? I am trying to figure out the best practices you embrace which might make a bit easier for me to set it up locally. The documentation is not quite straightforward but I assume

Re: [Kicad-developers] GerbView GAL: issue with draw order and negative items

2017-02-27 Thread Jon Evans
Hi Tom, Thanks very much for the suggestions, I will look in to doing it this way. Hi Chris, as you might tell from Tom's response, the existing tree does not keep track of insertion order and draw priority, but I will take the approach of adding that feature. I have a sample of a board with

Re: [Kicad-developers] Change behaviour of selectCopper and selectNet feature

2017-02-27 Thread Maciej Sumiński
Hi Thomas, I see your point, but before we merge your patch, we need to address the other problem first. I would like to see a bug report, but I guess this behavior is hard to trigger without applying your patch first. BTW. are the rendering glitches visible in the linked video occurring in

Re: [Kicad-developers] [PATCH] Undo/redo points for zone fill actions (GAL)

2017-02-27 Thread Maciej Sumiński
Hi, This one has been merged too, thank you once again. Cheers, Orson On 02/26/2017 06:40 PM, John Beard wrote: > Hi, > > Sorry, that patch had a dependency on a previous commit in my patch stack. > > Here's an updated one. PCB_EDITOR_CONTROL now inherits PCB_TOOL, not > TOOL_INTERACTIVE, so

Re: [Kicad-developers] [PATCH] Draw zone hatching in GAL

2017-02-27 Thread Maciej Sumiński
Hi John, Thank you for the patch, I have just merged it. Cheers, Orson On 02/26/2017 09:11 AM, John Beard wrote: > Hi, > > Here's a patch to draw the zone hatching in GAL. > > The hatching is already contained within the ZONE_CONTAINER objects, > so this patch just regenerates the hatching at

[Kicad-developers] Standalone mode.

2017-02-27 Thread Chris Pavlina
Hi, There are a few problems with "standalone mode" that I see. One of the biggest is demonstrated [1] - kiway services aren't available. In my opinion this really is detrimental to the function of the software - e.g. eeschema shouldn't be missing features just because it was started in

Re: [Kicad-developers] [Request for Tests] Experimental icon options in Kicad

2017-02-27 Thread Wayne Stambaugh
On 2/21/2017 11:48 AM, Mark Roszko wrote: > Ah. > > I had a better patch for this but I never submitted that scales the > icons 100% to intended size regardless of the display DPI without the > need for "size scale options". > wxWidgets has the functions to calcuate the correct scale, it's just

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Nick Østergaard
Usually, on linux it does build fine without openmp... but it is a long time since I have tried that. Maybe there is a bad check in the kicad cmake scripts handling that on osx? 2017-02-27 15:58 GMT+01:00 Mário Luzeiro : > AFAIK if OpenMP is not present (or not enabled..etc), the

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Mário Luzeiro
AFAIK if OpenMP is not present (or not enabled..etc), the source code (based on OpenMP #pragmas) can still be buidable. Maybe you can try to force disable it? Mario From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua...@lists.launchpad.net] on

Re: [Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Nick Østergaard
Are you sure it is not the opposite? "Development activity of OpenMP support in clang/llvm compiler has moved to www.llvm.org. Please get OpenMP-enabled clang (OpenMP 3.1 is fully supported in clang/llvm 3.7) and contribute to its further development there. This web-site is maintained for

[Kicad-developers] Trying to build locally - OS X Sierra

2017-02-27 Thread Miron Iancu
Dear All, I am trying to do a local build on a Mac OS X Sierra (10.12.3) based on the instructions found here but cmake fails with -- Try OpenMP C flag = [-fopenmp=libomp] -- Performing Test OpenMP_FLAG_DETECTED -- Performing Test OpenMP_FLAG_DETECTED - Failed AFAIK since OS X Maverick, clang

Re: [Kicad-developers] libcurl dependency

2017-02-27 Thread Wayne Stambaugh
On 2/27/2017 8:45 AM, Simon Richter wrote: > Hi, > > On 26.02.2017 17:55, Wayne Stambaugh wrote: > >> I'm not sure it's even necessary since curl's dependencies would have to >> be satisfied in order to build so I'm not sure it makes sense for the >> KiCad build config to test for and dependency

Re: [Kicad-developers] libcurl dependency

2017-02-27 Thread Simon Richter
Hi, On 26.02.2017 17:55, Wayne Stambaugh wrote: > I'm not sure it's even necessary since curl's dependencies would have to > be satisfied in order to build so I'm not sure it makes sense for the > KiCad build config to test for and dependency library sub-dependencies. The library, yes, but we

[Kicad-developers] Activation of ActionPlugin/Menu in PPA daily build

2017-02-27 Thread Jean-Samuel Reynaud
Hi All, After many tests, I plan to activate action plugin submenu in PPA daily build in few days. (cmake option -DKICAD_SCRIPTING_ACTION_MENU=ON) Any comments ? ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Ubuntu build commit IDs

2017-02-27 Thread Jean-Samuel Reynaud
Hi all, In your example 7735 is the revno form the git repo (It is not related to bzr). I had changed it with the git-commit keywork. I should be useful. Le 26/02/2017 à 16:46, John Beard a écrit : > Hi, > > Would it be possible to get the ubuntu builds tagged with a commit > hash? Version

Re: [Kicad-developers] [Patch] Add an option to select a reference point and an anchor in pcbnew move exactly dialog

2017-02-27 Thread Robbert Lagerweij
Hi, sorry for that. It is indeed a stray ">" which is a remnant of a last minute edit to remove a "this->“ coding style violation. I'll send the corrected version of the patch later today. Robbert Get Outlook for Android From: firewalker Sent: Monday, February 27,

Re: [Kicad-developers] GerbView GAL: issue with draw order and negative items

2017-02-27 Thread Tomasz Wlostowski
On 26.02.2017 20:49, Jon Evans wrote: > Hi all, > > I've run into a problem while porting GerbView to GAL that doesn't have > (...) > Another would be to implement some sort of render order sorting inside > VIEW, but I haven't looked in to that much yet, so I'm not sure how > complicated it

Re: [Kicad-developers] [Patch] Add an option to select a reference point and an anchor in pcbnew move exactly dialog

2017-02-27 Thread firewalker
I tried the patch with revision 799c8b692. I got the error bellow. [ 90%] Building CXX object pcbnew/CMakeFiles/pcbnew_kiface.dir/modedit_onclick.cpp.o /koko/kicad-git/src/kicad/pcbnew/modedit.cpp: In member function ‘void FOOTPRINT_EDIT_FRAME::moveExact()’: