Re: [Kicad-developers] [RFC] Strange libedit behaviour

2017-03-08 Thread Oliver Walters
JP, Ah, ok. I have not known of this behavior before - now that you say this I can see the button you mean. Thanks, On Thu, Mar 9, 2017 at 6:31 PM, jp charras wrote: > Le 09/03/2017 à 00:52, Oliver Walters a écrit : > > Can anyone provide some insight into why the pins

Re: [Kicad-developers] [RFC] Strange libedit behaviour

2017-03-08 Thread jp charras
Le 09/03/2017 à 00:52, Oliver Walters a écrit : > Can anyone provide some insight into why the pins are being edited in this > fashion? Why not just > edit the pin directly as its pointer is passed to the various edit / delete > functions? > When a symbol has many units, and units are

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Nick Østergaard
2017-03-09 0:03 GMT+01:00 Oliver Walters : >> Doesn't that just depend on how big and how many libs are specied in >> the pro file? This is of course project specific. > > > Yes, but I can do a direct comparison, opening the same project with an > older build and a

Re: [Kicad-developers] PATCH: (and update) non-ASCII characters in path names on MinGW

2017-03-08 Thread Cirilo Bernardo
I think I've got something that works now. The _D patch attached fixes the UTF8 issues in kicad2step provided the patch to the wxWidgets header (also attached) is applied. If the wx patch is not applied then the kicad2step code is technically fixed in kicad but will not work due to wx - however,

[Kicad-developers] [PATCH] Add method to GAL for drawing arc segments

2017-03-08 Thread Jon Evans
This new GAL API is needed for drawing outlined arc segments (like DrawSegment() does for straight segments) because the current API DrawArc() treats filled arcs like pie pieces, which is not what is needed for GerbView. Best, Jon From 596b288c755b8f2034cf0a50370243be9d02869d Mon Sep 17 00:00:00

Re: [Kicad-developers] [RFC] Strange libedit behaviour

2017-03-08 Thread Oliver Walters
Can anyone provide some insight into why the pins are being edited in this fashion? Why not just edit the pin directly as its pointer is passed to the various edit / delete functions? On Wed, Mar 8, 2017 at 12:59 AM, Sergey A. Borshch < sb...@users.sourceforge.net> wrote: > On 07.03.2017 15:07,

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Oliver Walters
> > Doesn't that just depend on how big and how many libs are specied in > the pro file? This is of course project specific. Yes, but I can do a direct comparison, opening the same project with an older build and a newer build, and get glaringly different results in terms of loading speed. On

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Nick Østergaard
2017-03-08 23:52 GMT+01:00 Chris Pavlina : > On Thu, Mar 09, 2017 at 09:46:54AM +1100, Oliver Walters wrote: >> > >> > Slow? I have noticed that the library loading slowness appeared with >> > the new IO manager thing. Although I don't have any proff to quanify >> > that.

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Chris Pavlina
On Thu, Mar 09, 2017 at 09:46:54AM +1100, Oliver Walters wrote: > > > > Slow? I have noticed that the library loading slowness appeared with > > the new IO manager thing. Although I don't have any proff to quanify > > that. > > > I can also attest that (at least on Windows) the more recently

Re: [Kicad-developers] PATCH: (and update) non-ASCII characters in path names on MinGW

2017-03-08 Thread Cirilo Bernardo
On Thu, Mar 9, 2017 at 7:53 AM, Wayne Stambaugh wrote: > On 3/8/2017 3:18 PM, Cirilo Bernardo wrote: >> On Thu, Mar 9, 2017 at 3:18 AM, Wayne Stambaugh wrote: >>> Cirilo, >>> >>> For what it's worth, it almost seems like it would have been less work

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Oliver Walters
> > Slow? I have noticed that the library loading slowness appeared with > the new IO manager thing. Although I don't have any proff to quanify > that. I can also attest that (at least on Windows) the more recently nightlies (corresponding to the new IO plugin, approximately) take ~10s to load

[Kicad-developers] [PATCH] eeschema - improve menu entry text

2017-03-08 Thread Oliver Walters
This patch changes the "Doc" string in the right-click menu for symbols in eeschema Current text -> "Doc" New text -> "Open Documentation" doc-string.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Nick Østergaard
2017-03-08 22:33 GMT+01:00 Wayne Stambaugh : > On 3/8/2017 4:08 PM, Chris Pavlina wrote: >> That's why I submitted such a trivial patch to the list first, I figured >> someone would say something ;) >> >> It does make sense to me, because the GUI is blocked. The busy cursor

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Chris Pavlina
On Wed, Mar 08, 2017 at 04:33:06PM -0500, Wayne Stambaugh wrote: > On 3/8/2017 4:08 PM, Chris Pavlina wrote: > > That's why I submitted such a trivial patch to the list first, I figured > > someone would say something ;) > > > > It does make sense to me, because the GUI is blocked. The busy

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Wayne Stambaugh
On 3/8/2017 4:08 PM, Chris Pavlina wrote: > That's why I submitted such a trivial patch to the list first, I figured > someone would say something ;) > > It does make sense to me, because the GUI is blocked. The busy cursor > says to me "yes, the GUI is supposed to be blocked right now, it's not

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Nick Østergaard
The busy cursor tells the user that he is not expected to be able to do anything sensible with the cursor other than moving it around for his own amusement. 2017-03-08 22:08 GMT+01:00 Chris Pavlina : > That's why I submitted such a trivial patch to the list first, I

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Chris Pavlina
That's why I submitted such a trivial patch to the list first, I figured someone would say something ;) It does make sense to me, because the GUI is blocked. The busy cursor says to me "yes, the GUI is supposed to be blocked right now, it's not frozen". Even with a progress bar, it can seem

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Nick Østergaard
Looks ok to me on archlinux. 2017-03-08 21:36 GMT+01:00 Chris Pavlina : > Hi, > > This patch enables display of the "busy" cursor while schematic > libraries are being loaded. Tested on Linux, Windows 10, and macOS > 10.12. > > -- > Chris > >

Re: [Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Wayne Stambaugh
Does showing a progress dialog and a busy cursor at the same time make sense? On 3/8/2017 3:36 PM, Chris Pavlina wrote: > Hi, > > This patch enables display of the "busy" cursor while schematic > libraries are being loaded. Tested on Linux, Windows 10, and macOS > 10.12. > > > >

Re: [Kicad-developers] PATCH: (and update) non-ASCII characters in path names on MinGW

2017-03-08 Thread Wayne Stambaugh
On 3/8/2017 3:18 PM, Cirilo Bernardo wrote: > On Thu, Mar 9, 2017 at 3:18 AM, Wayne Stambaugh wrote: >> Cirilo, >> >> For what it's worth, it almost seems like it would have been less work >> to just export the step file directly from pcbnew rather than the effort >> you

[Kicad-developers] [PATCH] Show the busy cursor while loading libraries

2017-03-08 Thread Chris Pavlina
Hi, This patch enables display of the "busy" cursor while schematic libraries are being loaded. Tested on Linux, Windows 10, and macOS 10.12. -- Chris >From 4003d34cccfea0b88def73169038fa192a94f85f Mon Sep 17 00:00:00 2001 From: Chris Pavlina Date: Wed, 8 Mar 2017

Re: [Kicad-developers] PATCH: (and update) non-ASCII characters in path names on MinGW

2017-03-08 Thread Cirilo Bernardo
On Thu, Mar 9, 2017 at 3:18 AM, Wayne Stambaugh wrote: > Cirilo, > > For what it's worth, it almost seems like it would have been less work > to just export the step file directly from pcbnew rather than the effort > you made to get all of this to work. I do have a few

Re: [Kicad-developers] [PATCH] eeschema: invisible pin connection

2017-03-08 Thread Oliver Walters
Then, can we look at this when the new eeschema file format is introduced? Then we'll have the ability to map one pin to multiple pads so there'll be no need for invisible pin connection. On 9 Mar 2017 02:38, "Wayne Stambaugh" wrote: > Thank you for the reply. If your

Re: [Kicad-developers] PATCH: (and update) non-ASCII characters in path names on MinGW

2017-03-08 Thread Wayne Stambaugh
Cirilo, For what it's worth, it almost seems like it would have been less work to just export the step file directly from pcbnew rather than the effort you made to get all of this to work. I do have a few comments below. On 3/8/2017 8:33 AM, Cirilo Bernardo wrote: > I'm confident that I can now

Re: [Kicad-developers] [PATCH] Fix building benchmark test

2017-03-08 Thread Wayne Stambaugh
Patch committed. Thanks. On 3/4/2017 10:03 AM, Simon Richter wrote: > > Passing a wxString to std::ifstream::ifstream() is ambiguous, at least on > MSVC. > --- > tools/io_benchmark/io_benchmark.cpp | 49 > ++-- > tools/io_benchmark/stdstream_line_reader.cpp |

Re: [Kicad-developers] [PATCH] Add missing header

2017-03-08 Thread Wayne Stambaugh
Patch committed. Thanks. On 3/1/2017 10:40 AM, Simon Richter wrote: > > color_swatch.cpp uses std::unique_ptr > --- > common/widgets/color_swatch.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > > > ___ > Mailing list:

Re: [Kicad-developers] [PATCH] Make Mac-specific function conditional

2017-03-08 Thread Wayne Stambaugh
Patch committed. Thanks. On 2/23/2017 3:00 PM, Simon Richter wrote: > If we want to have an override marker on this function, it needs to be > conditional on Mac. > --- > common/single_top.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/common/single_top.cpp

Re: [Kicad-developers] [PATCH] eeschema: invisible pin connection

2017-03-08 Thread Wayne Stambaugh
Thank you for the reply. If your patch is causing this, then I wont merge it. Breaking schematics would violate our backwards compatibility policy. I'm fine if we change the wire connection tool to prevent this in the future but we should not be changing existing connections. On 3/8/2017 4:20

[Kicad-developers] PATCH: (and update) non-ASCII characters in path names on MinGW

2017-03-08 Thread Cirilo Bernardo
I'm confident that I can now fix all remaining non-ASCII filename issues in KiCad *and* use the correct initialization macro in kicad2step (wxIMPLEMENT_APP_CONSOLE). This will require some coordination in order to avoid breaking the automatic build for Windows. Step A: Implement the patch

Re: [Kicad-developers] [PATCH] Add setting to have GAL draw axes on the grid

2017-03-08 Thread Maciej Sumiński
Hi Jon, Thank you for the patch, I have just pushed it to the master branch. Now it is also used in the module editor, which previously used a ORIGIN_VIEWITEM. Regards, Orson On 03/08/2017 03:34 AM, Jon Evans wrote: > Hi all, > > This patch adds the ability for GAL to draw axes when drawing

Re: [Kicad-developers] [PATCH] eeschema: invisible pin connection

2017-03-08 Thread Oliver Walters
Wayne, Is there any possibility that this will break existing schematic > netlists? There is no guarantee that this will not change netlist, especially as netlist association is performed based on x,y position of pins. I have just tested this, opening the same schematic in versions with this