Re: [Kicad-developers] [PATCH] Enhanced arc tool in pcbnew

2017-03-15 Thread Marcos Chaparro
As a side note... something I like about freecad sketch drawing is that you can start drawing a line, and pressing M the tool switches to arc mode, so you can draw very quickly a rounded rectangle flr example. Just a comment. Thanks and cheers On Mar 15, 2017 11:50, "John Beard"

Re: [Kicad-developers] [PATCH] Reusable GAL options panel

2017-03-15 Thread Wayne Stambaugh
Hey John, I like these changes but I noticed one minor coding policy issue. The macro _("") should be formatted as _( "" ). I'm willing to commit the patches as is and you can send a patch to fix the coding policy issues or you can revise the patches. I'm fine either way. Thanks, Wayne On

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Kristoffer Ödmark
I like this. This seems like a good way. Althougt there are a lot of unused space in my status bar ( the one that shows z: x and y, adn dx and dy. Which was where i wanted some small tool status indication. On 03/15/2017 03:22 PM, Wayne Stambaugh wrote: Why not just use the current message

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Jon Evans
It's a thought, I will play with it to see. I think there might be some situations where the suggested help we would want to show is different when no objects are selected vs. when one or more objects are selected, so it would conflict in that case. But, I know there is an object properties

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Wayne Stambaugh
Why not just use the current message panel? You could show the modifier keys and hotkeys for the current tool immediately after the tool is selected before any object action takes place. Once an object is selected by the current tool, it will just replace the tool help with the object properties

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Jon Evans
Yes, that's what I meant, it would be for the current mode, and would change based on what you are doing. It would also be hide-able so that advanced users get the screen real estate back. There are no problems with combined modifiers, you just list each action in a different box. In fact, you

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Kristoffer Ödmark
Yes, you are correct, but putting the buttons and their function in the same box would get problems with combined modifiers shift+ctrl options etc. But I was thinking of only showing current mode and not all possible modes at the same time. Mostly you would learn them anyway kinda quick, you

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Jon Evans
Hi Kristoffer, I didn't show in my mockup, but you could easily use a UI like this to show modifier keys info as well. -Jon On Wed, Mar 15, 2017 at 8:36 AM, Kristoffer Ödmark < kristofferodmar...@gmail.com> wrote: > Hello Jon, > > I do not think that the hotkeys are a problem. The right-click

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Kristoffer Ödmark
Hello Jon, I do not think that the hotkeys are a problem. The right-click menu shows how they are bound already and the right click menu is adaptable. I personally like the way that works a lot. It is more a problem regarding the modifiers, Ie buttons that must be held while doing

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Jon Evans
Hi Kristoffer, John, I agree this is an important problem to solve. I am not convinced that this is the perfect solution, but I wanted to share a way a commercial tool does it. Here's a screenshot from Mentor Graphics Xpedition showing what I mean: http://i.imgur.com/H0wDK0F.png At the bottom

Re: [Kicad-developers] [PATCH] Refactor LAYER_ID to be the one and only layer definition

2017-03-15 Thread Jon Evans
Hi Lorenzo, I think this is possible. I will look in to it. -Jon On Wed, Mar 15, 2017 at 3:05 AM, Lorenzo Marcantonio wrote: > On Tue, Mar 14, 2017 at 07:09:30PM -0400, Jon Evans wrote: > > Hi Wayne, > > > > Please keep in mind that anywhere there is currently int casting

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Kristoffer Ödmark
Yes, the status line is way to small it. However it could maybe be used to show which modifiers are in use. Not what they do. I believe that knowing which modifiers are in use would be enough, because many modifiers would probably be very self explanatory once activated, for example the

Re: [Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread John Beard
Hi Kristoffer, I agree that the "secrecy" of KiCad shortcuts is a pretty major issue. It serves to make people good at KiCad think it's great, while new users struggle (probably in silence) because they don't know there's a better way. Expanding documentation is important here (he says, not

Re: [Kicad-developers] [PATCH] Enhanced arc tool in pcbnew

2017-03-15 Thread John Beard
Hi Simon, This tool doesn't add any new feature to the arc tool other than angle snap. If the lines are rectilinear and end on the grid, the angle snapping at least makes this a /little/ bit easier. If you mean having arcs tangent to a line that "grow" out of the end of a line, that would not

Re: [Kicad-developers] [PATCH] Enhanced arc tool in pcbnew

2017-03-15 Thread Simon Richter
Hi, On 14.03.2017 16:44, John Beard wrote: > This is something I've bene toying with for a little while: an > enhanced overlay and construction method for arcs in Pcbnew. One thing that people have been asking about is a way to connect arcs and lines, is it possible to add that in your design

[Kicad-developers] Indication of modifier buttons to tools and dialogs

2017-03-15 Thread Kristoffer Ödmark
Hello all! I just wanted to highlight an emerging problem to catch it in its cradle. The new tool and dialog patches that has been merged are great. But they also introduce secret functionaly, examples: Ctrl + click: highlights net ( modifier to select tool ) ctrl + drag:snap angles in

Re: [Kicad-developers] [PATCH] Enhanced arc tool in pcbnew

2017-03-15 Thread Tomasz Wlostowski
On 14.03.2017 16:44, John Beard wrote: > Hi, > > This is something I've bene toying with for a little while: an > enhanced overlay and construction method for arcs in Pcbnew. > > The flashiest part is the new overlay, which is similar to the ruler > tool in concept and feel and uses many of the

[Kicad-developers] KiCad at EuroCircuits

2017-03-15 Thread Martijn Kuipers
Dear Developers, I am in no way affiliated with EuroCircuits, but I just received an invitation to a KiCad seminar. http://www.eurocircuits.com/blog/kicad-seminar/ I see this as a huge compliment for the state and rate of improvements of KiCad.

Re: [Kicad-developers] [PATCH] Refactor LAYER_ID to be the one and only layer definition

2017-03-15 Thread Lorenzo Marcantonio
On Tue, Mar 14, 2017 at 07:09:30PM -0400, Jon Evans wrote: > Hi Wayne, > > Please keep in mind that anywhere there is currently int casting and bounds > checking that deals with colors, will be replaced with type-safe methods in > an upcoming patch from me. For those places not dealing with

Re: [Kicad-developers] [PATCH] Refactor LAYER_ID to be the one and only layer definition

2017-03-15 Thread Lorenzo Marcantonio
On Tue, Mar 14, 2017 at 07:05:59PM -0400, Wayne Stambaugh wrote: > Hey Jon, > > This is better than the giant enum concept and I'm willing to accept > this. It still lacks the type safety of the enum inheritance solution. Bad memories with layers enums :D funny thing when I proposed the