Hi,
I'd vote of #3 but with the addition of a "Don't show this dialog in the
future" option.
If the "don't show" has been set, then simply auto save (ie: #4)
Regards
David G
On 31/03/17 01:33, Wayne Stambaugh wrote:
> I have found and fixed the bug in this bug report:
>
> https://bugs.launchpa
Hi all,
Quick patch attached to add output stream operator for COLOR4D, useful for
debugging and for some future things I am working on.
-Jon
From 05ff315a03084a27cb69645c4b3dd1aeb9124217 Mon Sep 17 00:00:00 2001
From: Jon Evans
Date: Thu, 30 Mar 2017 22:09:19 -0400
Subject: [PATCH] Add output s
Hey Orson,
I'm guessing you used the current PART_LIBS object instead of
SYMBOL_LIB_TABLE to access the symbol libraries. This method will soon
be obsolete. Will you have the time to help me with the transition? I
am willing to do it but I'm not familiar with the new symbol library
editor code
Can't build:
CMake Error at cvpcb/CMakeLists.txt:134 (add_library):
Cannot find source file:
dialogs/dialog_footprints_tree.cpp
Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
.hxx .in .txx
On Fri, Mar 31, 2017 at 12:12:54AM +0200, Maciej Suminski wrote:
> He
Here it comes, raised from the dead, the new UI for symbol library
editor [1]!
KiCad is a really fast moving target, so it has taken me plenty of time
to rebase the branch. Actually there is a completely new approach
inside, I hope it will be more robust.
I still need to replace the head commit,
I just took the cheap and dirty way out and made sure that the unit is
never 0. I agree, fixing this at the selector level probably makes more
sense but this will ensure that if someone mucks it up in the future, at
least the unit value can never be zero and reintroduce this bug.
Interestingly, d
lol, I was just going to ask you why that line is even there if _no_
components can have a zero unit, and then decided to git-blame it and
realized _I_ wrote that line.
I think the reason I did that is that the new selector returns zero when
the user has selected a root component - it only returns
The problem is line 169 of eeschema/getpart.cpp. The component unit
cannot be 0 even for components that do not have multiple units. There
probably should be an assertion in the SCH_COMPONENT ctor to warn devs
about this.
On 3/30/2017 3:24 PM, Chris Pavlina wrote:
> Ops. Sorry.
>
> I caught
Ops. Sorry.
I caught one place where I had done that. Thought that was all. :\
On Thu, Mar 30, 2017 at 03:13:31PM -0400, Wayne Stambaugh wrote:
> I believe since the new component chooser dialog has been implement
> which hasn't been very long.
>
> On 3/30/2017 2:53 PM, Maciej Suminski wrot
I believe since the new component chooser dialog has been implement
which hasn't been very long.
On 3/30/2017 2:53 PM, Maciej Suminski wrote:
> Do you know for how long the bug was present? It could help estimate the
> number of schematic files affected.
>
> As much as I hate windows popping up,
I also vote #3 for the same reason as everyone else :)
On Thu, Mar 30, 2017 at 01:33:55PM -0400, Wayne Stambaugh wrote:
> I have found and fixed the bug in this bug report:
>
> https://bugs.launchpad.net/kicad/+bug/1677282
>
> This bug creates invalid schematic files which sets the component uni
Hi!
#3 ++
Simply because it's the most transparent and informative way to solve the issue.
Maybe it's wise additionally to recommend saving the file to a different
filename because it could matter...
#5 could be to have #4 saving to a different filename or creating a backup of
the old one autom
Do you know for how long the bug was present? It could help estimate the
number of schematic files affected.
As much as I hate windows popping up, I do not think notifying the users
would be that annoying. It is going to happen only once for each invalid
file. I doubt there are people working on 1
Just thinking about the impact between #3 and #4 (I don't think #1 or #2
are good options)
#3 - impacts everyone who has used both the old and new versions,
regardless of whether they use a VCS. Impact is a minor annoyance (weird
dialog box, pops up once per schematic, that they probably don't ca
I have found and fixed the bug in this bug report:
https://bugs.launchpad.net/kicad/+bug/1677282
This bug creates invalid schematic files which sets the component unit
flag to 0 and breaks the netlist generator. The fix itself is simple.
What is not simple is what to do about the invalid schemat
I did not know that.
I think the "no snap to grid" option reachable with Shift-Ctrl is not
visible in any menu nor in the hotkey list People will have hard time
to find it I suppose unless they read the manual.
On Thu, Mar 30, 2017 at 3:47 PM, jp charras wrote:
> Le 30/03/2017 à 15:34, J
Jon,
I stand corrected. I found an issue with your patch. The layer count
in the schematic is wrong.
Before:
EELAYER 26 0
After
EELAYER 157 0
I know that this really isn't used anywhere but users who use a VCS will
complain about the unnecessary delta.
Wayne
On 3/30/2017 8:59 AM, Wayne St
HI Orson,
Thanks! Credit where credit is due: I didn't notice, it was kaitrek on
IRC. I was just mashing R until I got what I wanted!
Cheers,
John
On Thu, Mar 30, 2017 at 10:15 PM, Maciej Sumiński
wrote:
> Hi John,
>
> Good catch, I have committed both patches. I guess it has not been
> notice
Hi John,
Good catch, I have committed both patches. I guess it has not been
noticed, as most people do not really pay attention to rotation
direction, it is only up to 3 hotkey presses to get any of the 90*
multiples.
Anyway, it is surely better to perform what is written on the label.
Cheers,
O
Hi John,
I have just committed the patch, thank you for the fixes!
Cheers,
Orson
On 03/30/2017 10:20 AM, John Beard wrote:
> Hi,
>
> Quick patch to init some GAL class members.
>
> I think most (all?) of these would /eventually/ get set correctly in a
> way Coverity doesn't see, but it's good
Le 30/03/2017 à 15:34, John Beard a écrit :
> Ctrl is already used for angle snap.
>
> I think there should be a generic way to turn grid snap on and off in
> all GAL modes. Then it stays on or off until you toggle it again.
FYI, temporary turn grid snap off exists in Eeschema (when moving object
Ctrl is already used for angle snap.
I think there should be a generic way to turn grid snap on and off in
all GAL modes. Then it stays on or off until you toggle it again.
This is a little bit tricky to do as a global action due to how the
GAL tool manager keeps VIEW_CONTROL state for each tool.
I second this
Regards
Fabrizio
On Wed, Mar 29, 2017 at 2:23 AM, Andrey Kuznetsov
wrote:
> Good point Kevin.
>
> Can we have "hold down CTRL" to disable snap to grip feature? That would
> cover the caliper and other myriad of uses when snap to grid is unwanted.
>
> On Tue, Mar 28, 2017 at 7:07
Hey Jon,
I finally found some time to test and review this patch and it seems to
work just fine. My main concern is placing the schematic, gerber
viewer, and board layer IDs and their associated functions, operators,
and classes into a single file which may make creating separate board
and schema
Just wanted to point out that if there shall be flipping about arbitrary
axises, some kind of indication of how the board is currently flipped
would be nice.
Maybe axis indication or whatever.
- Kristoffer
On 03/30/2017 02:43 PM, Kevin Cozens wrote:
On Thu, Mar 30, 2017 at 4:32 PM, Cirilo Be
On Thu, Mar 30, 2017 at 4:32 PM, Cirilo Bernardo
wrote:
Beware the minefield. Aside from users complaining it doesn't work
the way they like or the way they are accustomed to, how will this
affect existing project files?
I have some RL stuff going on right now so I can't check the flip feature
This will all be moot when GAL hotkeys can be remapped, since users
that care can swap them over.
In any case, the attached patch can be applied after the correction
above to also swap 'R' and 'Shift-R', so that R is CCW.
Cheers,
John
On Thu, Mar 30, 2017 at 7:32 PM, Clemens Koller wrote:
> H
Hello, Jon!
On 2017-03-30 11:07, John Beard wrote:
> Hi,
> When CW/CCW rotation was added in GAL (7045ed92f), the tool actions
> didn't correct for the internal represention of angles, so CW/CCW were
> reversed. This patch fixes that. I failed to notice the comment "//
> TODO rotate CCW" was wrong
Hi,
When CW/CCW rotation was added in GAL (7045ed92f), the tool actions
didn't correct for the internal represention of angles, so CW/CCW were
reversed. This patch fixes that. I failed to notice the comment "//
TODO rotate CCW" was wrong. On the other hand, it seems only one
person actually notice
That will be the reason then. It's baked into the combination of layer
+ orientation, so that's how the Flip() functions must be. Makes
sense.
The follow up then is what should the Flip TOOL_ACTION (not the Flip()
function) do? Horizontal flip (left-right) or vertical (top-bottom)?
On Thu, Mar 30
Beware the minefield. Aside from users complaining it doesn't work
the way they like or the way they are accustomed to, how will this
affect existing project files? It will certainly affect the various exporters
(VRML, IDF, etc).
On Thu, Mar 30, 2017 at 6:12 PM, John Beard wrote:
> Hi,
>
> There'
Hi,
Quick patch to init some GAL class members.
I think most (all?) of these would /eventually/ get set correctly in a
way Coverity doesn't see, but it's good to keep as much as possible in
a sane state!
Cheers,
John
From a25074f51aa5d94815fa581aeed27928d218e243 Mon Sep 17 00:00:00 2001
From: J
Hi Orson,
I hit exactly the same thig with the arc assistant, so I made a little
function: GAL::ResetTextAttributes(), next to GAL::SetTextAttributes(
EDA_TEXT*).
This should be sufficient to make it easy to "reset" GAL state when in
a drawing call that doesn't depend on prior state. Also, if you
Hi,
There's a small inconsistency with the way flipping works. If you flip
text, it is flipped about the Y axis, so it remains upright, but reads
from right-to-left. If you flip anything else, it is flipped about the
X axis, so left and right are unchanged, but it is upside down.
Flipping the vie
34 matches
Mail list logo
