[Kicad-developers] Differential pair suffix matcher

2017-06-27 Thread hauptmech
Are there any issues with matching "P" and "N" instead of "_P" and "_N" for the differential pair suffix matcher? I have an existing design with the former convention. Matching the single letters will also correctly match the "_P" style suffix. If the user selects a net that is not a

Re: [Kicad-developers] fp_arc confusion

2017-06-27 Thread hauptmech
The tokens for circles are fine. I suspect it will come up about as often as it has (so once in 5 years?). Perhaps you could a couple lines of documentation for fp_arc in the file formats pdf so the next person that encounters this has a chance to recognize the error? It would have saved me a

Re: [Kicad-developers] [RFC] Documentation for pcbnew plugins

2017-06-27 Thread Simon Küppers
Find the patch attached in case there are no objections from someone else. Best Regards Simon Am 2017-06-27 21:49, schrieb Wayne Stambaugh: This looks good. Anyone else find any issues with it? You do not need to change the Doxygen configuration files. Someone modified them to use all

[Kicad-developers] Build failed in Jenkins: kicad-qa #2675

2017-06-27 Thread Miguel Angel Ajo
See Changes: [Wayne Stambaugh] Corrected Typo in documentation of GetClearance function -- Failed to access build log java.util.concurrent.TimeoutException: Ping started at

Re: [Kicad-developers] [PATCH] Small correction of documentation in BOARD_CONNECTED_ITEM::GetClearance()

2017-06-27 Thread Wayne Stambaugh
Derived methods shouldn't have Doxygen comments unless they differ from the base class which does not appear to be so in this case. Doxygen automagically populates the derived method information from the base class documentation. I committed your patch as is but at some point this should

Re: [Kicad-developers] [PATCH] Small correction of documentation in BOARD_CONNECTED_ITEM::GetClearance()

2017-06-27 Thread Simon Küppers
I tried to be consistent with documentation of overriding functions TRACK::GetClearance() and VIA::GetClearance() See https://github.com/KiCad/kicad-source-mirror/blob/master/pcbnew/class_track.h Best Regards Simon Am 27.06.2017 um 22:42 schrieb Wayne Stambaugh: > Simon, > > Since the internal

Re: [Kicad-developers] [PATCH] Small correction of documentation in BOARD_CONNECTED_ITEM::GetClearance()

2017-06-27 Thread Wayne Stambaugh
Simon, Since the internal units are nanometers, it might be more clear to state nanometers rather than internal units. Thanks, Wayne On 6/27/2017 4:25 PM, Simon Küppers wrote: > See attached. > > Best Regards > Simon > > > ___ > Mailing list:

[Kicad-developers] [PATCH] Small correction of documentation in BOARD_CONNECTED_ITEM::GetClearance()

2017-06-27 Thread Simon Küppers
See attached. Best Regards SimonFrom 4b961fda535ffac1051ac51509953fa2a6e1971c Mon Sep 17 00:00:00 2001 From: Simon Kueppers Date: Tue, 27 Jun 2017 22:21:29 +0200 Subject: [PATCH] Corrected Typo in documentation of GetClearance function MIME-Version: 1.0 Content-Type:

Re: [Kicad-developers] [RFC] new connectivity algorithm - testers needed

2017-06-27 Thread Simon Küppers
Don't worry! I was just curious. Best Regards Simon Am 27.06.2017 um 21:54 schrieb Tomasz Wlostowski: > On 27.06.2017 21:24, Simon Küppers wrote: >> Small Bump. >> >> Can anyone shed some light on the new Via Tool? Is it supposed to be not >> ready yet? The Track & Via Properties Dialog looks

Re: [Kicad-developers] [RFC] new connectivity algorithm - testers needed

2017-06-27 Thread Tomasz Wlostowski
On 27.06.2017 21:24, Simon Küppers wrote: > Small Bump. > > Can anyone shed some light on the new Via Tool? Is it supposed to be not > ready yet? The Track & Via Properties Dialog looks really unfinished and > I cannot modify anything beside Position and Via Size there. Is it > because I am using

Re: [Kicad-developers] [RFC] Documentation for pcbnew plugins

2017-06-27 Thread Wayne Stambaugh
This looks good. Anyone else find any issues with it? You do not need to change the Doxygen configuration files. Someone modified them to use all *.md files in the appropriate search paths. Please post the patch created by git format-patch and post it as an attachment and I will commit it if

Re: [Kicad-developers] [RFC] new connectivity algorithm - testers needed

2017-06-27 Thread Simon Küppers
Small Bump. Can anyone shed some light on the new Via Tool? Is it supposed to be not ready yet? The Track & Via Properties Dialog looks really unfinished and I cannot modify anything beside Position and Via Size there. Is it because I am using the Cairo Canvas? Best Regards Simon Am 25.06.2017

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Wayne Stambaugh
Something doesn't seem right in module.i. This line: def GetPluginForPath(lpath): return IO_MGR.PluginFind(IO_MGR.LEGACY) in the %pyhton section would suggest that the only plugin available to this code is the legacy plugin. Why would you not want get any valid plugin type? This

Re: [Kicad-developers] fp_arc confusion

2017-06-27 Thread Wayne Stambaugh
The tokens in the file format match the member names of the DRAWSEGMENT object so I see how this could be confusing for arcs and circles. Changing the "start" token to "center" is not a can of worms that I want to open. On 6/27/2017 8:45 AM, hauptmech wrote: > Just to clarify, I'm talking about

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Kaspar Emanuel
I am just looking at writing a fix at https://github.com/KiCad/kicad-source-mirror/blob/37f8c83c5bc5e8a61cc25d69de569dee7eea0e9f/pcbnew/swig/module.i#L69 If you can see a quick fix you could probably save me a lot of time as I am planning on getting my KiCad build set up again and submitting a

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Maciej Sumiński
On 06/27/2017 04:49 PM, Kaspar Emanuel wrote: > On 27 June 2017 at 07:56, Maciej Sumiński wrote: > > PLUGIN::FootprintEnumerate() signature has changed [1] and now instead >> of returning wxArrayString, it takes one as a reference and fills it out. >> > Thanks Orson,

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Kaspar Emanuel
On 27 June 2017 at 07:56, Maciej Sumiński wrote: PLUGIN::FootprintEnumerate() signature has changed [1] and now instead > of returning wxArrayString, it takes one as a reference and fills it out. > Thanks Orson, looks like Python bindings for that function are currently

Re: [Kicad-developers] Hard-coded hotkeys in pcbnew/tools/selection_tool.cpp

2017-06-27 Thread Nick Østergaard
If no one picks up the task now, I think a bug should be reported for tracking. Den 27. jun. 2017 2.50 PM skrev "Maciej Sumiński" : > Hi hauptmech, > > I agree this has to be fixed, yet I doubt it is located on someone's > list. If noone steps in, then most likely I will

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-06-27 Thread Jon Evans
Hi hauptmech, I am just now reading this thread and your previous one about the hotkeys. I agree that there should not be hard-coded hotkeys! In fact, this patch did not add the hotkeys, it was just moving code around that already existed. I'm fine with looking in to moving the hotkeys out of

Re: [Kicad-developers] [PATCH] Refactor COMMON_ACTIONS into a base and derived class

2017-06-27 Thread hauptmech
Hi Jon, It looks like this patch did a lot of good stuff. Nice work! I don't use kicad often, but when I do, it's with a carefully optimized keyboard mapping and enough stimulants that I look like a professional starcraft player with the fingers flying and the crowd cheering. Really

Re: [Kicad-developers] Hard-coded hotkeys in pcbnew/tools/selection_tool.cpp

2017-06-27 Thread Maciej Sumiński
Hi hauptmech, I agree this has to be fixed, yet I doubt it is located on someone's list. If noone steps in, then most likely I will do it at one point in the future. Regards, Orson On 06/27/2017 01:29 PM, hauptmech wrote: > @Jon Evans maybe, > > I spent an embarrasing amount of time trying to

Re: [Kicad-developers] fp_arc confusion

2017-06-27 Thread hauptmech
Just to clarify, I'm talking about the file format not the internal implementation. The file_formats documentation has the old format using 'center' and 'start' for circles and 'start' and 'end' for arcs (which go from a start point to and end point as the terminology suggests). All good and

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Wayne Stambaugh
I changed this so that we could provide partial footprint library loading for plugins that support one file per item. This is an unfortunate side effect of using exceptions. In order to provide the partial list of parsed footprint files, I had to pass a reference to the array. Nothing gets

Re: [Kicad-developers] fp_arc confusion

2017-06-27 Thread Wayne Stambaugh
It's not an error. Arcs are part of the DRAWSEGMENT object which encapsulates line segments, arcs, etc. The start coordinate (m_start member) is the center point for arcs and circles. It is documented as such in the KiCad source. wxPoint m_Start; ///< Line start point or Circle and

[Kicad-developers] Hard-coded hotkeys in pcbnew/tools/selection_tool.cpp

2017-06-27 Thread hauptmech
@Jon Evans maybe, I spent an embarrasing amount of time trying to assign hotkey actions to the 'I' and 'U' keys in pcbnew before realizing they were getting captured somewhere else and digging into the source. It appears that they have been hard-coded in pcbnew/tools/selection_tool.cpp for

Re: [Kicad-developers] Pcbnew Python Interface breakage?

2017-06-27 Thread Maciej Sumiński
Hi Kaspar, This change is not related to the connectivity branch merge. PLUGIN::FootprintEnumerate() signature has changed [1] and now instead of returning wxArrayString, it takes one as a reference and fills it out. Regards, Orson 1.