Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread hauptmech
This would be a demo for testing only. I'll have to obfuscate and sabatoge parts. Still useful? On 25/07/17 02:07, Wayne Stambaugh wrote: I would accept a patch for a more complex demo for performance testing purposes. On 7/24/2017 4:05 AM, Kristoffer Ödmark wrote: I for one would really

Re: [Kicad-developers] bugs in stable 4.07

2017-07-24 Thread Adam Wolf
This is not a problem for MacOS packaging. The things that impact MacOS packaging are when the dependencies change. Remaking a 4.0.7 build after the tag moves isn't a problem. Adam On Mon, Jul 24, 2017 at 9:45 AM, Wayne Stambaugh wrote: > If we have known segfault bugs

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread hauptmech
I haven't learned enough about the KIWAY to trace the events from pcbnew to eeschema yet. I'd be curious is this is reproducible in other systems. Easy to test on linux using the perf tool https://perf.wiki.kernel.org/index.php/Main_Page 1) run kicad, open a pcb and schematic of any size.

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread hauptmech
I don't see anything that suggests pcbnew is doing sheet list stuff. I was assuming that whatever event connection between pcbnew and eeschema exists was the culprit. On 25/07/17 10:25, Wayne Stambaugh wrote: On 7/24/2017 6:12 PM, hauptmech wrote: Yeah, it's weird since all I'm doing

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread Wayne Stambaugh
On 7/24/2017 6:12 PM, hauptmech wrote: > > Yeah, it's weird since all I'm doing when collecting perf data is > zooming and panning the pcb, (with eeschema open). A root page and 11 > sub pages at the next level. Roughly 800 components and 2000 wires. > > Probably something somewhere is

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread hauptmech
Yeah, it's weird since all I'm doing when collecting perf data is zooming and panning the pcb, (with eeschema open). A root page and 11 sub pages at the next level. Roughly 800 components and 2000 wires. Probably something somewhere is instantiating a new SCH_SHEET_LIST (which then has to

Re: [Kicad-developers] [PATCH] More aggressive sheet-selection

2017-07-24 Thread Kristoffer Ödmark
After suggestions from chris, I deactivated the "select all items on sheet" on left-click inside eeschema, and instead added a context menu for it when rightclicking on a sheet in eeschema. This is a separate patch to the sheet-selection improvement. I do not know how to generate a icon for

[Kicad-developers] Generating the _xpm files uside by icons in eeschema.

2017-07-24 Thread Kristoffer Ödmark
Hello! I am working on some patches currently that adds a few menu entries in eeschema. Since they seem to require me to add icons to all of the entries, I am now stuck on trying to generate the .cpp files. Could someone point me in the correct way on how to do this. I currently have added

Re: [Kicad-developers] [PATCH] - Improved error messages

2017-07-24 Thread Wayne Stambaugh
Oliver, I finally got a chance to look at these patches and they seem fine to me. I am willing to commit them as is if there are no other objections. One minor note. I don't know if this was intentional or not but please use normal sentence punctuation in dialog messages. You managed to

Re: [Kicad-developers] Speed improvements for SELECT / DESELECT in GAL

2017-07-24 Thread Kristoffer Ödmark
Just tried this on a large project. The speedup is noticeable. On 07/24/2017 04:25 PM, Oliver Walters wrote: When I was working on speed improvements for DUPLICATE action in GAL, I also discovered that the select / deselect functions were very slow. Ref:

Re: [Kicad-developers] bugs in stable 4.07

2017-07-24 Thread Wayne Stambaugh
If we have known segfault bugs we should fix them. I can remove the tag on the stable branch and move it to your bug fix commits. Nice catch. I need some input from our package devs as to the impact on the stable release packaging. I can push the release back another week or two to allow our

Re: [Kicad-developers] Stable release 4.0.7

2017-07-24 Thread Wayne Stambaugh
On 7/24/2017 10:27 AM, Oliver Walters wrote: > Wayne, > > Fair point regarding breaking 3D model links for existing designs. As > the pcb caches footprints then this is probably the best approach in > terms of not breaking anything. I think users will be unhappy if they do a micro release update

[Kicad-developers] Speed improvements for SELECT / DESELECT in GAL

2017-07-24 Thread Oliver Walters
When I was working on speed improvements for DUPLICATE action in GAL, I also discovered that the select / deselect functions were very slow. Ref: https://lists.launchpad.net/kicad-developers/msg29539.html The attached patch reduces time taken to select / deselect items by ~75% Test Case: ~500

Re: [Kicad-developers] Stable release 4.0.7

2017-07-24 Thread Wayne Stambaugh
Oliver, I'm guessing that the 3D model file names have also changed so using the older footprints with the new 3D models is going to be an issue. I'm tempted to keep the 4.0.6 tagged libraries so users existing symbol and 3D model libraries don't change and break user's designs. I am open to

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread Wayne Stambaugh
I would accept a patch for a more complex demo for performance testing purposes. On 7/24/2017 4:05 AM, Kristoffer Ödmark wrote: > I for one would really appreciate having a larger testproject in the demos. > > - Kristoffer > > On 07/24/2017 01:36 AM, hauptmech wrote: >> I'm getting a

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread Wayne Stambaugh
On 7/23/2017 7:36 PM, hauptmech wrote: > I'm getting a distracting amount of lag when panning and zooming with > GAL. Perf reports TOOL_MANAGER::dispatchInternal and, when eeschema is > open, SCH_SHEET_LIST::BuildSheetList, as the main time sinks. Given that all BuildSheetList does is create a

Re: [Kicad-developers] Stable release 4.0.7

2017-07-24 Thread Oliver Walters
Wayne, Sorry I thought I had replied to this, it was sitting in my outbox. If we keep the 4.0.6 tagged libraries, then there will be discrepancies for users if they are using the live github footprint libraries (in particular a lot of the 3D models will not be correctly oriented). How do you

Re: [Kicad-developers] [PATCH] More aggressive sheet-selection

2017-07-24 Thread Kristoffer Ödmark
Hmm, I was planning to send that mail to the ML. will resend it there. I am unsure about the separate tool. Most circuits I am using this on is instant, but I guess that doing both could be a viable option. The tool is available as a separate tool from pcbnew. On 07/24/2017 04:50 AM, Chris

Re: [Kicad-developers] Performance issues in pcbnew

2017-07-24 Thread Kristoffer Ödmark
I for one would really appreciate having a larger testproject in the demos. - Kristoffer On 07/24/2017 01:36 AM, hauptmech wrote: I'm getting a distracting amount of lag when panning and zooming with GAL. Perf reports TOOL_MANAGER::dispatchInternal and, when eeschema is open,

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

2017-07-24 Thread Fabrizio Tappero
Hi guys, thanks for the explanation. cheers Fabrizio On Fri, Jul 21, 2017 at 11:06 PM, Wayne Stambaugh wrote: > This is correct. I just remember if the string in a group box > (wxStaticBoxSizer) than it doesn't get a colon. If the string is static > text (wxStaticText)