[Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-25 Thread Dan Green
Hi all, here are two patches to address some minor issues with the "Update PCB from Schematic” tool when called from pcbnew. The first adds the F8 hotkey to match eeschema. The second fixes a bug that happens if the project name contains a period (e.g.: MyProject_rev1.2). In this case, the

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-25 Thread Kristoffer Ödmark
Hi tom! I took a look at your branch and your changes are a lot more smooth than mine, I went back to your implementation and added the net propagation stuff, they did indeed crash kicad when copying between different PCBs. How should I submit this patch to you? Also, I think that we should

Re: [Kicad-developers] [PATCH] GerbView GAL support

2017-09-25 Thread Jon Evans
Thanks Orson. The attached patch changes the d-code LOD threshold to a more reasonable value. -Jon On Mon, Sep 25, 2017 at 8:31 AM, Maciej Sumiński wrote: > Jon, > > Thank you very much for your work on GerbView GAL support. I have just > pushed your changes to the

Re: [Kicad-developers] [PATCH] Multilayer keepout zones

2017-09-25 Thread Oliver Walters
Wayne, I was initially thinking that multilayer only made sense for keepouts and that check was simply a guard. Now I think it is a good idea for copper too. I can remove that check in the file parser. Oliver On 26 Sep 2017 05:32, "Wayne Stambaugh" wrote: Oliver, I

Re: [Kicad-developers] GitHub Plugin (my nemesis)

2017-09-25 Thread Rene Pöschl
On 23/09/17 20:51, Thomas Kindler wrote: The other suggestions were quite surprising to me -- Github API, downloading individual subdirectories as .zip, abusing subversion (gasp), gitslave (last updated 2012), etc. would be a big hurdle and WTF for new KiCAD users. Sorry for the late response.

Re: [Kicad-developers] [PATCH] Multilayer keepout zones

2017-09-25 Thread Wayne Stambaugh
Oliver, I have a minor issue with your patch set. What is your rationale for assuming if a zone is on more than one layer that it is a keepout zone? I'm not sure that this would always be valid. There is already a "keepout" keyword in the list of board file keywords for just such an occasion.

Re: [Kicad-developers] [PATCH] PcbNew Eagle Plugin: Remove layer restriction on some graphic items, fix undrawn items and place values on fabrication layers.

2017-09-25 Thread Wayne Stambaugh
On 9/25/2017 9:13 AM, jp charras wrote: > Le 25/09/2017 à 10:22, Maciej Sumiński a écrit : >> Hi Russell, >> >> Would you provide a board example that would be affected by the change? >> It would be very helpful to test the patch. >> >> I am not really sure whether EDGE_MODULEs drawn on copper

Re: [Kicad-developers] [PATCH] Multilayer keepout zones

2017-09-25 Thread Oliver Walters
Jon, I was considering the implication of copper pours being multilayer. I like the idea, and my current implementation allows that as a future step.. In a copper pour the filled region is defined as a set of points. I assume that such an idea would require that each layer gets its own set of

Re: [Kicad-developers] [PATCH] Fix some performance issues

2017-09-25 Thread Wayne Stambaugh
On 9/25/2017 4:07 AM, Maciej Sumiński wrote: > Hi Camille, > > I think the attached patches are sensible, even though I hope most > compilers apply optimizations to avoid performance penalties whenever > possible. I agree although I'm not sure about the compiler optimization. A quick look at

Re: [Kicad-developers] [PATCH] Multilayer keepout zones

2017-09-25 Thread Jon Evans
Nice job Oliver. This is a great feature and your plan to add keepout support to footprints is also a good thing. I tried it out on my MacOS machine and found an issue I think -- after deleting a keepout, I filled zones again and the fill is still avoiding the keepout shape after deletion -- not

[Kicad-developers] Jenkins build is back to normal : kicad-noscript-fedora20 #2122

2017-09-25 Thread Miguel Angel Ajo
See ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH] PcbNew Eagle Plugin: Remove layer restriction on some graphic items, fix undrawn items and place values on fabrication layers.

2017-09-25 Thread jp charras
Le 25/09/2017 à 10:22, Maciej Sumiński a écrit : > Hi Russell, > > Would you provide a board example that would be affected by the change? > It would be very helpful to test the patch. > > I am not really sure whether EDGE_MODULEs drawn on copper layers will be > exported to Gerbers and I am

[Kicad-developers] [PATCH] Multilayer keepout zones

2017-09-25 Thread Oliver Walters
Attached is a patchset that allows keepout zones to "exist" on multiple copper layers. This means you can specify a keepout zone for the entire copper stack (or parts thereof). Features: If a keepout zone is specified as multiple layers, the .kicad_mod file output is adjusted slightly, it will

Re: [Kicad-developers] [PATCH] GerbView GAL support

2017-09-25 Thread Maciej Sumiński
Jon, Thank you very much for your work on GerbView GAL support. I have just pushed your changes to the master branch, including the most recent patches. The display performance is significantly better when compared to the legacy renderer. Still, if you are interested in further improvements, a

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-25 Thread Kristoffer Ödmark
Unfortunately I cannot test this at work. But I took a look at the diff between what I had made in the and your additions. Are you no longer using the pi.Load() function to append the items from the clipboard? From where I am looking it looks this way. This is good. Same thing I did in my

Re: [Kicad-developers] [Patch] pcbnew clipboard support

2017-09-25 Thread Tomasz Wlostowski
On 25.09.2017 10:03, Kristoffer Ödmark wrote: > Maybe I could get access to the work you have done and cherry pick > patches from there, or just test it and see the difference? Hi, Sorry, I totally forgot to send you the link: https://github.com/twlostow/kicad-dev/tree/tom-copypasta Tom > >

Re: [Kicad-developers] [PATCH] Right click option to change layer and render color

2017-09-25 Thread Maciej Sumiński
Seppe, Unfortunately, we do not backport new features to the stable branch, as we do not have enough manpower to maintain it, especially now when the code is significantly diverged. The stable branch only receives bug fixes, whereas the product branch is reserved for development. Regards, Orson

Re: [Kicad-developers] [PATCH] Right click option to change layer and render color

2017-09-25 Thread Seppe Stas
Cool, thanks! Any chance this (and/or the double click feature) could be released in KiCad 4? I would love to start using it in the stable release... Seppe On Mon, Sep 25, 2017 at 10:01 AM, Maciej Sumiński wrote: > Seppe, > > Thank you for your contribution. As the

Re: [Kicad-developers] [PATCH] PcbNew Eagle Plugin: Remove layer restriction on some graphic items, fix undrawn items and place values on fabrication layers.

2017-09-25 Thread Maciej Sumiński
Hi Russell, Would you provide a board example that would be affected by the change? It would be very helpful to test the patch. I am not really sure whether EDGE_MODULEs drawn on copper layers will be exported to Gerbers and I am certain that they will not be taken into account during DRC or

Re: [Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #2121

2017-09-25 Thread Nick Østergaard
Investigating... 2017-09-25 10:15 GMT+02:00 Miguel Angel Ajo : > See display/redirect> > > -- > Failed to access build log > > java.util.concurrent.TimeoutException: Ping

[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #2121

2017-09-25 Thread Miguel Angel Ajo
See -- Failed to access build log java.util.concurrent.TimeoutException: Ping started at 1506326836000 hasn't completed by 1506327076001 Caused: java.io.IOException at

[Kicad-developers] Build failed in Jenkins: kicad-noscript-fedora20 #2120

2017-09-25 Thread Miguel Angel Ajo
See -- Failed to access build log java.util.concurrent.TimeoutException: Ping started at 1506326836000 hasn't completed by 1506327076001 Caused: java.io.IOException at

Re: [Kicad-developers] [PATCH] Fix some performance issues

2017-09-25 Thread Maciej Sumiński
Hi Camille, I think the attached patches are sensible, even though I hope most compilers apply optimizations to avoid performance penalties whenever possible. If the attached patches are autogenerated, then I would kindly ask you to generate them when we reach the feature freeze stage. There are

Re: [Kicad-developers] [PATCH] Right click option to change layer and render color

2017-09-25 Thread Maciej Sumiński
Seppe, Thank you for your contribution. As the context menu problem is not related to your changes, I decided to commit the patches. I observe the issue with right-click context menu on Arch Linux x86_64 with both Xfce and awm. I cannot tell whether the problem occurs in the stable version, as I