Re: [Kicad-developers] wxAUI woes

2017-10-27 Thread hauptmech
On 28/10/17 01:00, Wayne Stambaugh wrote: If the pane is mandatory (no view toggle) you probably need to hard-code unhiding it after LoadPerspective to be nice to users upgrading with config files in place. You will most likely have to force the change in the perspective to ensure that you can

Re: [Kicad-developers] [PATCH] Eeschema automatic manage junctions

2017-10-27 Thread Simon Richter
Hi, On 28.10.2017 02:09, Seth Hillbrand wrote: > Quick ping on this.  Master has moved on, so I've re-based the patch set > to the current master, in case anyone is up for looking at it.  I also > split out the largest patch into a couple of logical blocks, in hopes of > making it easier to

Re: [Kicad-developers] [PATCH] Eeschema automatic manage junctions

2017-10-27 Thread Seth Hillbrand
Hi All- Quick ping on this. Master has moved on, so I've re-based the patch set to the current master, in case anyone is up for looking at it. I also split out the largest patch into a couple of logical blocks, in hopes of making it easier to review. Lastly, I found and fixed a corner case

Re: [Kicad-developers] wxAUI woes

2017-10-27 Thread Wayne Stambaugh
On 10/27/2017 2:04 AM, hauptmech wrote: > > That must have been painful to find... > > A quick read of the Aui code says yes there is a problem. They hide all > panels at the beginning of LoadPerspective and then update only panels > with keys in the configuration string. So anything new and not

Re: [Kicad-developers] [PATCH] Nest level error, causes problems with git

2017-10-27 Thread jp charras
Le 27/10/2017 à 11:53, Kristoffer Ödmark a écrit : > And here is acodigng style fix that applies on top of that. > > Sorry! > > On 10/27/2017 11:49 AM, jp charras wrote: >> Le 27/10/2017 à 11:03, Kristoffer Ödmark a écrit : >>> Hi! I found that the nest level when saving stuff is wrong ( error

Re: [Kicad-developers] [PATCH] Nest level error, causes problems with git

2017-10-27 Thread Kristoffer Ödmark
Whoops, managed to mess upp the coding style while only changing 3 lines.. not very good Updated On 10/27/2017 11:03 AM, Kristoffer Ödmark wrote: Hi! I found that the nest level when saving stuff is wrong ( error from the clipboard plugin ). This patch fixes that so that version control

Re: [Kicad-developers] [PATCH] Nest level error, causes problems with git

2017-10-27 Thread jp charras
Le 27/10/2017 à 11:03, Kristoffer Ödmark a écrit : > Hi! I found that the nest level when saving stuff is wrong ( error from the > clipboard plugin ). > > This patch fixes that so that version control systems doesnt generate large > diffs when saving. > I committed your patch. Thanks. --

[Kicad-developers] [PATCH] Nest level error, causes problems with git

2017-10-27 Thread Kristoffer Ödmark
Hi! I found that the nest level when saving stuff is wrong ( error from the clipboard plugin ). This patch fixes that so that version control systems doesnt generate large diffs when saving. -- -Kristoffer >From d07b38f27509533de087a089febfe68dd8fb58db Mon Sep 17 00:00:00 2001 From:

Re: [Kicad-developers] wxAUI woes

2017-10-27 Thread hauptmech
That must have been painful to find... A quick read of the Aui code says yes there is a problem. They hide all panels at the beginning of LoadPerspective and then update only panels with keys in the configuration string. So anything new and not in the config file will stay hidden. I'm not