[Kicad-developers] Developer note: GTK+ file dialog wildcards.

2017-11-11 Thread Wayne Stambaugh
In the process of fixing the case sensitive file extension bug https://bugs.launchpad.net/kicad/+bug/1720542, I learned way more about the GTK+ file dialog than I really wanted to. There is now code in common/wildcards_and_files_ext.cpp to provide proper platform (at least GTK+ or windows, osx is

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 07:50 PM, Oliver Walters wrote: > Tom, > > Another thought I have had which would address some ongoing discussion > regarding default library paths. > > I think that the table(s) should show which libraries are located in > 'read-only' locations. I am not sure how to determine this

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 07:51 PM, Oliver Walters wrote: > Simon, > > I agree that we should not use wxGrid for such a dialog. Other wx > classes are somewhat harder to use but provide a much better interface > (once you get them right). I'm not opposed to using any UI element that improves the user experie

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

2017-11-11 Thread Oliver Walters
Simon, I agree that we should not use wxGrid for such a dialog. Other wx classes are somewhat harder to use but provide a much better interface (once you get them right). On Sun, Nov 12, 2017 at 11:46 AM, Simon Wells wrote: > would it not be better to use one of the types that uses native table

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

2017-11-11 Thread Oliver Walters
Tom, Another thought I have had which would address some ongoing discussion regarding default library paths. I think that the table(s) should show which libraries are located in 'read-only' locations. I am not sure how to determine this in an OS independent manner, but I think that it would be a

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

2017-11-11 Thread Simon Wells
would it not be better to use one of the types that uses native tables rather than wxgrid? what is wxgrid giving you that the native tables aren't? > On 12/11/2017, at 13:44, Oliver Walters > wrote: > > Hi Tom, > > This is a fantastic idea, I think that your mock up has a lot of good UX > i

Re: [Kicad-developers] [RFC] redesign of Library Table dialog

2017-11-11 Thread Oliver Walters
Hi Tom, This is a fantastic idea, I think that your mock up has a lot of good UX improvements. In particular I like the idea of "active" for each library. You then do not have to find a library once you have removed it from the table, only tick "active". Brilliant. Regarding the "advanced option

[Kicad-developers] [PATCH] Fix aperture macro hit testing (Fixes lp:1730249)

2017-11-11 Thread Jon Evans
Hi all, This patch fixes a bug reported by Nick in GerbView GAL, where aperture macro hit testing wasn't quite right. https://bugs.launchpad.net/kicad/+bug/1730249 -Jon From 2e20fe8d6130d9531ce99bb432e4f9cfce61e589 Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Sat, 11 Nov 2017 17:20:19 -0500 S

Re: [Kicad-developers] Asciidoc question.

2017-11-11 Thread Marco Ciampa
On Sat, Nov 11, 2017 at 01:46:07PM +0100, Marco Ciampa wrote: > On Fri, Nov 10, 2017 at 08:20:32AM -0500, Wayne Stambaugh wrote: > > Maybe one of our resident asciidoc experts can help me out. I used a > > WARNING admonition in the kicad website symbol library table blog > > post[1]. I was expect

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread Wayne Stambaugh
I misunderstood the intention of this patch. I though it had nothing to do with the units change patch. I will revert it. Please send me the file format change patch when you get a chance and I merge them both at the same time. Sorry about the mix up. On 11/11/2017 03:34 PM, Oliver Walters wro

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread Oliver Walters
Wayne, I had not yet made any changes to the file parser. Have you done this according to your new file-version approach? Or do you want me to submit a further patch implementing that? On 12 Nov 2017 07:16, "Wayne Stambaugh" wrote: > Oliver, > > I committed your patch to the KiCad development b

Re: [Kicad-developers] [PATCH] Change default repo for 3D model downloader

2017-11-11 Thread Wayne Stambaugh
Oliver, I committed your patch to the KiCad development branch. Cheers, Wayne On 11/10/2017 06:08 PM, Oliver Walters wrote: > This patch changes the default directory for the 3D model downloader tool. > > The new 3d model repository is at https://github.com/kicad/kicad-packages3d > > > _

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread Wayne Stambaugh
Oliver, I committed your patch to the KiCad development branch. Thanks, Wayne On 11/08/2017 05:05 AM, Oliver Walters wrote: > Attached is a patch that fixes the problems I found in my 3D model array > investigation. As discussion on that is stalled for now, this patch > simply fixes the model o

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread easyw
Unless a user used custom models or some of the older library models, the offset will be 0,0,0 so I suspect the issues will be minimal and will quickly diminish over time. the issue will be on users that are using manufacturer's models for 3D step connectors and having assembly of boards (i.e. me

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 01:36 PM, easyw wrote: > Hi Wayne, > I agree that probably the simplest and clearest solution it would be > just to switch the reading depending on which version of pcbnew is the > file. > > In-fact it could be possible also to preserve the existing offset > without the need to manua

Re: [Kicad-developers] [PATCH] Fix field align settings in dialogs of Eeschema.

2017-11-11 Thread jp charras
Le 10/11/2017 à 17:46, Константин Барановский a écrit : > In Eeschema: > 1) open dialog for editing properties of a component > 2) set align left and _bottom_ for Ref field > 3) press OK for applying > 4) Ref field will aligned by left _top_ corner of its boundin box > > And more, checkboxes for a

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread easyw
Hi Wayne, I agree that probably the simplest and clearest solution it would be just to switch the reading depending on which version of pcbnew is the file. In-fact it could be possible also to preserve the existing offset without the need to manually adjust the board. If the pcbnew app would c

Re: [Kicad-developers] when to release kicad-5.0

2017-11-11 Thread Wayne Stambaugh
Which of the patches in the bug report do I need to apply? I tried testing this yesterday and the 180 setting was wrong and the hot key rotate was is it always has been. On 11/10/2017 08:29 PM, Kevin Cozens wrote: > On 2017-11-10 04:21 PM, Wayne Stambaugh wrote: >> I have not gone through it rece

Re: [Kicad-developers] [FEATURE] Eeschema Line Styles

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 03:07 AM, jp charras wrote: > Le 11/11/2017 à 05:51, Seth Hillbrand a écrit : >> Wayne- >> >> Thank you for taking the time to look at this patch.  I recognize that you >> and the other devs have a >> lot on your plate, so I appreciate the constructive feedback. I'll approach >> the

Re: [Kicad-developers] [BUG] Eeschema: project specific libraries does not load

2017-11-11 Thread Wayne Stambaugh
I just pushed a fix for this. Thanks for pointing it out. Cheers, Wayne On 11/11/2017 06:09 AM, Константин Барановский wrote: > In my test project all symbols stored in library "components.lib" that > stored in project dir. > I'm open library manager and going to "Project Specific Libraries" ta

Re: [Kicad-developers] [BUG] Eeschema: project specific libraries does not load

2017-11-11 Thread Wayne Stambaugh
It was a copy and paste error on my part. I will fix it as soon as I get a chance. Thanks for the heads up. On 11/11/2017 07:27 AM, Константин Барановский wrote: > Yes, really now project specific libraries loads correctly but name of > table still contain fp-lib-table instead of sym-lib-table.

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread jp charras
Le 11/11/2017 à 15:00, Wayne Stambaugh a écrit : > On 11/11/2017 04:00 AM, Carsten Schoenert wrote: >> Hi, >> >> Am 10.11.2017 um 13:33 schrieb Wayne Stambaugh: >>> I merged your patch into the dev branch. Thank you for your >>> contribution to KiCad. >> >> while working on some translations I com

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 05:50 AM, jp charras wrote: > Le 11/11/2017 à 11:17, Carsten Schoenert a écrit : >> Am 11.11.2017 um 11:07 schrieb jp charras: while working on some translations I come over this commit or fixup and noticed this and some other strings in the showed windows are not trans

Re: [Kicad-developers] adding support for OCCT

2017-11-11 Thread Simon Wells
OCE is the same licence as OCCT which is LGPL since 6.7.0 thanks > On 12/11/2017, at 02:52, Wayne Stambaugh wrote: > > That's a show stopper unless someone is willing to step up and fix this > issues. Just out of curiosity and a bit of laziness, what is the OCCT > license before we decide to

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 04:00 AM, Carsten Schoenert wrote: > Hi, > > Am 10.11.2017 um 13:33 schrieb Wayne Stambaugh: >> I merged your patch into the dev branch. Thank you for your >> contribution to KiCad. > > while working on some translations I come over this commit or fixup and > noticed this and some

Re: [Kicad-developers] pcbnew Append Board functionality not always available

2017-11-11 Thread Wayne Stambaugh
On 11/11/2017 03:28 AM, jp charras wrote: > Le 11/11/2017 à 03:01, David Godfrey a écrit : >> Hi Wayne, >> >> Replying to this particular response as your email didn't arrive on the list >> for me, Simon's did though. >> >> I completely understand about not wanting to rush into enabling it, I ju

Re: [Kicad-developers] adding support for OCCT

2017-11-11 Thread Wayne Stambaugh
That's a show stopper unless someone is willing to step up and fix this issues. Just out of curiosity and a bit of laziness, what is the OCCT license before we decide to make it a dependency? On 11/11/2017 03:43 AM, Nick Østergaard wrote: > It did work for me on archlinux, as in it could build. B

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread Wayne Stambaugh
Hold on a second before you prepare a patch. This would introduce a new semantic to the coordinate entries in the file format which could be open to abuse in the future. I don't want to open up the possibility of using different units within the file format itself and adding units token will open

Re: [Kicad-developers] [FEATURE] Eeschema Line Styles

2017-11-11 Thread Wayne Stambaugh
I don't see here you bumped the schematic file version. Also, I forgot to mention that you need to add the "Fixes lp:XXX" to the commit message when a patch fixes a bug report so that the kicad janitor can automatically tag the bug report as "fix committed". Thanks, Wayne On 11/10/2017 11:5

Re: [Kicad-developers] pcbnew Append Board functionality not always available

2017-11-11 Thread Wayne Stambaugh
I'm guessing these are related. Please let me know if the recent fix solves the problem and I will mark second bug report as a duplicate. Thanks, Wayne On 11/10/2017 08:23 PM, Simon Wells wrote: > Speaking of append board causing crashes > > https://bugs.launchpad.net/kicad/+bug/1728096 > >

Re: [Kicad-developers] Asciidoc question.

2017-11-11 Thread Marco Ciampa
On Fri, Nov 10, 2017 at 08:20:32AM -0500, Wayne Stambaugh wrote: > Maybe one of our resident asciidoc experts can help me out. I used a > WARNING admonition in the kicad website symbol library table blog > post[1]. I was expecting to see the warning icon per the asciidoc > documentation[2] but I

Re: [Kicad-developers] [BUG] Eeschema: project specific libraries does not load

2017-11-11 Thread Константин Барановский
Yes, really now project specific libraries loads correctly but name of table still contain fp-lib-table instead of sym-lib-table. I know it is not critical issue but still. 2017-11-11 13:57 GMT+02:00 jp charras : > Le 11/11/2017 à 12:09, Константин Барановский a écrit : > > In my test project all

Re: [Kicad-developers] [BUG] Eeschema: project specific libraries does not load

2017-11-11 Thread jp charras
Le 11/11/2017 à 12:09, Константин Барановский a écrit : > In my test project all symbols stored in library "components.lib" that stored > in project dir. > I'm open library manager and going to "Project Specific Libraries" tab. > There I'm add this library and save schematic. > After saving in pro

[Kicad-developers] [BUG] Eeschema: project specific libraries does not load

2017-11-11 Thread Константин Барановский
In my test project all symbols stored in library "components.lib" that stored in project dir. I'm open library manager and going to "Project Specific Libraries" tab. There I'm add this library and save schematic. After saving in project dir adds file "sym-lib-table" with added library. But when I o

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread jp charras
Le 11/11/2017 à 11:17, Carsten Schoenert a écrit : > Am 11.11.2017 um 11:07 schrieb jp charras: >>> while working on some translations I come over this commit or fixup and >>> noticed this and some other strings in the showed windows are not >>> translatable. I guess some _(...) magic is missing he

[Kicad-developers] About Bug 1731539:( Append in PcbNew crashes): Usability issues in append commands.

2017-11-11 Thread jp charras
During my work to fix this crash, I encountered a few usability issues both when appending a board, and appending from the clipboard (not surprising because these features share the same code). - When appending (file or clipboard), most of time I had to click twice or 3 times on the left button

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread Carsten Schoenert
Am 11.11.2017 um 11:07 schrieb jp charras: >> while working on some translations I come over this commit or fixup and >> noticed this and some other strings in the showed windows are not >> translatable. I guess some _(...) magic is missing here? I have no full >> knowledge about what needs to be c

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread jp charras
Le 11/11/2017 à 10:00, Carsten Schoenert a écrit : > Hi, > > Am 10.11.2017 um 13:33 schrieb Wayne Stambaugh: >> I merged your patch into the dev branch. Thank you for your >> contribution to KiCad. > > while working on some translations I come over this commit or fixup and > noticed this and som

Re: [Kicad-developers] [PATCH] Fix double "choose to" in symbol remap dialog.

2017-11-11 Thread Carsten Schoenert
Hi, Am 10.11.2017 um 13:33 schrieb Wayne Stambaugh: > I merged your patch into the dev branch. Thank you for your > contribution to KiCad. while working on some translations I come over this commit or fixup and noticed this and some other strings in the showed windows are not translatable. I gue

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread Oliver Walters
JP, Yes I will update with a patch. On 11 Nov 2017 19:45, "jp charras" wrote: > Le 09/11/2017 à 21:48, Oliver Walters a écrit : > > JP, > > > > I think that 3) is the better option, because it preservers PCB file > compatibility (as long as the > > offset is zero). Any time the PCB is saved, th

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

2017-11-11 Thread jp charras
Le 09/11/2017 à 21:48, Oliver Walters a écrit : > JP, > > I think that 3) is the better option, because it preservers PCB file > compatibility (as long as the > offset is zero). Any time the PCB is saved, the (at (xyz 0 0 0)) gets written. > > You are also correct that none of the official libra

Re: [Kicad-developers] adding support for OCCT

2017-11-11 Thread Nick Østergaard
It did work for me on archlinux, as in it could build. But when exporting with kicad2step it seems like it does not export the complete model. Den 11. nov. 2017 03.55 skrev "Simon Wells" : Currently kicad only supports OCE but with FreeCAD moving to occt by default it seems this might not be the

Re: [Kicad-developers] pcbnew Append Board functionality not always available

2017-11-11 Thread jp charras
Le 11/11/2017 à 03:01, David Godfrey a écrit : > Hi Wayne, > > Replying to this particular response as your email didn't arrive on the list > for me, Simon's did though. > > I completely understand about not wanting to rush into enabling it, I just > wanted to raise it to the > surface of the t

Re: [Kicad-developers] [FEATURE] Eeschema Line Styles

2017-11-11 Thread jp charras
Le 11/11/2017 à 05:51, Seth Hillbrand a écrit : > Wayne- > > Thank you for taking the time to look at this patch.  I recognize that you > and the other devs have a > lot on your plate, so I appreciate the constructive feedback. I'll approach > the list with a sketch > in the future for large pat